makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #6169 from 3D-I/ticket/16735

Browse source 
[ticket/16735] Fix access array offset on value of type bool on login
This commit is contained in:
Marc Alexander 2021-03-31 07:40:00 +02:00 • committed by GitHub
commit 9d2fae3285
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
phpBB/phpbb/auth/provider/db.php
View file

@ -153,8 +153,12 @@ class db extends base
} }
$login_error_attempts = 'LOGIN_ERROR_ATTEMPTS'; $login_error_attempts = 'LOGIN_ERROR_ATTEMPTS';
$show_captcha = ($this->config['max_login_attempts'] && $row['user_login_attempts'] >= $this->config['max_login_attempts']) ||
($this->config['ip_login_limit_max'] && $attempts >= $this->config['ip_login_limit_max']); $user_login_attempts = (is_array($row) && $this->config['max_login_attempts'] && $row['user_login_attempts'] >= $this->config['max_login_attempts']);
$ip_login_attempts = ($this->config['ip_login_limit_max'] && $attempts >= $this->config['ip_login_limit_max']);
$show_captcha = $user_login_attempts || $ip_login_attempts;
if ($show_captcha) if ($show_captcha)
{ {
$captcha = $this->captcha_factory->get_instance($this->config['captcha_plugin']); $captcha = $this->captcha_factory->get_instance($this->config['captcha_plugin']);