From 367f884d01b54a2d9cbe8d5d47b1947bb52bf8df Mon Sep 17 00:00:00 2001 From: Jakub Senko Date: Tue, 4 Sep 2018 14:41:00 +0200 Subject: [PATCH 1/2] [ticket/15748] Fix toggle alt text PHPBB3-15748 --- phpBB/assets/javascript/core.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpBB/assets/javascript/core.js b/phpBB/assets/javascript/core.js index 752dfa4ab2..0c528dba5e 100644 --- a/phpBB/assets/javascript/core.js +++ b/phpBB/assets/javascript/core.js @@ -937,7 +937,7 @@ phpbb.addAjaxCallback('alt_text', function() { altText = $this.attr('data-alt-text'); $this.attr('data-alt-text', $this.text()); $this.attr('title', $.trim(altText)); - $this.text(altText); + $this.children('span').text(altText); }); }); From 4d5258b5a3e9595af83ca9192e845fbc22dd7457 Mon Sep 17 00:00:00 2001 From: Derky Date: Fri, 14 Sep 2018 11:34:14 +0200 Subject: [PATCH 2/2] [ticket/15748] Trim whitespace before storing in data attribute PHPBB3-15748 --- phpBB/assets/javascript/core.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/phpBB/assets/javascript/core.js b/phpBB/assets/javascript/core.js index 0c528dba5e..32be1cf6ed 100644 --- a/phpBB/assets/javascript/core.js +++ b/phpBB/assets/javascript/core.js @@ -935,8 +935,8 @@ phpbb.addAjaxCallback('alt_text', function() { $anchor.each(function() { var $this = $(this); altText = $this.attr('data-alt-text'); - $this.attr('data-alt-text', $this.text()); - $this.attr('title', $.trim(altText)); + $this.attr('data-alt-text', $.trim($this.text())); + $this.attr('title', altText); $this.children('span').text(altText); }); });