makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11469] Do not repeat markTestSkipped() message.

Browse source 
PHPBB3-11469
This commit is contained in:
Andreas Fischer 2013-03-27 23:55:26 +01:00
parent 6f946e2188
commit a04fe625a8
1 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
tests/dbal/sql_insert_buffer_test.php
View file

@ -43,10 +43,7 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
public function test_multi_insert_enabled_insert_and_flush() public function test_multi_insert_enabled_insert_and_flush()
{ {
if (!$this->db->multi_insert) $this->check_multi_insert_support();
{
$this->markTestSkipped('Database does not support multi_insert');
}
// This call can be buffered // This call can be buffered
$this->assertFalse($this->buffer->insert($this->get_row(1))); $this->assertFalse($this->buffer->insert($this->get_row(1)));
@ -73,10 +70,7 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
public function test_multi_insert_enabled_insert_with_flush() public function test_multi_insert_enabled_insert_with_flush()
{ {
if (!$this->db->multi_insert) $this->check_multi_insert_support();
{
$this->markTestSkipped('Database does not support multi_insert');
}
$this->assertFalse($this->buffer->insert($this->get_row(1))); $this->assertFalse($this->buffer->insert($this->get_row(1)));
@ -97,10 +91,7 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
public function test_multi_insert_enabled_insert_all_and_flush() public function test_multi_insert_enabled_insert_all_and_flush()
{ {
if (!$this->db->multi_insert) $this->check_multi_insert_support();
{
$this->markTestSkipped('Database does not support multi_insert');
}
$this->assertTrue($this->buffer->insert_all($this->get_rows(3))); $this->assertTrue($this->buffer->insert_all($this->get_rows(3)));
@ -121,6 +112,14 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
$this->db->sql_freeresult($result); $this->db->sql_freeresult($result);
} }
protected function check_multi_insert_support()
{
if (!$this->db->multi_insert)
{
$this->markTestSkipped('Database does not support multi_insert');
}
}
protected function get_row($rownum) protected function get_row($rownum)
{ {
return array( return array(