makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-27 04:18:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10005] Add description to test cases

Browse source 
PHPBB3-10005
This commit is contained in:
Nils Adermann 2011-06-03 03:12:13 +02:00
parent 7b10f859de
commit a2b6605ce8
1 changed files with 13 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
tests/profile/custom_test.php
View file

@ -19,20 +19,23 @@ class phpbb_profile_custom_test extends phpbb_database_test_case
static public function dropdownFields() static public function dropdownFields()
{ {
return array( return array(
// novalue, required, value, expected // note, there is an offset of 1 between option_id (0-indexed)
array(1, 1, '0', 'FIELD_INVALID_VALUE'), // in the database and values (1-indexed) to avoid problems with
array(1, 1, '1', 'FIELD_REQUIRED'), // transmitting 0 in an HTML form
array(1, 1, '2', false), // required, value, expected
array(1, 0, '0', 'FIELD_INVALID_VALUE'), array(1, '0', 'FIELD_INVALID_VALUE', 'Required field should throw error for out-of-range value'),
array(1, 0, '1', false), array(1, '1', 'FIELD_REQUIRED', 'Required field should throw error for default value'),
array(1, 0, '2', false), array(1, '2', false, 'Required field should accept non-default value'),
array(0, '0', 'FIELD_INVALID_VALUE', 'Optional field should throw error for out-of-range value'),
array(0, '1', false, 'Optional field should accept default value'),
array(0, '2', false, 'Optional field should accept non-default value'),
); );
} }
/** /**
* @dataProvider dropdownFields * @dataProvider dropdownFields
*/ */
public function test_dropdown_validate($field_novalue, $field_required, $field_value, $expected) public function test_dropdown_validate($field_required, $field_value, $expected, $description)
{ {
global $db; global $db;
$db = $this->new_dbal(); $db = $this->new_dbal();
@ -40,13 +43,13 @@ class phpbb_profile_custom_test extends phpbb_database_test_case
$field_data = array( $field_data = array(
'field_id' => 1, 'field_id' => 1,
'lang_id' => 1, 'lang_id' => 1,
'field_novalue' => $field_novalue, 'field_novalue' => 1,
'field_required' => $field_required, 'field_required' => $field_required,
); );
$cp = new custom_profile; $cp = new custom_profile;
$result = $cp->validate_profile_field(FIELD_DROPDOWN, &$field_value, $field_data); $result = $cp->validate_profile_field(FIELD_DROPDOWN, &$field_value, $field_data);
$this->assertEquals($expected, $result); $this->assertEquals($expected, $result, $description);
} }
} }