makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-12 06:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/15294] Back to the all DBMS compliant splitted queries

Browse source 
PHPBB3-15294
This commit is contained in:
rxu 2019-11-04 13:36:58 +07:00
parent 46a68d37ee
commit a340c362bc
No known key found for this signature in database
GPG key ID: 955F0567380E586A
1 changed files with 15 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
phpBB/phpbb/session.php
View file

@ -959,11 +959,12 @@ class session
$this->time_now = time(); $this->time_now = time();
} }
// Get expired sessions, only most recent for each registered user /**
// Inner SELECT gets most recent expired sessions data for unique session_user_id * Get expired sessions for registered users, only most recent for each user
// Outer SELECT gets also session_page for them * Inner SELECT gets most recent expired sessions for unique session_user_id
$sql_select = '( * Outer SELECT gets data for them
SELECT s1.session_page, s1.session_user_id, s1.session_time AS recent_time */
$sql = 'SELECT s1.session_page, s1.session_user_id, s1.session_time AS recent_time
FROM ' . SESSIONS_TABLE . ' AS s1 FROM ' . SESSIONS_TABLE . ' AS s1
INNER JOIN ( INNER JOIN (
SELECT session_user_id, MAX(session_time) AS recent_time SELECT session_user_id, MAX(session_time) AS recent_time
@ -973,32 +974,21 @@ class session
GROUP BY session_user_id GROUP BY session_user_id
) AS s2 ) AS s2
ON s1.session_user_id = s2.session_user_id ON s1.session_user_id = s2.session_user_id
AND s1.session_time = s2.recent_time AND s1.session_time = s2.recent_time';
) AS s3'; $result = $db->sql_query($sql);
// Update user session data from above selected result while ($row = $db->sql_fetchrow($result))
switch ($db->get_sql_layer())
{ {
case 'sqlite3': $sql = 'UPDATE ' . USERS_TABLE . '
case 'mysqli': SET user_lastvisit = ' . (int) $row['recent_time'] . ", user_lastpage = '" . $db->sql_escape($row['session_page']) . "'
$sql = 'UPDATE ' . USERS_TABLE . " AS u, WHERE user_id = " . (int) $row['session_user_id'];
$sql_select $db->sql_query($sql);
SET u.user_lastvisit = s3.recent_time, u.user_lastpage = s3.session_page
WHERE u.user_id = s3.session_user_id";
break;
default:
$sql = 'UPDATE ' . USERS_TABLE . "
SET user_lastvisit = s3.recent_time, user_lastpage = s3.session_page
FROM $sql_select
WHERE user_id = s3.session_user_id";
break;
} }
$db->sql_query($sql); $db->sql_freeresult($result);
// Delete all expired sessions // Delete all expired sessions
$sql = 'DELETE FROM ' . SESSIONS_TABLE . ' $sql = 'DELETE FROM ' . SESSIONS_TABLE . '
WHERE session_time < ' . ($this->time_now - $config['session_length']); WHERE session_time < ' . ($this->time_now - (int) $config['session_length']);
$db->sql_query($sql); $db->sql_query($sql);
// Update gc timer // Update gc timer