makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Let's face it - the most common setup we see with phpBB is having group-specific settings for external users (FTP, whatever).

Browse source 
Changed phpbb_chmod() to set the group bit, even if the PHP user is the owner. (somehow this sounds complicated, i hope you get the idea).

git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9131 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Meik Sievertsen 2008-11-30 11:48:33 +00:00
parent 481e5c193f
commit a3cbc3d671
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
phpBB/docs/CHANGELOG.html
View file

@ -96,6 +96,7 @@
<li>[Fix] Properly treat punctuation marks after local urls (Bug #37055)</li> <li>[Fix] Properly treat punctuation marks after local urls (Bug #37055)</li>
<li>[Fix] Make searching for members by YIM address work in prosilver</li> <li>[Fix] Make searching for members by YIM address work in prosilver</li>
<li>[Fix] Tell users to recreate the search index after changing the common word threshold for fulltext_native (Bug #36345)</li> <li>[Fix] Tell users to recreate the search index after changing the common word threshold for fulltext_native (Bug #36345)</li>
<li>[Fix] Adjusted phpbb_chmod() to always set permissions for group bit.</li>
<li>[Change] Alllow applications to set custom module inclusion path (idea by HoL)</li> <li>[Change] Alllow applications to set custom module inclusion path (idea by HoL)</li>
<li>[Change] Handle checking for duplicate usernames in chunks (Bug #17285 - Patch by A_Jelly_Doughnut)</li> <li>[Change] Handle checking for duplicate usernames in chunks (Bug #17285 - Patch by A_Jelly_Doughnut)</li>
<li>[Change] Better handling and finer control for custom profile fields visibility options. (Patch by Highway of Life)</li> <li>[Change] Better handling and finer control for custom profile fields visibility options. (Patch by Highway of Life)</li>

7
phpBB/includes/functions.php
View file

@ -462,7 +462,7 @@ function _hash_crypt_private($password, $setting, &$itoa64)
/** /**
* Global function for chmodding directories and files for internal use * Global function for chmodding directories and files for internal use
* This function determines owner and group whom the file belongs to and user and group of PHP and then set safest possible file permissions. * This function determines owner and group whom the file belongs to and user and group of PHP and then set safest possible file permissions.
* The function determines owner and group from common.php file and sets the same to the provided file. * The function determines owner and group from common.php file and sets the same to the provided file. Permissions are mapped to the group, user always has rw(x) permission.
* The function uses bit fields to build the permissions. * The function uses bit fields to build the permissions.
* The function sets the appropiate execute bit on directories. * The function sets the appropiate execute bit on directories.
* *
@ -532,7 +532,7 @@ function phpbb_chmod($filename, $perms = CHMOD_READ)
// Who is PHP? // Who is PHP?
if ($file_uid === false || $file_gid === false || $php_uid === false || $php_gids === false) if ($file_uid === false || $file_gid === false || $php_uid === false || $php_gids === false)
{ {
$php = null; $php = NULL;
} }
else if ($file_uid == $php_uid /* && $common_php_owner !== false && $common_php_owner === $file_uid*/) else if ($file_uid == $php_uid /* && $common_php_owner !== false && $common_php_owner === $file_uid*/)
{ {
@ -564,12 +564,15 @@ function phpbb_chmod($filename, $perms = CHMOD_READ)
{ {
case null: case null:
case 'owner': case 'owner':
/* ATTENTION: if php is owner or NULL we set it to group here. This is the most failsafe combination for the vast majority of server setups.
$result = @chmod($filename, ($owner << 6) + (0 << 3) + (0 << 0)); $result = @chmod($filename, ($owner << 6) + (0 << 3) + (0 << 0));
if (!is_null($php) || (is_readable($filename) && is_writable($filename))) if (!is_null($php) || (is_readable($filename) && is_writable($filename)))
{ {
break; break;
} }
*/
case 'group': case 'group':
$result = @chmod($filename, ($owner << 6) + ($perms << 3) + (0 << 0)); $result = @chmod($filename, ($owner << 6) + ($perms << 3) + (0 << 0));