makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-07 20:08:53 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/17135] Assert xCP modules array is not empty and test output

Browse source 
PHPBB-17135
This commit is contained in:
rxu 2025-01-06 21:35:30 +07:00
parent cd17625e21
commit a447f957ba
No known key found for this signature in database
GPG key ID: 955F0567380E586A
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tests/functional/acp_test.php
View file

@ -25,6 +25,7 @@ class phpbb_functional_acp_test extends phpbb_functional_test_case
// Browse ACP main page // Browse ACP main page
$crawler = self::request('GET', 'index.php'); $crawler = self::request('GET', 'index.php');
$crawler = self::$client->click($crawler->selectLink($this->lang('ACP_SHORT'))->link()); $crawler = self::$client->click($crawler->selectLink($this->lang('ACP_SHORT'))->link());
self::assert_response_html();
// Get all ACP module URLs array // Get all ACP module URLs array
$acp_modules = $crawler->filter('li.tab a')->each( $acp_modules = $crawler->filter('li.tab a')->each(
@ -37,24 +38,28 @@ class phpbb_functional_acp_test extends phpbb_functional_test_case
} }
} }
); );
$this->assertNotEmpty($acp_modules);
// Browse all ACP modules and get their mode URLs array // Browse all ACP modules and get their mode URLs array
$acp_submodules = []; $acp_submodules = [];
foreach ($acp_modules as $module) foreach ($acp_modules as $module)
{ {
$crawler = self::$client->click($module); $crawler = self::$client->click($module);
$acp_submodules = array_merge($acp_submodules, $crawler->filter('div.menu_block li a')->each( self::assert_response_html();
$acp_submodules = array_merge($acp_submodules, $crawler->filter('div.menu-block li a')->each(
function ($node, $i) function ($node, $i)
{ {
return $node->link(); return $node->link();
} }
)); ));
} }
$this->assertNotEmpty($acp_submodules);
// Browse all ACP submodules' modes // Browse all ACP submodules' modes
foreach ($acp_submodules as $acp_submodule) foreach ($acp_submodules as $acp_submodule)
{ {
self::$client->click($acp_submodule); self::$client->click($acp_submodule);
self::assert_response_html();
} }
} }
} }

5
tests/functional/mcp/mcp_test.php
View file

@ -24,6 +24,7 @@ class phpbb_functional_mcp_test extends phpbb_functional_test_case
// Browse MCP main page // Browse MCP main page
$crawler = self::request('GET', 'index.php'); $crawler = self::request('GET', 'index.php');
$crawler = self::$client->click($crawler->selectLink($this->lang('MCP_SHORT'))->link()); $crawler = self::$client->click($crawler->selectLink($this->lang('MCP_SHORT'))->link());
self::assert_response_html();
// Get all MCP module URLs array // Get all MCP module URLs array
$mcp_modules = $crawler->filter('.tabs a')->each( $mcp_modules = $crawler->filter('.tabs a')->each(
@ -32,12 +33,14 @@ class phpbb_functional_mcp_test extends phpbb_functional_test_case
return $node->link(); return $node->link();
} }
); );
$this->assertNotEmpty($mcp_modules);
// Browse all MCP modules and get their mode URLs array // Browse all MCP modules and get their mode URLs array
$mcp_submodules = []; $mcp_submodules = [];
foreach ($mcp_modules as $module) foreach ($mcp_modules as $module)
{ {
$crawler = self::$client->click($module); $crawler = self::$client->click($module);
self::assert_response_html();
$mcp_submodules = array_merge($mcp_submodules, $crawler->filter('.cp-menu a')->each( $mcp_submodules = array_merge($mcp_submodules, $crawler->filter('.cp-menu a')->each(
function ($node, $i) function ($node, $i)
{ {
@ -45,11 +48,13 @@ class phpbb_functional_mcp_test extends phpbb_functional_test_case
} }
)); ));
} }
$this->assertNotEmpty($mcp_submodules);
// Browse all MCP submodules' modes // Browse all MCP submodules' modes
foreach ($mcp_submodules as $mcp_submodule) foreach ($mcp_submodules as $mcp_submodule)
{ {
self::$client->click($mcp_submodule); self::$client->click($mcp_submodule);
self::assert_response_html();
} }
} }
} }