diff --git a/phpBB/admin/admin_db_utilities.php b/phpBB/admin/admin_db_utilities.php index 6543d128b2..ab13a85cb4 100644 --- a/phpBB/admin/admin_db_utilities.php +++ b/phpBB/admin/admin_db_utilities.php @@ -34,16 +34,10 @@ if( !empty($setmodules) ) { $filename = basename(__FILE__); $module['General']['Backup_DB'] = $filename . "?perform=backup"; - if(@phpversion() >= '4.0.0') - { - $file_uploads = @ini_get('file_uploads'); - } - else - { - $file_uploads = @get_cfg_var('file_uploads'); - } - if( ($file_uploads != 0 || empty($file_uploads)) && (strtolower($file_uploads) != 'off') && (@phpversion() != '4.0.4pl1') ) + $file_uploads = (@phpversion() >= '4.0.0') ? @ini_get('file_uploads') : @get_cfg_var('file_uploads'); + + if( (empty($file_uploads) || $file_uploads != 0) && (strtolower($file_uploads) != 'off') && (@phpversion() != '4.0.4pl1') ) { $module['General']['Restore_DB'] = $filename . "?perform=restore"; } @@ -672,7 +666,6 @@ function output_table_content($content) // // Begin program proper // - if( isset($HTTP_GET_VARS['perform']) || isset($HTTP_POST_VARS['perform']) ) { $perform = (isset($HTTP_POST_VARS['perform'])) ? $HTTP_POST_VARS['perform'] : $HTTP_GET_VARS['perform']; @@ -681,21 +674,26 @@ if( isset($HTTP_GET_VARS['perform']) || isset($HTTP_POST_VARS['perform']) ) { case 'backup': - if( SQL_LAYER == 'oracle' || SQL_LAYER == 'odbc' || SQL_LAYER == 'mssql' ) + $error = false; + switch(SQL_LAYER) { - switch(SQL_LAYER) - { - case 'oracle': - $db_type = "Oracle"; - break; - case 'odbc': - $db_type = "ODBC"; - break; - case 'mssql': - $db_type = "MSSQL"; - break; - } + case 'oracle': + $error = true; + break; + case 'db2': + $error = true; + break; + case 'msaccess': + $error = true; + break; + case 'mssql': + case 'mssql-odbc': + $error = true; + break; + } + if ($error) + { include('./page_header_admin.'.$phpEx); $template->set_filenames(array( @@ -709,12 +707,11 @@ if( isset($HTTP_GET_VARS['perform']) || isset($HTTP_POST_VARS['perform']) ) $template->pparse("body"); - break; + include('./page_footer_admin.'.$phpEx); } $tables = array('auth_access', 'banlist', 'categories', 'config', 'disallow', 'forums', 'forum_prune', 'groups', 'posts', 'posts_text', 'privmsgs', 'privmsgs_text', 'ranks', 'search_results', 'search_wordlist', 'search_wordmatch', 'sessions', 'smilies', 'themes', 'themes_name', 'topics', 'topics_watch', 'user_group', 'users', 'vote_desc', 'vote_results', 'vote_voters', 'words'); - $additional_tables = (isset($HTTP_POST_VARS['additional_tables'])) ? $HTTP_POST_VARS['additional_tables'] : ( (isset($HTTP_GET_VARS['additional_tables'])) ? $HTTP_GET_VARS['additional_tables'] : "" ); $backup_type = (isset($HTTP_POST_VARS['backup_type'])) ? $HTTP_POST_VARS['backup_type'] : ( (isset($HTTP_GET_VARS['backup_type'])) ? $HTTP_GET_VARS['backup_type'] : "" ); @@ -780,7 +777,7 @@ if( isset($HTTP_GET_VARS['perform']) || isset($HTTP_POST_VARS['perform']) ) ); $template->assign_vars(array( - "META" => "", + "META" => '', "MESSAGE_TITLE" => $lang['Database_Utilities'] . " : " . $lang['Backup'], "MESSAGE_TEXT" => $lang['Backup_download']) diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html index 6f032257d5..7291ef235f 100644 --- a/phpBB/docs/CHANGELOG.html +++ b/phpBB/docs/CHANGELOG.html @@ -103,6 +103,13 @@ h3 {font-size:12pt;color:blue}
  • Fixed non-check of permissions when deleting a topic via Moderator Control Panel
  • Fixed non-update of banlist upon user deletion
  • Check approved users boxes by default in usergroup approve form
  • +
  • Fixed non-appending of sid to backup meta refresh
  • +
  • Fixed non-notification of no support for certain databases in backup/restore
  • +
  • Added $images var to message die global declaration
  • +
  • Fixed wrong string, Private_message in Private Messaging
  • +
  • Add mail send result to error output
  • +
  • Fixed non-appending of sid to Mozilla nav bar menu items
  • +
  • Fixed incorrect profile linking from MSNM url in private messaging
  • diff --git a/phpBB/includes/emailer.php b/phpBB/includes/emailer.php index 2192b886b4..c9789f23e3 100755 --- a/phpBB/includes/emailer.php +++ b/phpBB/includes/emailer.php @@ -197,7 +197,7 @@ class emailer if ( !$result ) { - message_die(GENERAL_ERROR, 'Failed sending email', '', __LINE__, __FILE__); + message_die(GENERAL_ERROR, 'Failed sending email :: ' . $result, '', __LINE__, __FILE__); } return true;