makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Missing read permission from calls to phpbb_chmod()

Browse source 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9208 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Chris Smith 2008-12-19 20:36:18 +00:00
parent cd6e5a85e7
commit a94ed97992
4 changed files with 25 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
phpBB/docs/CHANGELOG.html
View file

@ -53,6 +53,7 @@
<ol> <ol>
<li><a href="#changelog">Changelog</a> <li><a href="#changelog">Changelog</a>
<ol style="list-style-type: lower-roman;"> <ol style="list-style-type: lower-roman;">
<li><a href="#v304">Changes since 3.0.4</a></li>
<li><a href="#v303">Changes since 3.0.3</a></li> <li><a href="#v303">Changes since 3.0.3</a></li>
<li><a href="#v302">Changes since 3.0.2</a></li> <li><a href="#v302">Changes since 3.0.2</a></li>
<li><a href="#v301">Changes since 3.0.1</a></li> <li><a href="#v301">Changes since 3.0.1</a></li>
@ -83,7 +84,13 @@
<div class="inner"><span class="corners-top"><span></span></span> <div class="inner"><span class="corners-top"><span></span></span>
<div class="content"> <div class="content">
<a name="v303"></a><h3>1.i. Changes since 3.0.3</h3> <a name="v304"></a><h3>1.i. Changes since 3.0.4</h3>
<ul>
<li>[Fix] Missing read permission from calls to phpbb_chmod()</li>
</ul>
<a name="v303"></a><h3>1.ii. Changes since 3.0.3</h3>
<ul> <ul>
<li>[Fix] Allow mixed-case template directories to be inherited (Bug #36725)</li> <li>[Fix] Allow mixed-case template directories to be inherited (Bug #36725)</li>
@ -115,7 +122,7 @@
<li>[Sec] Ask for forum password if post within passworded forum quoted in private message. (Reported by nickvergessen)</li> <li>[Sec] Ask for forum password if post within passworded forum quoted in private message. (Reported by nickvergessen)</li>
</ul> </ul>
<a name="v302"></a><h3>1.ii. Changes since 3.0.2</h3> <a name="v302"></a><h3>1.iii. Changes since 3.0.2</h3>
<ul> <ul>
<li>[Fix] Correctly set topic starter if first post in topic removed (Bug #30575 - Patch by blueray2048)</li> <li>[Fix] Correctly set topic starter if first post in topic removed (Bug #30575 - Patch by blueray2048)</li>
@ -214,7 +221,7 @@
<li>[Sec Precaution] Stricter validation of the HTTP_HOST header (Thanks to Techie-Micheal et al for pointing out possible issues in derived code)</li> <li>[Sec Precaution] Stricter validation of the HTTP_HOST header (Thanks to Techie-Micheal et al for pointing out possible issues in derived code)</li>
</ul> </ul>
<a name="v301"></a><h3>1.iii. Changes since 3.0.1</h3> <a name="v301"></a><h3>1.iv. Changes since 3.0.1</h3>
<ul> <ul>
<li>[Fix] Ability to set permissions on non-mysql dbms (Bug #24955)</li> <li>[Fix] Ability to set permissions on non-mysql dbms (Bug #24955)</li>
@ -262,7 +269,7 @@
<li>[Sec] Only allow urls gone through redirect() being used within login_box(). (thanks nookieman)</li> <li>[Sec] Only allow urls gone through redirect() being used within login_box(). (thanks nookieman)</li>
</ul> </ul>
<a name="v300"></a><h3>1.iv. Changes since 3.0.0</h3> <a name="v300"></a><h3>1.v. Changes since 3.0.0</h3>
<ul> <ul>
<li>[Change] Validate birthdays (Bug #15004)</li> <li>[Change] Validate birthdays (Bug #15004)</li>
@ -333,7 +340,7 @@
<li>[Fix] Find and display colliding usernames correctly when converting from one database to another (Bug #23925)</li> <li>[Fix] Find and display colliding usernames correctly when converting from one database to another (Bug #23925)</li>
</ul> </ul>
<a name="v30rc8"></a><h3>1.v. Changes since 3.0.RC8</h3> <a name="v30rc8"></a><h3>1.vi. Changes since 3.0.RC8</h3>
<ul> <ul>
<li>[Fix] Cleaned usernames contain only single spaces, so &quot;a_name&quot; and &quot;a__name&quot; are treated as the same name (Bug #15634)</li> <li>[Fix] Cleaned usernames contain only single spaces, so &quot;a_name&quot; and &quot;a__name&quot; are treated as the same name (Bug #15634)</li>
@ -342,7 +349,7 @@
<li>[Fix] Call garbage_collection() within database updater to correctly close connections (affects Oracle for example)</li> <li>[Fix] Call garbage_collection() within database updater to correctly close connections (affects Oracle for example)</li>
</ul> </ul>
<a name="v30rc7"></a><h3>1.vi. Changes since 3.0.RC7</h3> <a name="v30rc7"></a><h3>1.vii. Changes since 3.0.RC7</h3>
<ul> <ul>
<li>[Fix] Fixed MSSQL related bug in the update system</li> <li>[Fix] Fixed MSSQL related bug in the update system</li>
@ -377,7 +384,7 @@
<li>[Fix] No duplication of active topics (Bug #15474)</li> <li>[Fix] No duplication of active topics (Bug #15474)</li>
</ul> </ul>
<a name="v30rc6"></a><h3>1.vii. Changes since 3.0.RC6</h3> <a name="v30rc6"></a><h3>1.viii. Changes since 3.0.RC6</h3>
<ul> <ul>
<li>[Fix] Submitting language changes using acp_language (Bug #14736)</li> <li>[Fix] Submitting language changes using acp_language (Bug #14736)</li>
@ -387,7 +394,7 @@
<li>[Fix] Able to request new password (Bug #14743)</li> <li>[Fix] Able to request new password (Bug #14743)</li>
</ul> </ul>
<a name="v30rc5"></a><h3>1.viii. Changes since 3.0.RC5</h3> <a name="v30rc5"></a><h3>1.ix. Changes since 3.0.RC5</h3>
<ul> <ul>
<li>[Feature] Removing constant PHPBB_EMBEDDED in favor of using an exit_handler(); the constant was meant to achive this more or less.</li> <li>[Feature] Removing constant PHPBB_EMBEDDED in favor of using an exit_handler(); the constant was meant to achive this more or less.</li>
@ -450,7 +457,7 @@
<li>[Sec] New password hashing mechanism for storing passwords (#i42)</li> <li>[Sec] New password hashing mechanism for storing passwords (#i42)</li>
</ul> </ul>
<a name="v30rc4"></a><h3>1.ix. Changes since 3.0.RC4</h3> <a name="v30rc4"></a><h3>1.x. Changes since 3.0.RC4</h3>
<ul> <ul>
<li>[Fix] MySQL, PostgreSQL and SQLite related database fixes (Bug #13862)</li> <li>[Fix] MySQL, PostgreSQL and SQLite related database fixes (Bug #13862)</li>
@ -501,7 +508,7 @@
<li>[Fix] odbc_autocommit causing existing result sets to be dropped (Bug #14182)</li> <li>[Fix] odbc_autocommit causing existing result sets to be dropped (Bug #14182)</li>
</ul> </ul>
<a name="v30rc3"></a><h3>1.x. Changes since 3.0.RC3</h3> <a name="v30rc3"></a><h3>1.xi. Changes since 3.0.RC3</h3>
<ul> <ul>
<li>[Fix] Fixing some subsilver2 and prosilver style issues</li> <li>[Fix] Fixing some subsilver2 and prosilver style issues</li>
@ -610,7 +617,7 @@
</ul> </ul>
<a name="v30rc2"></a><h3>1.xi. Changes since 3.0.RC2</h3> <a name="v30rc2"></a><h3>1.xii. Changes since 3.0.RC2</h3>
<ul> <ul>
<li>[Fix] Re-allow searching within the memberlist</li> <li>[Fix] Re-allow searching within the memberlist</li>
@ -656,7 +663,7 @@
</ul> </ul>
<a name="v30rc1"></a><h3>1.xii. Changes since 3.0.RC1</h3> <a name="v30rc1"></a><h3>1.xiii. Changes since 3.0.RC1</h3>
<ul> <ul>
<li>[Fix] (X)HTML issues within the templates (Bug #11255, #11255)</li> <li>[Fix] (X)HTML issues within the templates (Bug #11255, #11255)</li>

6
phpBB/includes/acm/acm_file.php
View file

@ -99,7 +99,7 @@ class acm
include($phpbb_root_path . 'includes/functions.' . $phpEx); include($phpbb_root_path . 'includes/functions.' . $phpEx);
} }
phpbb_chmod($this->cache_dir . 'data_global.' . $phpEx, CHMOD_WRITE); phpbb_chmod($this->cache_dir . 'data_global.' . $phpEx, CHMOD_READ | CHMOD_WRITE);
} }
else else
{ {
@ -209,7 +209,7 @@ class acm
include($phpbb_root_path . 'includes/functions.' . $phpEx); include($phpbb_root_path . 'includes/functions.' . $phpEx);
} }
phpbb_chmod($this->cache_dir . "data{$var_name}.$phpEx", CHMOD_WRITE); phpbb_chmod($this->cache_dir . "data{$var_name}.$phpEx", CHMOD_READ | CHMOD_WRITE);
} }
} }
else else
@ -434,7 +434,7 @@ class acm
include($phpbb_root_path . 'includes/functions.' . $phpEx); include($phpbb_root_path . 'includes/functions.' . $phpEx);
} }
phpbb_chmod($filename, CHMOD_WRITE); phpbb_chmod($filename, CHMOD_READ | CHMOD_WRITE);
$query_result = $query_id; $query_result = $query_id;
} }

4
phpBB/includes/functions_messenger.php
View file

@ -708,7 +708,7 @@ class queue
@flock($fp, LOCK_UN); @flock($fp, LOCK_UN);
fclose($fp); fclose($fp);
phpbb_chmod($this->cache_file, CHMOD_WRITE); phpbb_chmod($this->cache_file, CHMOD_READ | CHMOD_WRITE);
} }
} }
@ -749,7 +749,7 @@ class queue
@flock($fp, LOCK_UN); @flock($fp, LOCK_UN);
fclose($fp); fclose($fp);
phpbb_chmod($this->cache_file, CHMOD_WRITE); phpbb_chmod($this->cache_file, CHMOD_READ | CHMOD_WRITE);
} }
} }
} }

2
phpBB/includes/functions_template.php
View file

@ -755,7 +755,7 @@ class template_compile
@flock($fp, LOCK_UN); @flock($fp, LOCK_UN);
@fclose($fp); @fclose($fp);
phpbb_chmod($filename, CHMOD_WRITE); phpbb_chmod($filename, CHMOD_READ | CHMOD_WRITE);
} }
return; return;