[ticket/13713] Properly handle empty colour strings

PHPBB3-13713
This commit is contained in:
lavigor 2018-06-06 03:58:33 +03:00 committed by Marc Alexander
parent 4b31a29c2c
commit ac8adcb9a6
No known key found for this signature in database
GPG key ID: 50E0D2423696F995

View file

@ -126,7 +126,7 @@ class mention_helper
{ {
$attributes['profile_url'] = str_replace('{USER_ID}', $attributes['user_id'], $user_profile_url); $attributes['profile_url'] = str_replace('{USER_ID}', $attributes['user_id'], $user_profile_url);
if (isset($this->cached_colors['users'][$attributes['user_id']])) if (!empty($this->cached_colors['users'][$attributes['user_id']]))
{ {
$attributes['color'] = $this->cached_colors['users'][$attributes['user_id']]; $attributes['color'] = $this->cached_colors['users'][$attributes['user_id']];
} }
@ -135,7 +135,7 @@ class mention_helper
{ {
$attributes['profile_url'] = str_replace('{GROUP_ID}', $attributes['group_id'], $group_profile_url); $attributes['profile_url'] = str_replace('{GROUP_ID}', $attributes['group_id'], $group_profile_url);
if (isset($this->cached_colors['groups'][$attributes['group_id']])) if (!empty($this->cached_colors['groups'][$attributes['group_id']]))
{ {
$attributes['color'] = $this->cached_colors['groups'][$attributes['group_id']]; $attributes['color'] = $this->cached_colors['groups'][$attributes['group_id']];
} }