Fixed error which would cause failure when making user an admin

git-svn-id: file:///svn/phpbb/trunk@1234 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Paul S. Owen 2001-10-17 00:42:37 +00:00
parent 390928f4ee
commit ad4bc2586b

View file

@ -133,15 +133,15 @@ if(isset($HTTP_POST_VARS['submit']) && !empty($HTTP_POST_VARS[POST_USERS_URL]))
// //
// Get group_id for this user_id // Get group_id for this user_id
// //
$sql_groupid = "SELECT ug.group_id, u.user_level $sql = "SELECT ug.group_id, u.user_level
FROM " . USER_GROUP_TABLE . " ug, " . USERS_TABLE . " u, " . GROUPS_TABLE . " g FROM " . USER_GROUP_TABLE . " ug, " . USERS_TABLE . " u, " . GROUPS_TABLE . " g
WHERE u.user_id = $user_id WHERE u.user_id = $user_id
AND ug.user_id = u.user_id AND ug.user_id = u.user_id
AND g.group_id = ug.group_id AND g.group_id = ug.group_id
AND g.group_single_user = " . TRUE; AND g.group_single_user = " . TRUE;
if(!$result = $db->sql_query($sql_groupid)) if( !$result = $db->sql_query($sql) )
{ {
// Error no such user/group message_die(GENERAL_ERROR, "Couldn't select info from user/user_group table", "", __LINE__, __FILE__, $sql);
} }
$ug_info = $db->sql_fetchrow($result); $ug_info = $db->sql_fetchrow($result);
@ -163,7 +163,7 @@ if(isset($HTTP_POST_VARS['submit']) && !empty($HTTP_POST_VARS[POST_USERS_URL]))
WHERE group_id = " . $ug_info['group_id']; WHERE group_id = " . $ug_info['group_id'];
if(!$result = $db->sql_query($sql)) if(!$result = $db->sql_query($sql))
{ {
// Error ... message_die(GENERAL_ERROR, "Couldn't update auth access", "", __LINE__, __FILE__, $sql);
} }
// //
@ -174,11 +174,11 @@ if(isset($HTTP_POST_VARS['submit']) && !empty($HTTP_POST_VARS[POST_USERS_URL]))
WHERE user_id = $user_id"; WHERE user_id = $user_id";
if(!$result = $db->sql_query($sql)) if(!$result = $db->sql_query($sql))
{ {
// Error ... message_die(GENERAL_ERROR, "Couldn't update user level", "", __LINE__, __FILE__, $sql);
} }
} }
header("Location: " . append_sid("admin_userauth.$phpEx?" . POST_USERS_URL . "=$user_id")); header("Location: " . append_sid("admin_userauth.$phpEx?" . POST_USERS_URL . "=$user_id", true));
} }
else if( $HTTP_POST_VARS['userlevel'] == "admin" && $ug_info['user_level'] != ADMIN ) else if( $HTTP_POST_VARS['userlevel'] == "admin" && $ug_info['user_level'] != ADMIN )
@ -187,35 +187,35 @@ if(isset($HTTP_POST_VARS['submit']) && !empty($HTTP_POST_VARS[POST_USERS_URL]))
// //
// Make user an admin (if already user) // Make user an admin (if already user)
// //
$sql_userlevel = "UPDATE " . USERS_TABLE . " $sql = "UPDATE " . USERS_TABLE . "
SET user_level = " . ADMIN . " SET user_level = " . ADMIN . "
WHERE user_id = $user_id"; WHERE user_id = $user_id";
if(!$result = $db->sql_query($sql_userlevel)) if( !$result = $db->sql_query($sql) )
{ {
// Error ... message_die(GENERAL_ERROR, "Couldn't update user level", "", __LINE__, __FILE__, $sql);
} }
// Delete any entries in auth_access, they // Delete any entries in auth_access, they
// are unrequired if user is becoming an // are unrequired if user is becoming an
// admin // admin
// //
$sql_unmod = "UPDATE " . AUTH_ACCESS_TABLE . " $sql = "UPDATE " . AUTH_ACCESS_TABLE . "
SET auth_view = 0, auth_read = 0, auth_post = 0, auth_reply = 0, auth_edit = 0, auth_delete = 0, auth_sticky = 0, auth_announce = 0 SET auth_view = 0, auth_read = 0, auth_post = 0, auth_reply = 0, auth_edit = 0, auth_delete = 0, auth_sticky = 0, auth_announce = 0
WHERE group_id = " . $ug_info['group_id']; WHERE group_id = " . $ug_info['group_id'];
if(!$result = $db->sql_query($sql_unmod)) if( !$result = $db->sql_query($sql) )
{ {
// Error ... message_die(GENERAL_ERROR, "Couldn't update auth access", "", __LINE__, __FILE__, $sql);
} }
$sql_unauth = "DELETE FROM " . AUTH_ACCESS_TABLE . " $sql = "DELETE FROM " . AUTH_ACCESS_TABLE . "
WHERE group_id = $group_id WHERE group_id = " . $ug_info['group_id'] . "
AND auth_mod = 0"; AND auth_mod = 0";
if(!$result = $db->sql_query($sql_unauth)) if( !$result = $db->sql_query($sql) )
{ {
// Error ... message_die(GENERAL_ERROR, "Couldn't delete auth access info", "", __LINE__, __FILE__, $sql);
} }
header("Location: " . append_sid("admin_userauth.$phpEx?" . POST_USERS_URL . "=$user_id")); header("Location: " . append_sid("admin_userauth.$phpEx?" . POST_USERS_URL . "=$user_id", true));
} }
else else
{ {