makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-16 15:08:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/17524] Add possibility to use index key length in migrations

Browse source 
PHPBB-17524
This commit is contained in:
rxu 2025-06-10 10:16:02 +07:00
parent 4367bc8d11
commit aef616381e
No known key found for this signature in database
GPG key ID: 955F0567380E586A
1 changed files with 36 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
phpBB/phpbb/db/tools/doctrine.php
View file

@ -686,24 +686,16 @@ class doctrine implements tools_interface
$columns = (is_array($key_data[1])) ? $key_data[1] : [$key_data[1]];
$key_name = !str_starts_with($key_name, $short_table_name) ? self::add_prefix($key_name, $short_table_name) : $key_name;
// Supports key columns defined with there length
$columns = array_map(function (string $column)
{
if (strpos($column, ':') !== false)
{
$parts = explode(':', $column, 2);
return $parts[0];
}
return $column;
}, $columns);
$options = [];
$this->schema_get_index_key_data($columns, $options);
if ($key_data[0] === 'UNIQUE')
{
$table->addUniqueIndex($columns, $key_name);
$table->addUniqueIndex($columns, $key_name, $options);
}
else
{
$table->addIndex($columns, $key_name);
$table->addIndex($columns, $key_name, [], $options);
}
}
}
@ -900,7 +892,10 @@ class doctrine implements tools_interface
return;
}
$table->addIndex($columns, $index_name);
$options = [];
$this->schema_get_index_key_data($columns, $options);
$table->addIndex($columns, $index_name, [], $options);
}
/**
@ -956,7 +951,10 @@ class doctrine implements tools_interface
return;
}
$table->addUniqueIndex($columns, $index_name);
$options = [];
$this->schema_get_index_key_data($columns, $options);
$table->addUniqueIndex($columns, $index_name, $options);
}
/**
@ -1005,6 +1003,30 @@ class doctrine implements tools_interface
$table->setPrimaryKey($columns);
}
/**
* Checks if index data contains key length
* and put it into $options['lengths'] array.
* Handles key length in formats of 'keyname:123' or 'keyname(123)'
*
* @param array $columns
* @param array $options
*/
protected function schema_get_index_key_data(array &$columns, array &$options): void
{
if (!empty($columns))
{
$columns = array_map(function (string $column) use (&$options)
{
if (preg_match('/^([a-zA-Z0-9_]+)(?:(?:\:|\()([0-9]{1,3})\)?)?$/', $column, $parts))
{
$options['lengths'][] = $parts[2] ?? null;
return $parts[1];
}
return $column;
}, $columns);
}
}
/**
* Recreate an index of a table
*