From 92730af7a434dc0476c96da51ff308dcc4fb241a Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sat, 31 Aug 2024 08:59:57 +0200 Subject: [PATCH] [ticket/17384] Stop overriding error handler in test case PHPBB-17384 --- tests/test_framework/phpbb_test_case.php | 29 ------------------------ 1 file changed, 29 deletions(-) diff --git a/tests/test_framework/phpbb_test_case.php b/tests/test_framework/phpbb_test_case.php index cd71fcaf28..726f6671ae 100644 --- a/tests/test_framework/phpbb_test_case.php +++ b/tests/test_framework/phpbb_test_case.php @@ -35,8 +35,6 @@ class phpbb_test_case extends TestCase 'phpbb_database_test_case' => ['already_connected', 'last_post_timestamp'], ]; $this->excludeBackupStaticAttributes($backupStaticAttributesBlacklist); - - set_error_handler([$this, 'trigger_error_callback']); } public function get_test_case_helpers() @@ -137,31 +135,4 @@ class phpbb_test_case extends TestCase parent::assertFileNotExists($filename, $message); } } - - /** - * Passing E_USER_ERROR to trigger_error() is deprecated as of PHP 8.4, so it causes E_DEPRECATED - * Use trigger_error() callback function to workaround this by handling E_USER_ERROR and suppressing E_DEPRECATED - * "Passing E_USER_ERROR to trigger_error() is deprecated since 8.4, throw an exception or call exit with a string message instead" - * - */ - public function trigger_error_callback($errno, $errstr, $errfile, $errline) - { - // $errstr may need to be escaped - $errstr = htmlspecialchars($errstr); - - switch ($errno) { - case E_USER_ERROR: - echo $errstr; - exit(); - break; - - case E_DEPRECATED: - return true; - break; - - default: - return false; - break; - } - } }