makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-26 13:18:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11568] Invert logic for asserting the response

Browse source 
PHPBB3-11568
This commit is contained in:
Joas Schilling 2013-05-31 16:19:19 +02:00
parent b7b81f6431
commit b2be82cd57
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tests/test_framework/phpbb_functional_test_case.php
View file

@ -83,11 +83,11 @@ class phpbb_functional_test_case extends phpbb_test_case
* @param bool $skip_assert_response_success Should we skip the basic response assertions? * @param bool $skip_assert_response_success Should we skip the basic response assertions?
* @return Symfony\Component\DomCrawler\Crawler * @return Symfony\Component\DomCrawler\Crawler
*/ */
static public function request($method, $path, $form_data = array(), $skip_assert_response_success = false) static public function request($method, $path, $form_data = array(), $assert_response_success = true)
{ {
$crawler = self::$client->request($method, self::$root_url . $path, $form_data); $crawler = self::$client->request($method, self::$root_url . $path, $form_data);
if (!$skip_assert_response_success) if ($assert_response_success)
{ {
self::assert_response_success(); self::assert_response_success();
} }
@ -103,11 +103,11 @@ class phpbb_functional_test_case extends phpbb_test_case
* @param bool $skip_assert_response_success Should we skip the basic response assertions? * @param bool $skip_assert_response_success Should we skip the basic response assertions?
* @return Symfony\Component\DomCrawler\Crawler * @return Symfony\Component\DomCrawler\Crawler
*/ */
static public function submit(Symfony\Component\DomCrawler\Form $form, array $values = array(), $skip_assert_response_success = false) static public function submit(Symfony\Component\DomCrawler\Form $form, array $values = array(), $assert_response_success = true)
{ {
$crawler = self::$client->submit($form, $values); $crawler = self::$client->submit($form, $values);
if (!$skip_assert_response_success) if ($assert_response_success)
{ {
self::assert_response_success(); self::assert_response_success();
} }