From 01a531ebe7564ebb64c73b94fde8a80d5e59d0a2 Mon Sep 17 00:00:00 2001
From: 3D-I <eataly3d@gmail.com>
Date: Mon, 30 Aug 2021 00:17:16 +0200
Subject: [PATCH 1/2] [ticket/16860] Fix breadcrumbs title tags

PHPBB3-16860
---
 phpBB/styles/prosilver/template/navbar_header.html | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/phpBB/styles/prosilver/template/navbar_header.html b/phpBB/styles/prosilver/template/navbar_header.html
index eaf61f2518..fd075bbb9c 100644
--- a/phpBB/styles/prosilver/template/navbar_header.html
+++ b/phpBB/styles/prosilver/template/navbar_header.html
@@ -196,18 +196,24 @@
 
 				{% if U_SITE_HOME %}
 					<span class="crumb" {{ MICRODATA }}>
+						{% apply spaceless %}
 						<a itemprop="item" href="{{ U_SITE_HOME }}" data-navbar-reference="home">
-							{{ Icon('iconify', 'fa:home', '', true) }}<span itemprop="name">{{ L_SITE_HOME }}</span>
+							{{ Icon('iconify', 'fa:home', '', true) }}
+							<span itemprop="name">{{ L_SITE_HOME }}</span>
 						</a>
+						{% endapply %}
 						<meta itemprop="position" content="{{ navlink_position }}{% set navlink_position = navlink_position + 1 %}">
 					</span>
 				{% endif %}
 
 				{% EVENT overall_header_breadcrumb_prepend %}
 				<span class="crumb" {{ MICRODATA }}>
+					{% apply spaceless %}
 					<a itemprop="item" href="{{ U_INDEX }}" accesskey="h" data-navbar-reference="index">
-						{% if not U_SITE_HOME %}{{ Icon('iconify', 'fa:home', '', true) }}{% endif %}<span itemprop="name">{{ L_INDEX }}</span>
+						{% if not U_SITE_HOME %}{{ Icon('iconify', 'fa:home', '', true) }}{% endif %}
+						<span itemprop="name">{{ L_INDEX }}</span>
 					</a>
+					{% endapply %}
 					<meta itemprop="position" content="{{ navlink_position }}{% set navlink_position = navlink_position + 1 %}">
 				</span>
 
@@ -217,9 +223,11 @@
 
 					{% EVENT overall_header_navlink_prepend %}
 					<span class="crumb" {{ MICRODATA }}{% if navlink.MICRODATA %} {{ navlink.MICRODATA }}{% endif %}>
+						{% apply spaceless %}
 						<a itemprop="item" href="{{ NAVLINK_LINK }}">
 							<span itemprop="name">{{ NAVLINK_NAME }}</span>
 						</a>
+						{% endapply %}
 						<meta itemprop="position" content="{{ navlink_position }}{% set navlink_position = navlink_position + 1 %}">
 					</span>
 					{% EVENT overall_header_navlink_append %}

From c34f09c02bf07f505709625f7f43474e7747b2d1 Mon Sep 17 00:00:00 2001
From: 3D-I <eataly3d@gmail.com>
Date: Mon, 30 Aug 2021 00:41:00 +0200
Subject: [PATCH 2/2] [ticket/16860] Fix breadcrumbs title tags

A bit of order for the sake of readability

PHPBB3-16860
---
 .../prosilver/template/navbar_header.html     | 20 ++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/phpBB/styles/prosilver/template/navbar_header.html b/phpBB/styles/prosilver/template/navbar_header.html
index fd075bbb9c..cfc8ffec86 100644
--- a/phpBB/styles/prosilver/template/navbar_header.html
+++ b/phpBB/styles/prosilver/template/navbar_header.html
@@ -2,7 +2,6 @@
 	<div class="inner">
 
 		<ul id="nav-main" class="nav-main linklist" role="menubar">
-
 			<li id="quick-links" class="quick-links dropdown-container responsive-menu{% if not S_DISPLAY_QUICK_LINKS and not S_DISPLAY_SEARCH %} hidden{% endif %}">
 				<a href="#" class="dropdown-trigger">
 					{{ Icon('iconify', 'fa:bars', lang('QUICK_LINKS'), false) }}
@@ -105,9 +104,13 @@
 			{% endif %}
 
 			{% if S_REGISTERED_USER %}
+
 				{% EVENT navbar_header_user_profile_prepend %}
+
 				<li id="username_logged_in" class="rightside {% if CURRENT_USER_AVATAR_HTML %} no-bulletin{% endif %}">
+
 					{% EVENT navbar_header_username_prepend %}
+
 					<div class="header-profile dropdown-container">
 						<a href="{{ U_PROFILE }}" class="header-avatar dropdown-trigger">
 							{% if CURRENT_USER_AVATAR_HTML %}{{ CURRENT_USER_AVATAR_HTML }} {% endif %}
@@ -151,8 +154,10 @@
 							</ul>
 						</div>
 					</div>
+
 					{% EVENT navbar_header_username_append %}
-					</li>
+
+				</li>
 				{% if S_DISPLAY_PM %}
 					<li class="rightside">
 						<a href="{{ U_PRIVATEMSGS }}" role="menuitem">
@@ -160,15 +165,20 @@
 						</a>
 					</li>
 				{% endif %}
+
 				{% if S_NOTIFICATIONS_DISPLAY %}
 					<li class="dropdown-container dropdown-{S_CONTENT_FLOW_END} rightside">
 						<a href="{{ U_VIEW_ALL_NOTIFICATIONS }}" id="notification-button" class="dropdown-trigger">
 							{{ Icon('iconify', 'fa:bell', lang('NOTIFICATIONS'), false) }}<strong class="badge{% if not NOTIFICATIONS_COUNT %} hidden{% endif %}">{NOTIFICATIONS_COUNT}</strong>
 						</a>
+
 						{% include 'notification_dropdown.html' %}
+
 					</li>
 				{% endif %}
+
 			{% EVENT navbar_header_user_profile_append %}
+
 			{% elseif not S_IS_BOT %}
 				<li class="rightside" >
 					<a href="{{ U_LOGIN_LOGOUT }}" title="{{ lang('LOGIN_LOGOUT') }}" accesskey="x" role="menuitem">
@@ -182,7 +192,9 @@
 						</a>
 					</li>
 				{% endif %}
+
 				{% EVENT navbar_header_logged_out_content %}
+
 			{% endif %}
 		</ul>
 
@@ -193,7 +205,6 @@
 			{% EVENT overall_header_breadcrumbs_before %}
 
 			<li class="breadcrumbs" itemscope itemtype="https://schema.org/BreadcrumbList">
-
 				{% if U_SITE_HOME %}
 					<span class="crumb" {{ MICRODATA }}>
 						{% apply spaceless %}
@@ -207,6 +218,7 @@
 				{% endif %}
 
 				{% EVENT overall_header_breadcrumb_prepend %}
+
 				<span class="crumb" {{ MICRODATA }}>
 					{% apply spaceless %}
 					<a itemprop="item" href="{{ U_INDEX }}" accesskey="h" data-navbar-reference="index">
@@ -232,7 +244,9 @@
 					</span>
 					{% EVENT overall_header_navlink_append %}
 				{% endfor %}
+
 				{% EVENT overall_header_breadcrumb_append %}
+
 			</li>
 
 			{% EVENT overall_header_breadcrumbs_after %}