makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-27 21:58:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11459] Correctly handle index column length

Browse source 
Code is copied from db\tools::sql_create_index()

PHPBB3-11459
This commit is contained in:
Joas Schilling 2014-03-28 20:22:10 +01:00
parent 18e70d4380
commit b3560264e8
1 changed files with 21 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
phpBB/develop/create_schema_files.php
View file

@ -25,6 +25,7 @@ $phpEx = substr(strrchr(__FILE__, '.'), 1);
include($phpbb_root_path . 'common.' . $phpEx); include($phpbb_root_path . 'common.' . $phpEx);
$phpbb_extension_manager = $phpbb_container->get('ext.manager'); $phpbb_extension_manager = $phpbb_container->get('ext.manager');
$finder = $phpbb_extension_manager->get_finder();
$finder = $finder $finder = $finder
->core_path('phpbb/db/migration/data/') ->core_path('phpbb/db/migration/data/')
->extension_prefix('migration/'); ->extension_prefix('migration/');
@ -468,15 +469,27 @@ foreach ($supported_dbms as $dbms)
trigger_error("Index name '${table_name}_$key_name' on table '$table_name' is too long. The maximum is 30 characters.", E_USER_ERROR); trigger_error("Index name '${table_name}_$key_name' on table '$table_name' is too long. The maximum is 30 characters.", E_USER_ERROR);
} }
foreach ($key_data[1] as $key => $col_name)
{
// remove index length unless MySQL4
if ($dbms !== 'mysql_40')
{
$key_data[1][$key] = preg_replace('#:.*$#', '', $col_name);
}
}
switch ($dbms) switch ($dbms)
{ {
case 'mysql_40': case 'mysql_40':
case 'mysql_41': // add index size to definition as required by MySQL4
$line .= ($key_data[0] == 'INDEX') ? "\tKEY" : '';
$line .= ($key_data[0] == 'UNIQUE') ? "\tUNIQUE" : '';
foreach ($key_data[1] as $key => $col_name) foreach ($key_data[1] as $key => $col_name)
{ {
if (isset($modded_array[$col_name])) if (false !== strpos($col_name, ':'))
{
list($col_name, $index_size) = explode(':', $col_name);
$key_data[1][$key] = "$col_name($index_size)";
}
else if (isset($modded_array[$col_name]))
{ {
switch ($modded_array[$col_name]) switch ($modded_array[$col_name])
{ {
@ -487,6 +500,10 @@ foreach ($supported_dbms as $dbms)
} }
} }
} }
// no break
case 'mysql_41':
$line .= ($key_data[0] == 'INDEX') ? "\tKEY" : '';
$line .= ($key_data[0] == 'UNIQUE') ? "\tUNIQUE" : '';
$line .= ' ' . $key_name . ' (' . implode(', ', $key_data[1]) . "),\n"; $line .= ' ' . $key_name . ' (' . implode(', ', $key_data[1]) . "),\n";
break; break;