makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-10 13:28:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10949] Converted missing code to new JS coding guidelines

Browse source 
A few missing semi-colons were also added where needed.

PHPBB3-10949
This commit is contained in:
Marc Alexander 2013-01-04 22:46:12 +01:00
parent 46c33e08b5
commit b5cc1ed683
6 changed files with 89 additions and 97 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

80
phpBB/adm/style/ajax.js
View file

@ -2,11 +2,11 @@
"use strict"; "use strict";
var img_templates = { var imgTemplates = {
up: $('.template-up-img'), up: $('.template-up-img'),
up_disabled: $('.template-up-img-disabled'), upDisabled: $('.template-up-img-disabled'),
down: $('.template-down-img'), down: $('.template-down-img'),
down_disabled: $('.template-down-img-disabled') downDisabled: $('.template-down-img-disabled')
}; };
/** /**
@ -15,20 +15,19 @@ var img_templates = {
* an item is moved up. It moves the row up or down, and deactivates / * an item is moved up. It moves the row up or down, and deactivates /
* activates any up / down icons that require it (the ones at the top or bottom). * activates any up / down icons that require it (the ones at the top or bottom).
*/ */
phpbb.add_ajax_callback('row_down', function() { phpbb.addAjaxCallback('row_down', function() {
var el = $(this), var el = $(this),
tr = el.parents('tr'), tr = el.parents('tr'),
tr_swap = tr.next(); trSwap = tr.next();
/* /*
* If the element was the first one, we have to: * If the element was the first one, we have to:
* - Add the up-link to the row we moved * - Add the up-link to the row we moved
* - Remove the up-link on the next row * - Remove the up-link on the next row
*/ */
if (tr.is(':first-child')) if (tr.is(':first-child')) {
{ var upImg = imgTemplates.up.clone().attr('href', tr.attr('data-up'));
var up_img = img_templates.up.clone().attr('href', tr.attr('data-up')); tr.find('.up').html(upImg);
tr.find('.up').html(up_img);
phpbb.ajaxify({ phpbb.ajaxify({
selector: tr.find('.up').children('a'), selector: tr.find('.up').children('a'),
@ -36,45 +35,43 @@ phpbb.add_ajax_callback('row_down', function() {
overlay: false overlay: false
}); });
tr_swap.find('.up').html(img_templates.up_disabled.clone()); trSwap.find('.up').html(imgTemplates.upDisabled.clone());
} }
tr.insertAfter(tr_swap); tr.insertAfter(trSwap);
/* /*
* As well as: * As well as:
* - Remove the down-link on the moved row, if it is now the last row * - Remove the down-link on the moved row, if it is now the last row
* - Add the down-link to the next row, if it was the last row * - Add the down-link to the next row, if it was the last row
*/ */
if (tr.is(':last-child')) if (tr.is(':last-child')) {
{ tr.find('.down').html(imgTemplates.downDisabled.clone());
tr.find('.down').html(img_templates.down_disabled.clone());
var down_img = img_templates.down.clone().attr('href', tr_swap.attr('data-down')); var downImg = imgTemplates.down.clone().attr('href', trSwap.attr('data-down'));
tr_swap.find('.down').html(down_img); trSwap.find('.down').html(downImg);
phpbb.ajaxify({ phpbb.ajaxify({
selector: tr_swap.find('.down').children('a'), selector: trSwap.find('.down').children('a'),
callback: 'row_down', callback: 'row_down',
overlay: false overlay: false
}); });
} }
}); });
phpbb.add_ajax_callback('row_up', function() { phpbb.addAjaxCallback('row_up', function() {
var el = $(this), var el = $(this),
tr = el.parents('tr'), tr = el.parents('tr'),
tr_swap = tr.prev(); trSwap = tr.prev();
/* /*
* If the element was the last one, we have to: * If the element was the last one, we have to:
* - Add the down-link to the row we moved * - Add the down-link to the row we moved
* - Remove the down-link on the next row * - Remove the down-link on the next row
*/ */
if (tr.is(':last-child')) if (tr.is(':last-child')) {
{ var downImg = imgTemplates.down.clone().attr('href', tr.attr('data-down'));
var down_img = img_templates.down.clone().attr('href', tr.attr('data-down')); tr.find('.down').html(downImg);
tr.find('.down').html(down_img);
phpbb.ajaxify({ phpbb.ajaxify({
selector: tr.find('.down').children('a'), selector: tr.find('.down').children('a'),
@ -82,25 +79,24 @@ phpbb.add_ajax_callback('row_up', function() {
overlay: false overlay: false
}); });
tr_swap.find('.down').html(img_templates.down_disabled.clone()); trSwap.find('.down').html(imgTemplates.downDisabled.clone());
} }
tr.insertBefore(tr_swap); tr.insertBefore(trSwap);
/* /*
* As well as: * As well as:
* - Remove the up-link on the moved row, if it is now the first row * - Remove the up-link on the moved row, if it is now the first row
* - Add the up-link to the previous row, if it was the first row * - Add the up-link to the previous row, if it was the first row
*/ */
if (tr.is(':first-child')) if (tr.is(':first-child')) {
{ tr.find('.up').html(imgTemplates.upDisabled.clone());
tr.find('.up').html(img_templates.up_disabled.clone());
var up_img = img_templates.up.clone().attr('href', tr_swap.attr('data-up')); var upImg = imgTemplates.up.clone().attr('href', trSwap.attr('data-up'));
tr_swap.find('.up').html(up_img); trSwap.find('.up').html(upImg);
phpbb.ajaxify({ phpbb.ajaxify({
selector: tr_swap.find('.up').children('a'), selector: trSwap.find('.up').children('a'),
callback: 'row_up', callback: 'row_up',
overlay: false overlay: false
}); });
@ -112,29 +108,26 @@ phpbb.add_ajax_callback('row_up', function() {
* It does this by replacing the text, and replacing all instances of "activate" * It does this by replacing the text, and replacing all instances of "activate"
* in the href with "deactivate", and vice versa. * in the href with "deactivate", and vice versa.
*/ */
phpbb.add_ajax_callback('activate_deactivate', function(res) { phpbb.addAjaxCallback('activate_deactivate', function(res) {
var el = $(this), var el = $(this),
new_href = el.attr('href'); newHref = el.attr('href');
el.text(res.text); el.text(res.text);
if (new_href.indexOf('deactivate') !== -1) if (newHref.indexOf('deactivate') !== -1) {
{ newHref = newHref.replace('deactivate', 'activate')
new_href = new_href.replace('deactivate', 'activate') } else {
} newHref = newHref.replace('activate', 'deactivate')
else
{
new_href = new_href.replace('activate', 'deactivate')
} }
el.attr('href', new_href); el.attr('href', newHref);
}); });
/** /**
* The removes the parent row of the link or form that triggered the callback, * The removes the parent row of the link or form that triggered the callback,
* and is good for stuff like the removal of forums. * and is good for stuff like the removal of forums.
*/ */
phpbb.add_ajax_callback('row_delete', function() { phpbb.addAjaxCallback('row_delete', function() {
$(this).parents('tr').remove(); $(this).parents('tr').remove();
}); });
@ -145,8 +138,7 @@ $('[data-ajax]').each(function() {
ajax = $this.attr('data-ajax'), ajax = $this.attr('data-ajax'),
fn; fn;
if (ajax !== 'false') if (ajax !== 'false') {
{
fn = (ajax !== 'true') ? ajax : null; fn = (ajax !== 'true') ? ajax : null;
phpbb.ajaxify({ phpbb.ajaxify({
selector: this, selector: this,

4
phpBB/adm/style/timezone.js
View file

@ -1,11 +1,11 @@
(function($) { // Avoid conflicts with other libraries (function($) { // Avoid conflicts with other libraries
$('#tz_date').change(function() { $('#tz_date').change(function() {
phpbb.timezone_switch_date(false); phpbb.timezoneSwitchDate(false);
}); });
$(document).ready( $(document).ready(
phpbb.timezone_enable_date_selection phpbb.timezoneEnableDateSelection
); );
})(jQuery); // Avoid conflicts with other libraries })(jQuery); // Avoid conflicts with other libraries

74
phpBB/assets/javascript/core.js
View file

@ -43,11 +43,11 @@ phpbb.loadingAlert = function() {
* Clear loading alert timeout * Clear loading alert timeout
*/ */
phpbb.clearLoadingTimeout = function() { phpbb.clearLoadingTimeout = function() {
if (phpbbAlertTimer != null) { if (phpbbAlertTimer !== null) {
clearTimeout(phpbbAlertTimer); clearTimeout(phpbbAlertTimer);
phpbbAlertTimer = null; phpbbAlertTimer = null;
} }
} };
/** /**
* Display a simple alert similar to JSs native alert(). * Display a simple alert similar to JSs native alert().
@ -135,13 +135,13 @@ phpbb.confirm = function(msg, callback, fadedark) {
e.stopPropagation(); e.stopPropagation();
}); });
var click_handler = function(e) { var clickHandler = function(e) {
var res = this.className === 'button1'; var res = this.className === 'button1';
var fade = (typeof fadedark !== 'undefined' && !fadedark && res) ? div : dark; var fade = (typeof fadedark !== 'undefined' && !fadedark && res) ? div : dark;
fade.fadeOut(phpbb.alertTime, function() { fade.fadeOut(phpbb.alertTime, function() {
div.hide(); div.hide();
}); });
div.find('input[type="button"]').unbind('click', click_handler); div.find('input[type="button"]').unbind('click', clickHandler);
callback(res); callback(res);
if (e) { if (e) {
@ -149,7 +149,7 @@ phpbb.confirm = function(msg, callback, fadedark) {
e.stopPropagation(); e.stopPropagation();
} }
}; };
div.find('input[type="button"]').one('click', click_handler); div.find('input[type="button"]').one('click', clickHandler);
dark.one('click', function(e) { dark.one('click', function(e) {
div.find('.alert_close').unbind('click'); div.find('.alert_close').unbind('click');
@ -207,7 +207,7 @@ phpbb.confirm = function(msg, callback, fadedark) {
* @argument string string The querystring to parse. * @argument string string The querystring to parse.
* @returns object The object created. * @returns object The object created.
*/ */
phpbb.parse_querystring = function(string) { phpbb.parseQuerystring = function(string) {
var params = {}, i, split; var params = {}, i, split;
string = string.split('&'); string = string.split('&');
@ -386,9 +386,9 @@ phpbb.ajaxify = function(options) {
/** /**
* Hide the optgroups that are not the selected timezone * Hide the optgroups that are not the selected timezone
* *
* @param bool keep_selection Shall we keep the value selected, or shall the user be forced to repick one. * @param bool keepSelection Shall we keep the value selected, or shall the user be forced to repick one.
*/ */
phpbb.timezone_switch_date = function(keep_selection) { phpbb.timezoneSwitchDate = function(keepSelection) {
if ($('#timezone_copy').length == 0) { if ($('#timezone_copy').length == 0) {
// We make a backup of the original dropdown, so we can remove optgroups // We make a backup of the original dropdown, so we can remove optgroups
// instead of setting display to none, because IE and chrome will not // instead of setting display to none, because IE and chrome will not
@ -412,30 +412,30 @@ phpbb.timezone_switch_date = function(keep_selection) {
if ($("#timezone > optgroup[label='" + $('#tz_date').val() + "'] > option").size() == 1) { if ($("#timezone > optgroup[label='" + $('#tz_date').val() + "'] > option").size() == 1) {
// If there is only one timezone for the selected date, we just select that automatically. // If there is only one timezone for the selected date, we just select that automatically.
$("#timezone > optgroup[label='" + $('#tz_date').val() + "'] > option:first").attr('selected', true); $("#timezone > optgroup[label='" + $('#tz_date').val() + "'] > option:first").attr('selected', true);
keep_selection = true; keepSelection = true;
} }
if (typeof keep_selection !== 'undefined' && !keep_selection) { if (typeof keepSelection !== 'undefined' && !keepSelection) {
var timezoneOptions = $('#timezone > optgroup option'); var timezoneOptions = $('#timezone > optgroup option');
if (timezoneOptions.filter(':selected').length <= 0) { if (timezoneOptions.filter(':selected').length <= 0) {
timezoneOptions.filter(':first').attr('selected', true); timezoneOptions.filter(':first').attr('selected', true);
} }
} }
} };
/** /**
* Display the date/time select * Display the date/time select
*/ */
phpbb.timezone_enable_date_selection = function() { phpbb.timezoneEnableDateSelection = function() {
$('#tz_select_date').css('display', 'block'); $('#tz_select_date').css('display', 'block');
} };
/** /**
* Preselect a date/time or suggest one, if it is not picked. * Preselect a date/time or suggest one, if it is not picked.
* *
* @param bool force_selector Shall we select the suggestion? * @param bool forceSelector Shall we select the suggestion?
*/ */
phpbb.timezone_preselect_select = function(force_selector) { phpbb.timezonePreselectSelect = function(forceSelector) {
// The offset returned here is in minutes and negated. // The offset returned here is in minutes and negated.
// http://www.w3schools.com/jsref/jsref_getTimezoneOffset.asp // http://www.w3schools.com/jsref/jsref_getTimezoneOffset.asp
@ -464,21 +464,21 @@ phpbb.timezone_preselect_select = function(force_selector) {
} }
var prefix = 'GMT' + sign + hours + ':' + minutes; var prefix = 'GMT' + sign + hours + ':' + minutes;
var prefix_length = prefix.length; var prefixLength = prefix.length;
var selector_options = $('#tz_date > option'); var selectorOptions = $('#tz_date > option');
for (var i = 0; i < selector_options.length; ++i) { for (var i = 0; i < selectorOptions.length; ++i) {
var option = selector_options[i]; var option = selectorOptions[i];
if (option.value.substring(0, prefix_length) == prefix) { if (option.value.substring(0, prefixLength) == prefix) {
if ($('#tz_date').val() != option.value && !force_selector) { if ($('#tz_date').val() != option.value && !forceSelector) {
// We do not select the option for the user, but notify him, // We do not select the option for the user, but notify him,
// that we would suggest a different setting. // that we would suggest a different setting.
phpbb.timezone_switch_date(true); phpbb.timezoneSwitchDate(true);
$('#tz_select_date_suggest').css('display', 'inline'); $('#tz_select_date_suggest').css('display', 'inline');
} else { } else {
option.selected = true; option.selected = true;
phpbb.timezone_switch_date(!force_selector); phpbb.timezoneSwitchDate(!forceSelector);
$('#tz_select_date_suggest').css('display', 'none'); $('#tz_select_date_suggest').css('display', 'none');
} }
@ -490,7 +490,7 @@ phpbb.timezone_preselect_select = function(force_selector) {
return; return;
} }
} }
} };
phpbb.ajaxCallbacks = {}; phpbb.ajaxCallbacks = {};
@ -502,7 +502,7 @@ phpbb.ajaxCallbacks = {};
* @param string id The name of the callback. * @param string id The name of the callback.
* @param function callback The callback to be called. * @param function callback The callback to be called.
*/ */
phpbb.add_ajax_callback = function(id, callback) { phpbb.addAjaxCallback = function(id, callback) {
if (typeof callback === 'function') { if (typeof callback === 'function') {
phpbb.ajaxCallbacks[id] = callback; phpbb.ajaxCallbacks[id] = callback;
} }
@ -515,7 +515,7 @@ phpbb.add_ajax_callback = function(id, callback) {
* the alt-text data attribute, and replaces the text in the attribute with the * the alt-text data attribute, and replaces the text in the attribute with the
* current text so that the process can be repeated. * current text so that the process can be repeated.
*/ */
phpbb.add_ajax_callback('alt_text', function() { phpbb.addAjaxCallback('alt_text', function() {
var el = $(this), var el = $(this),
altText; altText;
@ -534,28 +534,28 @@ phpbb.add_ajax_callback('alt_text', function() {
* Additionally it replaces the class of the link's parent * Additionally it replaces the class of the link's parent
* and changes the link itself. * and changes the link itself.
*/ */
phpbb.add_ajax_callback('toggle_link', function() { phpbb.addAjaxCallback('toggle_link', function() {
var el = $(this), var el = $(this),
toggle_text, toggleText,
toggle_url, toggleUrl,
toggle_class; toggleClass;
// Toggle link text // Toggle link text
toggle_text = el.attr('data-toggle-text'); toggleText = el.attr('data-toggle-text');
el.attr('data-toggle-text', el.text()); el.attr('data-toggle-text', el.text());
el.attr('title', toggle_text); el.attr('title', toggleText);
el.text(toggle_text); el.text(toggleText);
// Toggle link url // Toggle link url
toggle_url = el.attr('data-toggle-url'); toggleUrl = el.attr('data-toggle-url');
el.attr('data-toggle-url', el.attr('href')); el.attr('data-toggle-url', el.attr('href'));
el.attr('href', toggle_url); el.attr('href', toggleUrl);
// Toggle class of link parent // Toggle class of link parent
toggle_class = el.attr('data-toggle-class'); toggleClass = el.attr('data-toggle-class');
el.attr('data-toggle-class', el.parent().attr('class')); el.attr('data-toggle-class', el.parent().attr('class'));
el.parent().attr('class', toggle_class); el.parent().attr('class', toggleClass);
}); });
})(jQuery); // Avoid conflicts with other libraries })(jQuery); // Avoid conflicts with other libraries

12
phpBB/styles/prosilver/template/ajax.js
View file

@ -14,7 +14,7 @@ phpbb.closeDarkenWrapper = function(delay) {
}; };
// This callback will mark all forum icons read // This callback will mark all forum icons read
phpbb.add_ajax_callback('mark_forums_read', function(res) { phpbb.addAjaxCallback('mark_forums_read', function(res) {
var readTitle = res.NO_UNREAD_POSTS; var readTitle = res.NO_UNREAD_POSTS;
var unreadTitle = res.UNREAD_POSTS; var unreadTitle = res.UNREAD_POSTS;
var iconsArray = { var iconsArray = {
@ -44,7 +44,7 @@ phpbb.add_ajax_callback('mark_forums_read', function(res) {
}); });
// This callback will mark all topic icons read // This callback will mark all topic icons read
phpbb.add_ajax_callback('mark_topics_read', function(res) { phpbb.addAjaxCallback('mark_topics_read', function(res) {
var readTitle = res.NO_UNREAD_POSTS; var readTitle = res.NO_UNREAD_POSTS;
var unreadTitle = res.UNREAD_POSTS; var unreadTitle = res.UNREAD_POSTS;
var iconsArray = { var iconsArray = {
@ -91,7 +91,7 @@ phpbb.add_ajax_callback('mark_topics_read', function(res) {
}); });
// This callback finds the post from the delete link, and removes it. // This callback finds the post from the delete link, and removes it.
phpbb.add_ajax_callback('post_delete', function() { phpbb.addAjaxCallback('post_delete', function() {
var el = $(this), var el = $(this),
postId; postId;
@ -110,7 +110,7 @@ phpbb.add_ajax_callback('post_delete', function() {
}); });
// This callback removes the approve / disapprove div or link. // This callback removes the approve / disapprove div or link.
phpbb.add_ajax_callback('post_approve', function(res) { phpbb.addAjaxCallback('post_approve', function(res) {
var remove = (res.approved) ? $(this) : $(this).parents('.post'); var remove = (res.approved) ? $(this) : $(this).parents('.post');
$(remove).css('pointer-events', 'none').fadeOut(function() { $(remove).css('pointer-events', 'none').fadeOut(function() {
$(this).remove(); $(this).remove();
@ -118,12 +118,12 @@ phpbb.add_ajax_callback('post_approve', function(res) {
}); });
// This removes the parent row of the link or form that fired the callback. // This removes the parent row of the link or form that fired the callback.
phpbb.add_ajax_callback('row_delete', function() { phpbb.addAjaxCallback('row_delete', function() {
$(this).parents('tr').remove(); $(this).parents('tr').remove();
}); });
// This handles friend / foe additions removals. // This handles friend / foe additions removals.
phpbb.add_ajax_callback('zebra', function(res) { phpbb.addAjaxCallback('zebra', function(res) {
var zebra; var zebra;
if (res.success) { if (res.success) {

8
phpBB/styles/prosilver/template/timezone.js
View file

@ -1,19 +1,19 @@
(function($) { // Avoid conflicts with other libraries (function($) { // Avoid conflicts with other libraries
$('#tz_date').change(function() { $('#tz_date').change(function() {
phpbb.timezone_switch_date(false); phpbb.timezoneSwitchDate(false);
}); });
$('#tz_select_date_suggest').click(function(){ $('#tz_select_date_suggest').click(function(){
phpbb.timezone_preselect_select(true); phpbb.timezonePreselectSelect(true);
}); });
$(document).ready( $(document).ready(
phpbb.timezone_enable_date_selection phpbb.timezoneEnableDateSelection
); );
$(document).ready( $(document).ready(
phpbb.timezone_preselect_select($('#tz_select_date_suggest').attr('data-is-registration') == 'true') phpbb.timezonePreselectSelect($('#tz_select_date_suggest').attr('data-is-registration') == 'true')
); );
})(jQuery); // Avoid conflicts with other libraries })(jQuery); // Avoid conflicts with other libraries

8
phpBB/styles/subsilver2/template/timezone.js
View file

@ -1,19 +1,19 @@
(function($) { // Avoid conflicts with other libraries (function($) { // Avoid conflicts with other libraries
$('#tz_date').change(function() { $('#tz_date').change(function() {
phpbb.timezone_switch_date(false); phpbb.timezoneSwitchDate(false);
}); });
$('#tz_select_date_suggest').click(function(){ $('#tz_select_date_suggest').click(function(){
phpbb.timezone_preselect_select(true); phpbb.timezonePreselectSelect(true);
}); });
$(document).ready( $(document).ready(
phpbb.timezone_enable_date_selection phpbb.timezoneEnableDateSelection
); );
$(document).ready( $(document).ready(
phpbb.timezone_preselect_select($('#tz_select_date_suggest').attr('data-is-registration') == 'true') phpbb.timezonePreselectSelect($('#tz_select_date_suggest').attr('data-is-registration') == 'true')
); );
})(jQuery); // Avoid conflicts with other libraries })(jQuery); // Avoid conflicts with other libraries