From b6b0973e9ec1a8b1eddb4b3db77790d0063e2549 Mon Sep 17 00:00:00 2001
From: Matt Friedman <maf675@gmail.com>
Date: Fri, 20 Dec 2024 20:18:31 -0800
Subject: [PATCH] =?UTF-8?q?[ticket/17457]=20Remove=20dir=20from=20manifest?=
 =?UTF-8?q?,=20it=E2=80=99s=20not=20implemented?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PHPBB-17457
---
 phpBB/config/default/container/services.yml | 1 -
 phpBB/phpbb/manifest.php                    | 9 +--------
 tests/functional/manifest_test.php          | 1 -
 3 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/phpBB/config/default/container/services.yml b/phpBB/config/default/container/services.yml
index 253a70342a..8a4336e832 100644
--- a/phpBB/config/default/container/services.yml
+++ b/phpBB/config/default/container/services.yml
@@ -161,7 +161,6 @@ services:
         class: phpbb\manifest
         arguments:
             - '@config'
-            - '@language'
             - '@path_helper'
             - '@event_dispatcher'
             - '@user'
diff --git a/phpBB/phpbb/manifest.php b/phpBB/phpbb/manifest.php
index 811b063fc0..1eb84eb6a7 100644
--- a/phpBB/phpbb/manifest.php
+++ b/phpBB/phpbb/manifest.php
@@ -16,7 +16,6 @@ namespace phpbb;
 use phpbb\config\config;
 use phpbb\event\dispatcher_interface;
 use phpbb\exception\http_exception;
-use phpbb\language\language;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Response;
 
@@ -25,9 +24,6 @@ class manifest
 	/** @var config */
 	protected $config;
 
-	/** @var language */
-	protected $language;
-
 	/** @var path_helper */
 	protected $path_helper;
 
@@ -41,17 +37,15 @@ class manifest
 	 * Constructor for manifest controller
 	 *
 	 * @param config $config
-	 * @param language $language
 	 * @param path_helper $path_helper
 	 * @param dispatcher_interface $phpbb_dispatcher
 	 * @param user $user
 	 */
-	public function __construct(config $config, language $language, path_helper $path_helper, dispatcher_interface $phpbb_dispatcher, user $user)
+	public function __construct(config $config, path_helper $path_helper, dispatcher_interface $phpbb_dispatcher, user $user)
 	{
 		$this->config = $config;
 		$this->path_helper = $path_helper;
 		$this->phpbb_dispatcher = $phpbb_dispatcher;
-		$this->language = $language;
 		$this->user = $user;
 	}
 
@@ -77,7 +71,6 @@ class manifest
 			'short_name'	=> $sitename_short ?: utf8_substr($sitename, 0, 12),
 			'display'		=> 'standalone',
 			'orientation'	=> 'portrait',
-			'dir'			=> $this->language->lang('DIRECTION'),
 			'start_url'		=> $board_path,
 			'scope'			=> $board_path,
 		];
diff --git a/tests/functional/manifest_test.php b/tests/functional/manifest_test.php
index 2099dd7661..0d94be0deb 100644
--- a/tests/functional/manifest_test.php
+++ b/tests/functional/manifest_test.php
@@ -25,7 +25,6 @@ class phpbb_functional_manifest_test extends phpbb_functional_test_case
 			'short_name'	=> 'yourdomain',
 			'display'		=> 'standalone',
 			'orientation'	=> 'portrait',
-			'dir'			=> 'ltr',
 			'start_url'		=> $url_path,
 			'scope'			=> $url_path,
 		];