From b75fb96bab92952011f796cf29611c6bff09dd37 Mon Sep 17 00:00:00 2001 From: Tristan Darricau Date: Wed, 28 May 2014 22:34:10 +0200 Subject: [PATCH] [ticket/11226] Explicity set file_moved to false PHPBB3-11226 --- phpBB/includes/functions_upload.php | 1 + tests/upload/fileupload_test.php | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/phpBB/includes/functions_upload.php b/phpBB/includes/functions_upload.php index 16a05a0a56..21ee9a7119 100644 --- a/phpBB/includes/functions_upload.php +++ b/phpBB/includes/functions_upload.php @@ -309,6 +309,7 @@ class filespec { @unlink($this->filename); $this->error[] = $user->lang($this->upload->error_prefix . 'GENERAL_UPLOAD_ERROR', $this->destination_file); + $this->file_moved = false; return false; } else diff --git a/tests/upload/fileupload_test.php b/tests/upload/fileupload_test.php index b30bfe59b4..c362c3461e 100644 --- a/tests/upload/fileupload_test.php +++ b/tests/upload/fileupload_test.php @@ -110,7 +110,8 @@ class phpbb_fileupload_test extends phpbb_test_case copy($this->path . 'jpg', $this->path . 'jpg.jpg'); $file = $upload->local_upload($this->path . 'jpg.jpg'); $this->assertEquals(0, sizeof($file->error)); - $file->move_file('../tests/upload/fixture'); + $this->assertFalse($file->move_file('../tests/upload/fixture')); + $this->assertFalse($file->file_moved); $this->assertEquals(1, sizeof($file->error)); }