makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/13636] Deleting inactive user in acp_users gives unexpected link

Browse source 
Success message did not provide the expected "previous page" link
(acp_inactive was expected, but the link took users to acp_users) if the
acp_users module was accessed by navigating from the inactive user list to
acp_users and then deleting inactive user.

PHPBB3-13636
This commit is contained in:
MateBartus 2015-02-24 21:06:53 +01:00
parent 56cbff720d
commit b8dfbfe390
2 changed files with 21 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
phpBB/includes/acp/acp_inactive.php
View file

@ -271,7 +271,7 @@ class acp_inactive
'REMINDED_EXPLAIN' => $user->lang('USER_LAST_REMINDED', (int) $row['user_reminded'], $user->format_date($row['user_reminded_time'])), 'REMINDED_EXPLAIN' => $user->lang('USER_LAST_REMINDED', (int) $row['user_reminded'], $user->format_date($row['user_reminded_time'])),
'USERNAME_FULL' => get_username_string('full', $row['user_id'], $row['username'], $row['user_colour'], false, append_sid("{$phpbb_admin_path}index.$phpEx", 'i=users&mode=overview')), 'USERNAME_FULL' => get_username_string('full', $row['user_id'], $row['username'], $row['user_colour'], false, append_sid("{$phpbb_admin_path}index.$phpEx", 'i=users&mode=overview&referer=acp_inactive')),
'USERNAME' => get_username_string('username', $row['user_id'], $row['username'], $row['user_colour']), 'USERNAME' => get_username_string('username', $row['user_id'], $row['username'], $row['user_colour']),
'USER_COLOR' => get_username_string('colour', $row['user_id'], $row['username'], $row['user_colour']), 'USER_COLOR' => get_username_string('colour', $row['user_id'], $row['username'], $row['user_colour']),

25
phpBB/includes/acp/acp_users.php
View file

@ -44,6 +44,10 @@ class acp_users
$user_id = request_var('u', 0); $user_id = request_var('u', 0);
$action = request_var('action', ''); $action = request_var('action', '');
$referer = request_var('referer', '');
$referer_tag = "referer=$referer";
$referer_url = append_sid("{$phpbb_admin_path}index.$phpEx", "i=$referer");
$submit = (isset($_POST['update']) && !isset($_POST['cancel'])) ? true : false; $submit = (isset($_POST['update']) && !isset($_POST['cancel'])) ? true : false;
$form_name = 'acp_users'; $form_name = 'acp_users';
@ -146,9 +150,9 @@ class acp_users
} }
$template->assign_vars(array( $template->assign_vars(array(
'U_BACK' => $this->u_action, 'U_BACK' => ( (empty($referer)) ? $this->u_action : $referer_url ),
'U_MODE_SELECT' => append_sid("{$phpbb_admin_path}index.$phpEx", "i=$id&u=$user_id"), 'U_MODE_SELECT' => append_sid("{$phpbb_admin_path}index.$phpEx", "i=$id&u=$user_id"),
'U_ACTION' => $this->u_action . '&u=' . $user_id, 'U_ACTION' => $this->u_action . '&u=' . $user_id . ( (empty($referer)) ? '' : '&' . $referer_tag ),
'S_FORM_OPTIONS' => $s_form_options, 'S_FORM_OPTIONS' => $s_form_options,
'MANAGED_USERNAME' => $user_row['username']) 'MANAGED_USERNAME' => $user_row['username'])
); );
@ -221,19 +225,30 @@ class acp_users
user_delete($delete_type, $user_id, $user_row['username']); user_delete($delete_type, $user_id, $user_row['username']);
add_log('admin', 'LOG_USER_DELETED', $user_row['username']); add_log('admin', 'LOG_USER_DELETED', $user_row['username']);
trigger_error($user->lang['USER_DELETED'] . adm_back_link($this->u_action)); trigger_error($user->lang['USER_DELETED'] . adm_back_link(
(empty($referer)) ? $this->u_action : $referer_url
)
);
} }
else else
{ {
confirm_box(false, $user->lang['CONFIRM_OPERATION'], build_hidden_fields(array( $delete_confirm_hidden_fields = array(
'u' => $user_id, 'u' => $user_id,
'i' => $id, 'i' => $id,
'mode' => $mode, 'mode' => $mode,
'action' => $action, 'action' => $action,
'update' => true, 'update' => true,
'delete' => 1, 'delete' => 1,
'delete_type' => $delete_type)) 'delete_type' => $delete_type
); );
// Checks if the redirection page is specified
if (!empty($referer))
{
$delete_confirm_hidden_fields['referer'] = $referer;
}
confirm_box(false, $user->lang['CONFIRM_OPERATION'], build_hidden_fields($delete_confirm_hidden_fields));
} }
} }
else else