From bb2dfe7f36094664a1122495a2de7b4f6950ae3b Mon Sep 17 00:00:00 2001 From: Vic D'Elfant Date: Tue, 24 Apr 2007 13:33:34 +0000 Subject: [PATCH] - #10085 - Added notice about iso.txt to the coding guidelines git-svn-id: file:///svn/phpbb/trunk@7394 89ea8834-ac86-4346-8a33-228a782c2dd0 --- phpBB/docs/coding-guidelines.html | 2 ++ phpBB/mcp.php | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/phpBB/docs/coding-guidelines.html b/phpBB/docs/coding-guidelines.html index c3b6776dd2..c877b73dc3 100644 --- a/phpBB/docs/coding-guidelines.html +++ b/phpBB/docs/coding-guidelines.html @@ -1892,6 +1892,8 @@ div
  • Language's local name
  • Authors information
    • + +

    iso.txt is automatically generated by the language pack submission system on phpBB.com. You don't have to create this file yourself if you plan on releasing your language pack on phpBB.com, but do keep in mind that phpBB itself does require this file to be present.

    Because language tags themselves are meant to be machine read, they can be rather obtuse to humans and why descriptive strings as provided by iso.txt are needed. Whilst en-US could be fairly easily deduced to be "English as used in the United States", de-CH is more difficult less one happens to know that de is from "Deutsch", German for "German" and CH is the abbreviation of the official Latin name for Switzerland, "Confoederatio Helvetica".

    diff --git a/phpBB/mcp.php b/phpBB/mcp.php index 1577c32de8..dc0b13c7b9 100644 --- a/phpBB/mcp.php +++ b/phpBB/mcp.php @@ -87,8 +87,7 @@ if ($post_id) $topic_id = (int) $row['topic_id']; $forum_id = (int) ($row['forum_id']) ? $row['forum_id'] : $forum_id; } - -if ($topic_id && !$forum_id) +else if ($topic_id) { $sql = 'SELECT forum_id FROM ' . TOPICS_TABLE . "