makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-11 13:58:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11700] Don't prefix dbms classnames with \

Browse source 
PHPBB3-11700
This commit is contained in:
Nils Adermann 2013-09-10 17:45:28 +02:00
parent d297eb4aec
commit bdaf68c113
2 changed files with 38 additions and 38 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/functions/convert_30_dbms_to_31_test.php
View file

@ -31,7 +31,7 @@ class phpbb_convert_30_dbms_to_31_test extends phpbb_test_case
*/ */
public function test_convert_30_dbms_to_31($input) public function test_convert_30_dbms_to_31($input)
{ {
$expected = "\\phpbb\\db\\driver\\$input"; $expected = "phpbb\\db\\driver\\$input";
$output = phpbb_convert_30_dbms_to_31($input); $output = phpbb_convert_30_dbms_to_31($input);

68
tests/test_framework/phpbb_database_test_connection_manager.php
View file

@ -108,7 +108,7 @@ class phpbb_database_test_connection_manager
// These require different connection strings on the phpBB side than they do in PDO // These require different connection strings on the phpBB side than they do in PDO
// so you must provide a DSN string for ODBC separately // so you must provide a DSN string for ODBC separately
if (!empty($this->config['custom_dsn']) && ($this->config['dbms'] == '\phpbb\db\driver\mssql' || $this->config['dbms'] == '\phpbb\db\driver\firebird')) if (!empty($this->config['custom_dsn']) && ($this->config['dbms'] == 'phpbb\db\driver\mssql' || $this->config['dbms'] == 'phpbb\db\driver\firebird'))
{ {
$dsn = 'odbc:' . $this->config['custom_dsn']; $dsn = 'odbc:' . $this->config['custom_dsn'];
} }
@ -117,12 +117,12 @@ class phpbb_database_test_connection_manager
{ {
switch ($this->config['dbms']) switch ($this->config['dbms'])
{ {
case '\phpbb\db\driver\mssql': case 'phpbb\db\driver\mssql':
case '\phpbb\db\driver\mssql_odbc': case 'phpbb\db\driver\mssql_odbc':
$this->pdo = new phpbb_database_connection_odbc_pdo_wrapper('mssql', 0, $dsn, $this->config['dbuser'], $this->config['dbpasswd']); $this->pdo = new phpbb_database_connection_odbc_pdo_wrapper('mssql', 0, $dsn, $this->config['dbuser'], $this->config['dbpasswd']);
break; break;
case '\phpbb\db\driver\firebird': case 'phpbb\db\driver\firebird':
if (!empty($this->config['custom_dsn'])) if (!empty($this->config['custom_dsn']))
{ {
$this->pdo = new phpbb_database_connection_odbc_pdo_wrapper('firebird', 0, $dsn, $this->config['dbuser'], $this->config['dbpasswd']); $this->pdo = new phpbb_database_connection_odbc_pdo_wrapper('firebird', 0, $dsn, $this->config['dbuser'], $this->config['dbpasswd']);
@ -145,8 +145,8 @@ class phpbb_database_test_connection_manager
switch ($this->config['dbms']) switch ($this->config['dbms'])
{ {
case '\phpbb\db\driver\mysql': case 'phpbb\db\driver\mysql':
case '\phpbb\db\driver\mysqli': case 'phpbb\db\driver\mysqli':
$this->pdo->exec('SET NAMES utf8'); $this->pdo->exec('SET NAMES utf8');
/* /*
@ -187,8 +187,8 @@ class phpbb_database_test_connection_manager
{ {
switch ($this->config['dbms']) switch ($this->config['dbms'])
{ {
case '\phpbb\db\driver\sqlite': case 'phpbb\db\driver\sqlite':
case '\phpbb\db\driver\firebird': case 'phpbb\db\driver\firebird':
$this->connect(); $this->connect();
// Drop all of the tables // Drop all of the tables
foreach ($this->get_tables() as $table) foreach ($this->get_tables() as $table)
@ -198,7 +198,7 @@ class phpbb_database_test_connection_manager
$this->purge_extras(); $this->purge_extras();
break; break;
case '\phpbb\db\driver\oracle': case 'phpbb\db\driver\oracle':
$this->connect(); $this->connect();
// Drop all of the tables // Drop all of the tables
foreach ($this->get_tables() as $table) foreach ($this->get_tables() as $table)
@ -208,7 +208,7 @@ class phpbb_database_test_connection_manager
$this->purge_extras(); $this->purge_extras();
break; break;
case '\phpbb\db\driver\postgres': case 'phpbb\db\driver\postgres':
$this->connect(); $this->connect();
// Drop all of the tables // Drop all of the tables
foreach ($this->get_tables() as $table) foreach ($this->get_tables() as $table)
@ -258,38 +258,38 @@ class phpbb_database_test_connection_manager
switch ($this->config['dbms']) switch ($this->config['dbms'])
{ {
case '\phpbb\db\driver\mysql': case 'phpbb\db\driver\mysql':
case '\phpbb\db\driver\mysqli': case 'phpbb\db\driver\mysqli':
$sql = 'SHOW TABLES'; $sql = 'SHOW TABLES';
break; break;
case '\phpbb\db\driver\sqlite': case 'phpbb\db\driver\sqlite':
$sql = 'SELECT name $sql = 'SELECT name
FROM sqlite_master FROM sqlite_master
WHERE type = "table"'; WHERE type = "table"';
break; break;
case '\phpbb\db\driver\mssql': case 'phpbb\db\driver\mssql':
case '\phpbb\db\driver\mssql_odbc': case 'phpbb\db\driver\mssql_odbc':
case '\phpbb\db\driver\mssqlnative': case 'phpbb\db\driver\mssqlnative':
$sql = "SELECT name $sql = "SELECT name
FROM sysobjects FROM sysobjects
WHERE type='U'"; WHERE type='U'";
break; break;
case '\phpbb\db\driver\postgres': case 'phpbb\db\driver\postgres':
$sql = 'SELECT relname $sql = 'SELECT relname
FROM pg_stat_user_tables'; FROM pg_stat_user_tables';
break; break;
case '\phpbb\db\driver\firebird': case 'phpbb\db\driver\firebird':
$sql = 'SELECT rdb$relation_name $sql = 'SELECT rdb$relation_name
FROM rdb$relations FROM rdb$relations
WHERE rdb$view_source is null WHERE rdb$view_source is null
AND rdb$system_flag = 0'; AND rdb$system_flag = 0';
break; break;
case '\phpbb\db\driver\oracle': case 'phpbb\db\driver\oracle':
$sql = 'SELECT table_name $sql = 'SELECT table_name
FROM USER_TABLES'; FROM USER_TABLES';
break; break;
@ -325,7 +325,7 @@ class phpbb_database_test_connection_manager
{ {
$schema = $this->dbms['SCHEMA']; $schema = $this->dbms['SCHEMA'];
if ($this->config['dbms'] == '\phpbb\db\driver\mysql') if ($this->config['dbms'] == 'phpbb\db\driver\mysql')
{ {
$sth = $this->pdo->query('SELECT VERSION() AS version'); $sth = $this->pdo->query('SELECT VERSION() AS version');
$row = $sth->fetch(PDO::FETCH_ASSOC); $row = $sth->fetch(PDO::FETCH_ASSOC);
@ -359,47 +359,47 @@ class phpbb_database_test_connection_manager
protected function get_dbms_data($dbms) protected function get_dbms_data($dbms)
{ {
$available_dbms = array( $available_dbms = array(
'\phpbb\db\driver\firebird' => array( 'phpbb\db\driver\firebird' => array(
'SCHEMA' => 'firebird', 'SCHEMA' => 'firebird',
'DELIM' => ';;', 'DELIM' => ';;',
'PDO' => 'firebird', 'PDO' => 'firebird',
), ),
'\phpbb\db\driver\mysqli' => array( 'phpbb\db\driver\mysqli' => array(
'SCHEMA' => 'mysql_41', 'SCHEMA' => 'mysql_41',
'DELIM' => ';', 'DELIM' => ';',
'PDO' => 'mysql', 'PDO' => 'mysql',
), ),
'\phpbb\db\driver\mysql' => array( 'phpbb\db\driver\mysql' => array(
'SCHEMA' => 'mysql', 'SCHEMA' => 'mysql',
'DELIM' => ';', 'DELIM' => ';',
'PDO' => 'mysql', 'PDO' => 'mysql',
), ),
'\phpbb\db\driver\mssql' => array( 'phpbb\db\driver\mssql' => array(
'SCHEMA' => 'mssql', 'SCHEMA' => 'mssql',
'DELIM' => 'GO', 'DELIM' => 'GO',
'PDO' => 'odbc', 'PDO' => 'odbc',
), ),
'\phpbb\db\driver\mssql_odbc'=> array( 'phpbb\db\driver\mssql_odbc'=> array(
'SCHEMA' => 'mssql', 'SCHEMA' => 'mssql',
'DELIM' => 'GO', 'DELIM' => 'GO',
'PDO' => 'odbc', 'PDO' => 'odbc',
), ),
'\phpbb\db\driver\mssqlnative' => array( 'phpbb\db\driver\mssqlnative' => array(
'SCHEMA' => 'mssql', 'SCHEMA' => 'mssql',
'DELIM' => 'GO', 'DELIM' => 'GO',
'PDO' => 'sqlsrv', 'PDO' => 'sqlsrv',
), ),
'\phpbb\db\driver\oracle' => array( 'phpbb\db\driver\oracle' => array(
'SCHEMA' => 'oracle', 'SCHEMA' => 'oracle',
'DELIM' => '/', 'DELIM' => '/',
'PDO' => 'oci', 'PDO' => 'oci',
), ),
'\phpbb\db\driver\postgres' => array( 'phpbb\db\driver\postgres' => array(
'SCHEMA' => 'postgres', 'SCHEMA' => 'postgres',
'DELIM' => ';', 'DELIM' => ';',
'PDO' => 'pgsql', 'PDO' => 'pgsql',
), ),
'\phpbb\db\driver\sqlite' => array( 'phpbb\db\driver\sqlite' => array(
'SCHEMA' => 'sqlite', 'SCHEMA' => 'sqlite',
'DELIM' => ';', 'DELIM' => ';',
'PDO' => 'sqlite2', 'PDO' => 'sqlite2',
@ -428,7 +428,7 @@ class phpbb_database_test_connection_manager
switch ($this->config['dbms']) switch ($this->config['dbms'])
{ {
case '\phpbb\db\driver\firebird': case 'phpbb\db\driver\firebird':
$sql = 'SELECT RDB$GENERATOR_NAME $sql = 'SELECT RDB$GENERATOR_NAME
FROM RDB$GENERATORS FROM RDB$GENERATORS
WHERE RDB$SYSTEM_FLAG = 0'; WHERE RDB$SYSTEM_FLAG = 0';
@ -440,7 +440,7 @@ class phpbb_database_test_connection_manager
} }
break; break;
case '\phpbb\db\driver\oracle': case 'phpbb\db\driver\oracle':
$sql = 'SELECT sequence_name $sql = 'SELECT sequence_name
FROM USER_SEQUENCES'; FROM USER_SEQUENCES';
$result = $this->pdo->query($sql); $result = $this->pdo->query($sql);
@ -451,7 +451,7 @@ class phpbb_database_test_connection_manager
} }
break; break;
case '\phpbb\db\driver\postgres': case 'phpbb\db\driver\postgres':
$sql = 'SELECT sequence_name $sql = 'SELECT sequence_name
FROM information_schema.sequences'; FROM information_schema.sequences';
$result = $this->pdo->query($sql); $result = $this->pdo->query($sql);
@ -509,7 +509,7 @@ class phpbb_database_test_connection_manager
switch ($this->config['dbms']) switch ($this->config['dbms'])
{ {
case '\phpbb\db\driver\oracle': case 'phpbb\db\driver\oracle':
// Get all of the information about the sequences // Get all of the information about the sequences
$sql = "SELECT t.table_name, tc.column_name, d.referenced_name as sequence_name, s.increment_by, s.min_value $sql = "SELECT t.table_name, tc.column_name, d.referenced_name as sequence_name, s.increment_by, s.min_value
FROM USER_TRIGGERS t FROM USER_TRIGGERS t
@ -551,7 +551,7 @@ class phpbb_database_test_connection_manager
} }
break; break;
case '\phpbb\db\driver\postgres': case 'phpbb\db\driver\postgres':
// Get the sequences attached to the tables // Get the sequences attached to the tables
$sql = 'SELECT column_name, table_name FROM information_schema.columns $sql = 'SELECT column_name, table_name FROM information_schema.columns
WHERE table_name IN (' . implode(', ', $table_names) . ") WHERE table_name IN (' . implode(', ', $table_names) . ")