[ticket/14492] Rename files to help_phpbb and fix css tabbing

PHPBB3-14492

phpBB/adm/style/acp_help_phpbb.html

@@ -30,10 +30,10 @@
 		</div>
 		<dl class="send-stats-settings">
 			<dt>
-				<input id="enable-stats" type="checkbox" />
+				<input id="enable-stats" type="checkbox" checked="checked" />
 				<label for="enable-stats"></label>
 			</dt>
-			<dd>{L_YES}</dd>
+			<dd>{L_SEND_STATISTICS}</dd>
 		</dl>
 	</div>
 	<div class="send-stats-tile">
@@ -48,24 +48,5 @@
 		</dl>
 	</div>
 </div>
-<div style="clear: both; display: none;">
-<script type="text/javascript">
-//<![CDATA[
-var iframect = 0;
-
-function iframe_updated()
-{
-	if (iframect++ == 0)
-	{
-		return;
-	}
-
-	phpbb.toggleDisplay('questionnaire-form', -1);
-	phpbb.toggleDisplay('questionnaire-thanks', 1);
-}
-//]]>
-</script>
-
-</div>
 
 <!-- INCLUDE overall_footer.html -->

phpBB/adm/style/admin.css

@@ -2686,6 +2686,7 @@ fieldset.permissions .padding {
 
 .send-stats-data-row a {
 	text-decoration: none;
+	cursor: default;
 }
 
 .send-stats-data-row i {

phpBB/includes/acp/acp_help_phpbb.php

@@ -19,7 +19,7 @@ if (!defined('IN_PHPBB'))
 	exit;
 }
 
-class acp_send_statistics
+class acp_help_phpbb
 {
 	var $u_action;
 
@@ -34,7 +34,7 @@ class acp_send_statistics
 
 		$collect_url = "https://www.phpbb.com/stats/receive_stats.php";
 
-		$this->tpl_name = 'acp_send_statistics';
+		$this->tpl_name = 'acp_help_phpbb';
 		$this->page_title = 'ACP_SEND_STATISTICS';
 
 		// generate a unique id if necessary

phpBB/includes/acp/info/acp_help_phpbb.php

@@ -11,15 +11,15 @@
 *
 */
 
-class acp_send_statistics_info
+class acp_help_phpbb_info
 {
 	function module()
 	{
 		return array(
-			'filename'	=> 'acp_send_statistics',
+			'filename'	=> 'acp_help_phpbb',
 			'title'		=> 'ACP_SEND_STATISTICS',
 			'modes'		=> array(
-				'send_statistics'		=> array('title' => 'ACP_SEND_STATISTICS', 'auth' => 'acl_a_server', 'cat' => array('ACP_SERVER_CONFIGURATION')),
+				'help_phpbb'	=> array('title' => 'ACP_SEND_STATISTICS', 'auth' => 'acl_a_server', 'cat' => array('ACP_SERVER_CONFIGURATION')),
 			),
 		);
 	}

phpBB/phpbb/db/migration/data/v320/add_help_phpbb.php

@@ -0,0 +1,49 @@
+<?php
+/**
+*
+* This file is part of the phpBB Forum Software package.
+*
+* @copyright (c) phpBB Limited <https://www.phpbb.com>
+* @license GNU General Public License, version 2 (GPL-2.0)
+*
+* For full copyright and license information, please see
+* the docs/CREDITS.txt file.
+*
+*/
+
+namespace phpbb\db\migration\data\v320;
+
+class add_help_phpbb extends \phpbb\db\migration\migration
+{
+	static public function depends_on()
+	{
+		return array(
+			'\phpbb\db\migration\data\v320\v320a2',
+		);
+	}
+
+	public function effectively_installed()
+	{
+		return isset($this->config['help_send_statistics']);
+	}
+
+	public function update_data()
+	{
+		return array(
+			array('config.add', array('help_send_statistics', true)),
+			array('module.remove', array(
+				'acp',
+				false,
+				'ACP_SEND_STATISTICS',
+			)),
+			array('module.add', array(
+				'acp',
+				'ACP_SERVER_CONFIGURATION',
+				array(
+					'module_basename'	=> 'acp_help_phpbb',
+					'modes'				=> array('help_phpbb'),
+				),
+			)),
+		);
+	}
+}