From 7d04d953c77e4dac4fb0d4557f042cce3b001cfe Mon Sep 17 00:00:00 2001 From: hanakin Date: Wed, 18 Jun 2014 11:31:49 +0200 Subject: [PATCH 1/7] [ticket/12735] Remove all :link, :visited, :active states PHPBB3-12735 --- phpBB/styles/prosilver/theme/colours.css | 71 ++---------------------- phpBB/styles/prosilver/theme/links.css | 38 +++---------- 2 files changed, 12 insertions(+), 97 deletions(-) diff --git a/phpBB/styles/prosilver/theme/colours.css b/phpBB/styles/prosilver/theme/colours.css index 4b7532ab8a..d396ff2a14 100644 --- a/phpBB/styles/prosilver/theme/colours.css +++ b/phpBB/styles/prosilver/theme/colours.css @@ -241,16 +241,10 @@ Colours and backgrounds for links.css -------------------------------------------------------------- */ a { color: #105289; } -a:visited { color: #105289; } a:hover { color: #D31141; } -a:active { color: #368AD2; } /* Links on gradient backgrounds */ -#search-box a:link, .navbg a:link, .forumbg .header a:link, .forabg .header a:link, th a:link { - color: #FFFFFF; -} - -#search-box a:visited, .navbg a:visited, .forumbg .header a:visited, .forabg .header a:visited, th a:visited { +.headerbar form a, .navbg a, .forumbg .header a, .forabg .header a, th a { color: #FFFFFF; } @@ -258,44 +252,11 @@ a:active { color: #368AD2; } color: #A8D8FF; } -#search-box a:active, .navbg a:active, .forumbg .header a:active, .forabg .header a:active, th a:active { - color: #C8E6FF; -} - /* Notification mark read link */ .dropdown-extended a.mark_read { background-color: #FFFFFF; } -/* Links for forum/topic lists */ -a.forumtitle { - color: #105289; -} - -/* a.forumtitle:visited { color: #105289; } */ - -a.forumtitle:hover { - color: #BC2A4D; -} - -a.forumtitle:active { - color: #105289; -} - -a.topictitle { - color: #105289; -} - -/* a.topictitle:visited { color: #368AD2; } */ - -a.topictitle:hover { - color: #BC2A4D; -} - -a.topictitle:active { - color: #105289; -} - /* Post body links */ .postlink { color: #368AD2; @@ -307,7 +268,7 @@ a.topictitle:active { border-bottom-color: #5D8FBD; } -.postlink:active { +.postlink { color: #368AD2; } @@ -316,32 +277,10 @@ a.topictitle:active { color: #0D4473; } -.signature a, .signature a:visited, .signature a:hover, .signature a:active { +.signature a, .signature a:hover { background-color: transparent; } -/* Profile links */ -.postprofile a:link, .postprofile a:visited, .postprofile dt.author a { - color: #105289; -} - -.postprofile a:hover, .postprofile dt.author a:hover { - color: #D31141; -} - -.postprofile a:active { - color: #105289; -} - -/* Profile searchresults */ -.search .postprofile a { - color: #105289; -} - -.search .postprofile a:hover { - color: #D31141; -} - /* Back to top of page */ a.top { background-image: url("./images/icon_back_top.gif"); @@ -658,7 +597,7 @@ dd.profile-warnings { -------------------------------------------------------------- Colours and backgrounds for buttons.css -------------------------------------------------------------- */ -.button, .button:visited { +.button { border-color: #C7C3BF; background-color: #FFFFFF; background-image: -moz-linear-gradient(top, #FFFFFF, #E9E9E9); @@ -1079,7 +1018,7 @@ a.button2, input.button2, input.button3 { } /* button in the style of the form buttons */ -a.button1, a.button1:link, a.button1:visited, a.button1:active, a.button2, a.button2:link, a.button2:visited, a.button2:active { +a.button1, a.button2 { color: #000000; } diff --git a/phpBB/styles/prosilver/theme/links.css b/phpBB/styles/prosilver/theme/links.css index 89639dde02..79751cb1a7 100644 --- a/phpBB/styles/prosilver/theme/links.css +++ b/phpBB/styles/prosilver/theme/links.css @@ -7,18 +7,10 @@ a { unicode-bidi: embed; } -a:link, a:visited { - text-decoration: none; -} - a:hover { text-decoration: underline; } -a:active { - text-decoration: none; -} - /* Coloured usernames */ .username-coloured { font-weight: bold; @@ -27,11 +19,7 @@ a:active { } /* Links on gradient backgrounds */ -#search-box a:link, .navbg a:link, .forumbg .header a:link, .forabg .header a:link, th a:link { - text-decoration: none; -} - -#search-box a:visited, .navbg a:visited, .forumbg .header a:visited, .forabg .header a:visited, th a:visited { +#search-box a, .navbg a, .forumbg .header a, .forabg .header a, th a { text-decoration: none; } @@ -39,10 +27,6 @@ a:active { text-decoration: underline; } -#search-box a:active, .navbg a:active, .forumbg .header a:active, .forabg .header a:active, th a:active { - text-decoration: none; -} - /* Navigation bar links */ ul.linklist li.small-icon > a, ul.linklist li.breadcrumbs span:first-child > a { display: inline-block; @@ -118,13 +102,13 @@ a.lastsubject:hover { text-decoration: none; } -.signature a, .signature a:visited, .signature a:hover, .signature a:active { +.signature a, .signature a:hover { border: none; text-decoration: underline; } /* Profile links */ -.postprofile a:link, .postprofile a:visited, .postprofile dt.author a { +.postprofile a, .postprofile dt.author a { font-weight: bold; text-decoration: none; } @@ -133,14 +117,6 @@ a.lastsubject:hover { text-decoration: underline; } -/* CSS spec requires a:link, a:visited, a:hover and a:active rules to be specified in this order. */ -/* See http://www.phpbb.com/bugs/phpbb3/59685 */ -.postprofile a:active { - font-weight: bold; - text-decoration: none; -} - - /* Profile searchresults */ .search .postprofile a { text-decoration: none; @@ -182,7 +158,7 @@ a.arrow-down { background: none no-repeat right center; } a.arrow-left { background: none no-repeat 3px 60%; } a.arrow-right { background: none no-repeat 95% 60%; } -a.arrow-up, a.arrow-up:link, a.arrow-up:active, a.arrow-up:visited { +a.arrow-up { padding-left: 10px; text-decoration: none; border-bottom-width: 0; @@ -192,7 +168,7 @@ a.arrow-up:hover { background-position: left top; } -a.arrow-down, a.arrow-down:link, a.arrow-down:active, a.arrow-down:visited { +a.arrow-down { padding-right: 10px; } @@ -201,7 +177,7 @@ a.arrow-down:hover { text-decoration: none; } -a.arrow-left, a.arrow-left:active, a.arrow-left:visited { +a.arrow-left { padding-left: 12px; } @@ -210,7 +186,7 @@ a.arrow-left:hover { background-position: 0 60%; } -a.arrow-right, a.arrow-right:active, a.arrow-right:visited { +a.arrow-right { padding-right: 12px; } From 194224b550ff52133426d8de1fd178d877fb4d70 Mon Sep 17 00:00:00 2001 From: hanakin Date: Wed, 18 Jun 2014 11:41:27 +0200 Subject: [PATCH 2/7] [ticket/12735] Undo selector rename PHPBB3-12735 --- phpBB/styles/prosilver/theme/colours.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpBB/styles/prosilver/theme/colours.css b/phpBB/styles/prosilver/theme/colours.css index d396ff2a14..22997506b5 100644 --- a/phpBB/styles/prosilver/theme/colours.css +++ b/phpBB/styles/prosilver/theme/colours.css @@ -244,7 +244,7 @@ a { color: #105289; } a:hover { color: #D31141; } /* Links on gradient backgrounds */ -.headerbar form a, .navbg a, .forumbg .header a, .forabg .header a, th a { +#search-box a, .navbg a, .forumbg .header a, .forabg .header a, th a { color: #FFFFFF; } From 8ef8056fd4e1184bb9679bd717db619b249f0f7b Mon Sep 17 00:00:00 2001 From: hanakin Date: Mon, 23 Jun 2014 01:12:33 +0200 Subject: [PATCH 3/7] [ticket/12735] Remove underlines by default PHPBB3-12735 --- phpBB/styles/prosilver/theme/links.css | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/phpBB/styles/prosilver/theme/links.css b/phpBB/styles/prosilver/theme/links.css index 79751cb1a7..890f854baa 100644 --- a/phpBB/styles/prosilver/theme/links.css +++ b/phpBB/styles/prosilver/theme/links.css @@ -5,11 +5,10 @@ a { direction: ltr; unicode-bidi: embed; + text-decoration: none; } -a:hover { - text-decoration: underline; -} +a:hover { text-decoration: underline; } /* Coloured usernames */ .username-coloured { @@ -117,14 +116,14 @@ a.lastsubject:hover { text-decoration: underline; } -/* Profile searchresults */ +/* Profile searchresults */ .search .postprofile a { - text-decoration: none; + text-decoration: none; font-weight: normal; } .search .postprofile a:hover { - text-decoration: underline; + text-decoration: underline; } /* Back to top of page */ From bf3ac9b1dcb8588d946be3523fce58dcad1a90ea Mon Sep 17 00:00:00 2001 From: hanakin Date: Mon, 23 Jun 2014 01:31:46 +0200 Subject: [PATCH 4/7] [ticket/12735] Fix some color incosistencies PHPBB3-12735 --- phpBB/styles/prosilver/theme/colours.css | 8 ++++---- phpBB/styles/prosilver/theme/common.css | 4 ---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/phpBB/styles/prosilver/theme/colours.css b/phpBB/styles/prosilver/theme/colours.css index 22997506b5..f9e22efbc7 100644 --- a/phpBB/styles/prosilver/theme/colours.css +++ b/phpBB/styles/prosilver/theme/colours.css @@ -607,7 +607,7 @@ Colours and backgrounds for buttons.css -ms-filter: "progid:DXImageTransform.Microsoft.gradient(startColorStr='#FFFFFF', EndColorStr='#E9E9E9')"; box-shadow: 0 0 0 1px #FFFFFF inset; -webkit-box-shadow: 0 0 0 1px #FFFFFF inset; - color: #BC2A4D; + color: #D31141; } .button:hover, .dropdown-visible .dropdown-select, .nojs .dropdown-container:hover .dropdown-select { @@ -753,7 +753,7 @@ ul.cplist { #tabs .tab > a:hover { background: #DDEDFB; - color: #BC2A4D; + color: #D31141; } #tabs .activetab > a, @@ -793,8 +793,8 @@ ul.cplist { border-color: #536482; } -.responsive-tab .responsive-tab-link:hover:before { - border-color: #BC2A4D; +.responsive-tab .responsive-tab-link:hover span:before { + border-color: #D31141; } /* UCP navigation menu diff --git a/phpBB/styles/prosilver/theme/common.css b/phpBB/styles/prosilver/theme/common.css index a52f5e494d..601da2f912 100644 --- a/phpBB/styles/prosilver/theme/common.css +++ b/phpBB/styles/prosilver/theme/common.css @@ -222,10 +222,6 @@ ol ol ul, ol ul ul, ul ol ul, ul ul ul { width: 95px; } -#search-box input { - border: 1px solid transparent; -} - /* .button1 style defined later, just a few tweaks for the search button version */ #search-box input.button1 { padding: 1px 5px; From 710e0e7aa658fc604110dc5f988559916fb002b5 Mon Sep 17 00:00:00 2001 From: hanakin Date: Tue, 24 Jun 2014 19:07:20 +0200 Subject: [PATCH 5/7] [ticket/12732] Undo search-box change PHPBB3-12735 --- phpBB/styles/prosilver/theme/common.css | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/phpBB/styles/prosilver/theme/common.css b/phpBB/styles/prosilver/theme/common.css index 601da2f912..e7369e11cf 100644 --- a/phpBB/styles/prosilver/theme/common.css +++ b/phpBB/styles/prosilver/theme/common.css @@ -218,14 +218,11 @@ ol ol ul, ol ul ul, ul ol ul, ul ul ul { white-space: nowrap; /* For Opera */ } -#search-box #keywords { - width: 95px; -} +#search-box #keywords { width: 95px; } +#search-box input { border: 1px solid transparent; } /* .button1 style defined later, just a few tweaks for the search button version */ -#search-box input.button1 { - padding: 1px 5px; -} +#search-box input.button1 { padding: 1px 5px; } #search-box li { text-align: right; @@ -908,14 +905,14 @@ fieldset.fields1 dl.pmlist dd.recipients { .phpbb_alert { border: 1px solid transparent; display: none; - left: 0; + left: 0; padding: 0 25px 20px 25px; position: fixed; - right: 0; + right: 0; top: 150px; z-index: 50; width: 620px; - margin: 0 auto; + margin: 0 auto; } @media only screen and (max-height: 500px), only screen and (max-device-width: 500px) @@ -1139,7 +1136,7 @@ form > p.post-notice strong { font-size: 11px; font-weight: bold; text-shadow: 1px 1px 1px white; - text-transform: uppercase; + text-transform: uppercase; line-height: 30px; border-bottom: 1px solid; border-radius: 5px 5px 0 0; From 20e9480ba5b1e5c9ec3a4bcd58b533e4590960f1 Mon Sep 17 00:00:00 2001 From: hanakin Date: Wed, 25 Jun 2014 06:35:03 +0200 Subject: [PATCH 6/7] [ticket/12735] Fix line breaks PHPBB3-12735 --- phpBB/styles/prosilver/theme/common.css | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/phpBB/styles/prosilver/theme/common.css b/phpBB/styles/prosilver/theme/common.css index e7369e11cf..70d17d8bbe 100644 --- a/phpBB/styles/prosilver/theme/common.css +++ b/phpBB/styles/prosilver/theme/common.css @@ -218,11 +218,18 @@ ol ol ul, ol ul ul, ul ol ul, ul ul ul { white-space: nowrap; /* For Opera */ } -#search-box #keywords { width: 95px; } -#search-box input { border: 1px solid transparent; } +#search-box #keywords { + width: 95px; +} + +#search-box input { + border: 1px solid transparent; +} /* .button1 style defined later, just a few tweaks for the search button version */ -#search-box input.button1 { padding: 1px 5px; } +#search-box input.button1 { + padding: 1px 5px; +} #search-box li { text-align: right; From 5783b00fb6f176fb3ef23bd10a545bc32e2cfb92 Mon Sep 17 00:00:00 2001 From: hanakin Date: Mon, 30 Jun 2014 17:14:29 +0200 Subject: [PATCH 7/7] [ticket/12735] Remove unnecessary span PHPBB3-12735 --- phpBB/styles/prosilver/theme/colours.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpBB/styles/prosilver/theme/colours.css b/phpBB/styles/prosilver/theme/colours.css index f9e22efbc7..2319f2d22a 100644 --- a/phpBB/styles/prosilver/theme/colours.css +++ b/phpBB/styles/prosilver/theme/colours.css @@ -793,7 +793,7 @@ ul.cplist { border-color: #536482; } -.responsive-tab .responsive-tab-link:hover span:before { +.responsive-tab .responsive-tab-link:hover:before { border-color: #D31141; }