makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10021] Add comment explaining why we can check -1 as an error value.

Browse source 
PHPBB3-10021
This commit is contained in:
Andreas Fischer 2011-03-18 02:51:43 +01:00
parent 65580f7901
commit c24408f6ed
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
phpBB/memberlist.php
View file

@ -1072,6 +1072,11 @@ switch ($mode)
if (isset($find_key_match[$joined_select]) && sizeof($joined) == 3) if (isset($find_key_match[$joined_select]) && sizeof($joined) == 3)
{ {
// Before PHP 5.1 an error value -1 can be returned instead of false.
// Theoretically gmmktime() can also legitimately return -1 as an actual timestamp.
// But since we do not pass the $second parameter to gmmktime(),
// an actual unix timestamp -1 cannot be returned in this case.
// Thus we can check whether it is -1 and treat -1 as an error.
$joined_time = gmmktime(0, 0, 0, (int) $joined[1], (int) $joined[2], (int) $joined[0]); $joined_time = gmmktime(0, 0, 0, (int) $joined[1], (int) $joined[2], (int) $joined[0]);
if ($joined_time !== false && $joined_time !== -1) if ($joined_time !== false && $joined_time !== -1)