makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-07 20:08:53 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/13713] Handle TODOs

Browse source 
PHPBB3-13713
This commit is contained in:
lavigor 2018-08-14 02:48:28 +03:00 • committed by Marc Alexander
parent f64dbf5303
commit c2720792ac
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
5 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
phpBB/adm/style/admin.css
View file

@ -1721,7 +1721,7 @@ fieldset.submit-buttons legend {
height: 40px; height: 40px;
} }
svg.mention-media-avatar { /* TODO: remove it after general normalization */ svg { /* TODO: remove it after general normalization */
fill: currentColor; fill: currentColor;
} }

1
phpBB/assets/javascript/editor.js
View file

@ -480,7 +480,6 @@ function getCaretPosition(txtarea) {
at: "@", at: "@",
acceptSpaceBar: true, acceptSpaceBar: true,
displayTpl: function(data) { displayTpl: function(data) {
// TODO: handle image scaling
let avatar = (data.avatar.img) ? "<span class='mention-media-avatar'>" + data.avatar.img + "</span>" : defaultAvatar(data.avatar.type), let avatar = (data.avatar.img) ? "<span class='mention-media-avatar'>" + data.avatar.img + "</span>" : defaultAvatar(data.avatar.type),
rank = (data.rank) ? "<span class='mention-rank'>" + data.rank + "</span>" : ''; rank = (data.rank) ? "<span class='mention-rank'>" + data.rank + "</span>" : '';
return "<li class='mention-item'><span class='mention-media'>" + avatar + "</span><span class='mention-name'>" + data.name + rank + "</span></li>"; return "<li class='mention-item'><span class='mention-media'>" + avatar + "</span><span class='mention-name'>" + data.name + rank + "</span></li>";

1
phpBB/phpbb/notification/type/mention.php
View file

@ -91,7 +91,6 @@ class mention extends \phpbb\notification\type\post
/** /**
* Update a notification * Update a notification
* TODO: decide what to do with this stuff
* *
* @param array $post Data specific for this type that will be updated * @param array $post Data specific for this type that will be updated
* @return true * @return true

1
phpBB/phpbb/textformatter/data_access.php
View file

@ -138,7 +138,6 @@ class data_access
'email' => 10, 'email' => 10,
'flash' => 11, 'flash' => 11,
'attachment' => 12, 'attachment' => 12,
'mention' => 13, // TODO: change ID/remove?
); );
$styles = array(); $styles = array();

2
phpBB/styles/prosilver/theme/mentions.css
View file

@ -43,7 +43,7 @@
height: 40px; height: 40px;
} }
svg.mention-media-avatar { /* TODO: remove it after general normalization */ svg { /* TODO: remove it after general normalization */
fill: currentColor; fill: currentColor;
} }