From 18abef716ecf42a35416444f3f84f5459d573789 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Wed, 23 Dec 2015 17:31:43 +0100 Subject: [PATCH 1/2] [ticket/security-188] Check form key in acp_bbcodes SECURITY-188 --- phpBB/includes/acp/acp_bbcodes.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/phpBB/includes/acp/acp_bbcodes.php b/phpBB/includes/acp/acp_bbcodes.php index e245eea069..35ac33882e 100644 --- a/phpBB/includes/acp/acp_bbcodes.php +++ b/phpBB/includes/acp/acp_bbcodes.php @@ -33,6 +33,7 @@ class acp_bbcodes // Set up general vars $action = request_var('action', ''); $bbcode_id = request_var('bbcode', 0); + $submit = $request->is_set_post('submit'); $this->tpl_name = 'acp_bbcodes'; $this->page_title = 'ACP_BBCODES'; @@ -40,6 +41,11 @@ class acp_bbcodes add_form_key($form_key); + if ($submit && !check_form_key($form_key)) + { + trigger_error($user->lang['FORM_INVALID'] . adm_back_link($this->u_action), E_USER_WARNING); + } + // Set up mode-specific vars switch ($action) { From 87345807ded8602c0266ccf9b04ea39e0f30243d Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Wed, 23 Dec 2015 17:32:31 +0100 Subject: [PATCH 2/2] [ticket/security-188] Remove unused form key from acp_extensions SECURITY-188 --- phpBB/includes/acp/acp_extensions.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/phpBB/includes/acp/acp_extensions.php b/phpBB/includes/acp/acp_extensions.php index 0c9bc0deab..e66bd01464 100644 --- a/phpBB/includes/acp/acp_extensions.php +++ b/phpBB/includes/acp/acp_extensions.php @@ -121,8 +121,6 @@ class acp_extensions 'U_ACTION' => $this->u_action, )); - add_form_key('version_check_settings'); - $this->tpl_name = 'acp_ext_list'; break;