[ticket/13740] Fix CS and extend phpbb extensions

[ci skip]

PHPBB3-13740

phpBB/config/default/container/services_http.yml

@@ -1,4 +1,11 @@
 services:
+    http_kernel:
+        class: Symfony\Component\HttpKernel\HttpKernel
+        arguments:
+            - @dispatcher
+            - @controller.resolver
+            - @request_stack
+
     # WARNING: The Symfony request does not escape the input and should be used very carefully
     #           prefer the phpbb request (service @request) as possible
     symfony_request:
@@ -14,10 +21,3 @@ services:
         arguments:
             - null
             - %core.disable_super_globals%
-
-    http_kernel:
-        class: Symfony\Component\HttpKernel\HttpKernel
-        arguments:
-            - @dispatcher
-            - @controller.resolver
-            - @request_stack

phpBB/phpbb/install/controller/helper.php

@@ -13,6 +13,13 @@
 
 namespace phpbb\install\controller;
 
+use phpbb\install\helper\navigation\navigation_provider;
+use phpbb\language\language;
+use phpbb\language\language_file_helper;
+use phpbb\path_helper;
+use phpbb\routing\router;
+use phpbb\symfony_request;
+use phpbb\template\template;
 use Symfony\Component\HttpFoundation\Response;
 
 /**
@@ -68,7 +75,19 @@ class helper
 	 */
 	protected $phpbb_root_path;
 
-	public function __construct(\phpbb\language\language $language, \phpbb\language\language_file_helper $lang_helper, \phpbb\install\helper\navigation\navigation_provider $nav, \phpbb\template\template $template, \phpbb\path_helper $path_helper, \phpbb\symfony_request $request, \phpbb\routing\router $router, $phpbb_root_path)
+	/**
+	 * Constructor
+	 *
+	 * @param language				$language
+	 * @param language_file_helper	$lang_helper
+	 * @param navigation_provider	$nav
+	 * @param template				$template
+	 * @param path_helper			$path_helper
+	 * @param symfony_request		$request
+	 * @param router				$router
+	 * @param string				$phpbb_root_path
+	 */
+	public function __construct(language $language, language_file_helper $lang_helper, navigation_provider $nav, template $template, path_helper $path_helper, symfony_request $request, router $router, $phpbb_root_path)
 	{
 		$this->language = $language;
 		$this->lang_helper = $lang_helper;

phpBB/phpbb/install/exception/installer_exception.php

@@ -13,10 +13,12 @@
 
 namespace phpbb\install\exception;
 
+use phpbb\exception\runtime_exception;
+
 /**
  * Installer's base exception
  */
-class installer_exception extends \Exception
+class installer_exception extends runtime_exception
 {
 
 }

phpBB/phpbb/install/exception/invalid_service_name_exception.php

@@ -15,55 +15,5 @@ namespace phpbb\install\exception;
 
 class invalid_service_name_exception extends installer_exception
 {
-	/**
-	 * @var string
-	 */
-	private $params;
 
-	/**
-	 * @var string
-	 */
-	private $error;
-
-	/**
-	 * Constructor
-	 *
-	 * @param string	$error	The name of the missing installer module
-	 * @param array		$params	Additional values for message translation
-	 */
-	public function __construct($error, $params = array())
-	{
-		$this->error = $error;
-		$this->params = $params;
-	}
-
-	/**
-	 * Returns the language entry's name for the error
-	 *
-	 * @return string
-	 */
-	public function get_error()
-	{
-		return $this->error;
-	}
-
-	/**
-	 * Returns parameters for the language entry, if there is any
-	 *
-	 * @return array
-	 */
-	public function get_params()
-	{
-		return $this->params;
-	}
-
-	/**
-	 * Returns true, if there are any parameters set
-	 *
-	 * @return bool
-	 */
-	public function has_params()
-	{
-		return (sizeof($this->params) !== 0);
-	}
 }

phpBB/phpbb/install/installer.php

@@ -229,17 +229,18 @@ class installer
 		}
 		catch (invalid_service_name_exception $e)
 		{
-			if ($e->has_params())
+			$params = $e->get_parameters();
+
+			if (!empty($params))
 			{
-				$msg = $e->get_params();
+				array_unshift($params, $e->getMessage());
-				array_unshift($msg, $e->get_error());
 			}
 			else
 			{
-				$msg = $e->get_error();
+				$params = $e->getMessage();
 			}
 
-			$this->iohandler->add_error_message($msg);
+			$this->iohandler->add_error_message($params);
 			$flush_messages = true;
 		}