makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-25 11:28:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge remote-tracking branch 'Fyorl/ticket/10963' into develop

Browse source 
* Fyorl/ticket/10963:
  [ticket/10963] filespec::get_mimetype now used
  [ticket/10963] Removed superfluous ternary statement and strpos now stricter
  [ticket/10963] Modified filespec::is_image() to check actual mimetype
This commit is contained in:
Andreas Fischer 2012-07-05 02:00:31 +02:00
commit c54d74ec0e
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
phpBB/includes/functions_upload.php
View file

@ -151,7 +151,8 @@ class filespec
*/ */
function is_image() function is_image()
{ {
return (strpos($this->mimetype, 'image/') !== false) ? true : false; $mimetype = $this->get_mimetype($this->filename);
return (strpos($mimetype, 'image/') === 0);
} }
/** /**
@ -200,17 +201,12 @@ class filespec
} }
/** /**
* Get mimetype. Utilize mime_content_type if the function exist. * Get mimetype. Utilises the finfo class.
* Not used at the moment...
*/ */
function get_mimetype($filename) function get_mimetype($filename)
{ {
$mimetype = ''; $finfo = new finfo(FILEINFO_MIME_TYPE);
$mimetype = $finfo->file($filename);
if (function_exists('mime_content_type'))
{
$mimetype = mime_content_type($filename);
}
// Some browsers choke on a mimetype of application/octet-stream // Some browsers choke on a mimetype of application/octet-stream
if (!$mimetype || $mimetype == 'application/octet-stream') if (!$mimetype || $mimetype == 'application/octet-stream')
@ -342,6 +338,7 @@ class filespec
// Remove temporary filename // Remove temporary filename
@unlink($this->filename); @unlink($this->filename);
$this->filename = $this->destination_file;
if (sizeof($this->error)) if (sizeof($this->error))
{ {