makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/14831] Add migration for deduplicating entries and fix typo

Browse source 
PHPBB3-14831
This commit is contained in:
Marc Alexander 2016-10-23 22:00:02 +02:00
parent 9f2867b115
commit c891277996
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
2 changed files with 81 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

78
phpBB/phpbb/db/migration/data/v31x/migrations_deduplicate_entries.php Normal file
View file

@ -0,0 +1,78 @@
<?php
/**
*
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/
namespace phpbb\db\migration\data\v31x;
class migrations_deduplicate_entries extends \phpbb\db\migration\migration
{
static public function depends_on()
{
return array('\phpbb\db\migration\data\v31x\v3110');
}
public function update_data()
{
return array(
array('custom', array(array($this, 'deduplicate_entries'))),
);
}
public function deduplicate_entries()
{
$migration_state = array();
$duplicate_migrations = array();
$sql = "SELECT *
FROM " . $this->table_prefix . 'migrations';
$result = $this->db->sql_query($sql);
if (!$this->db->get_sql_error_triggered())
{
while ($migration = $this->db->sql_fetchrow($result))
{
$migration_state[$migration['migration_name']] = $migration;
$migration_state[$migration['migration_name']]['migration_depends_on'] = unserialize($migration['migration_depends_on']);
$migration_state[$migration['migration_name']]['migration_data_state'] = !empty($migration['migration_data_state']) ? unserialize($migration['migration_data_state']) : '';
}
}
$this->db->sql_freeresult($result);
foreach ($migration_state as $name => $migration)
{
$prepended_name = preg_replace('#^(?!\\\)#', '\\\$0', $name);
$prefixless_name = preg_replace('#(^\\\)([^\\\].+)#', '$2', $name);
if ($prepended_name !== $name && isset($migration_state[$prepended_name]) && $migration_state[$prepended_name] === $migration_state[$name])
{
$duplicate_migrations[] = $name;
unset($migration_state[$prepended_name]);
}
else if ($prefixless_name !== $name && isset($migration_state[$prefixless_name]) && $migration_state[$prefixless_name] === $migration_state[$name])
{
$duplicate_migrations[] = $name;
unset($migration_state[$prefixless_name]);
}
}
if (count($duplicate_migrations))
{
$sql = 'DELETE *
FROM ' . $this->table_prefix . 'migrations
WHERE ' . $this->db->sql_in_set('migration_name', $duplicate_migrations);
$this->db->sql_query($sql);
}
}
}

6
phpBB/phpbb/db/migrator.php
View file

@ -212,12 +212,12 @@ class migrator
// Try falling back to a valid migration name with or without leading backslash // Try falling back to a valid migration name with or without leading backslash
if (!isset($this->migration_state[$name])) if (!isset($this->migration_state[$name]))
{ {
$appended_name = preg_replace('#^(?!\\\)#', '\\\$0', $name); $prepended_name = preg_replace('#^(?!\\\)#', '\\\$0', $name);
$prefixless_name = preg_replace('#(^\\\)([^\\\].+)#', '$2', $name); $prefixless_name = preg_replace('#(^\\\)([^\\\].+)#', '$2', $name);
if (isset($this->migration_state[$appended_name])) if (isset($this->migration_state[$prepended_name]))
{ {
$name = $appended_name; $name = $prepended_name;
} }
else if (isset($this->migration_state[$prefixless_name])) else if (isset($this->migration_state[$prefixless_name]))
{ {