makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 22:28:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10972] Moved tests into appropriate places and added comments

Browse source 
PHPBB3-10972
This commit is contained in:
Fyorl 2012-07-09 00:24:28 +01:00 • committed by Oleg Pudeyev
parent 7005002069
commit cafc7feca1
3 changed files with 13 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tests/functional/auth_test.php
View file

@ -21,6 +21,15 @@ class phpbb_functional_auth_test extends phpbb_functional_test_case
$this->assertContains($this->lang('LOGOUT_USER', 'admin'), $crawler->filter('.navbar')->text()); $this->assertContains($this->lang('LOGOUT_USER', 'admin'), $crawler->filter('.navbar')->text());
} }
public function test_login_other()
{
$this->create_user('user');
$this->login('user');
$crawler = $this->request('GET', 'index.php');
$this->assertContains('user', $crawler->filter('.icon-logout')->text());
$this->delete_user('user');
}
/** /**
* @depends test_login * @depends test_login
*/ */

45
tests/functional/new_user_test.php
View file

@ -1,45 +0,0 @@
<?php
/**
*
* @package testing
* @copyright (c) 2012 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/
/**
* @group functional
*/
class phpbb_functional_new_user_test extends phpbb_functional_test_case
{
public function test_create_user()
{
$this->create_user('user');
$this->login();
$crawler = $this->request('GET', 'memberlist.php?sid=' . $this->sid);
$this->assertContains('user', $crawler->filter('#memberlist tr')->eq(1)->text());
}
/**
* @depends test_create_user
*/
public function test_delete_user()
{
$this->delete_user('user');
$this->login();
$crawler = $this->request('GET', 'memberlist.php?sid=' . $this->sid);
$this->assertEquals(2, $crawler->filter('#memberlist tr')->count());
}
/**
* @depends test_delete_user
*/
public function test_login_other()
{
$this->create_user('user');
$this->login('user');
$crawler = $this->request('GET', 'index.php');
$this->assertContains('user', $crawler->filter('.icon-logout')->text());
$this->delete_user('user');
}
}

4
tests/test_framework/phpbb_functional_test_case.php
View file

@ -197,6 +197,10 @@ class phpbb_functional_test_case extends phpbb_test_case
/** /**
* Creates a new user with limited permissions * Creates a new user with limited permissions
* *
* Note that creating two users with the same name results in undefined
* login behaviour. Always call delete_user after running a test that
* requires create_user.
*
* @param string $username Also doubles up as the user's password * @param string $username Also doubles up as the user's password
*/ */
protected function create_user($username) protected function create_user($username)