makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/17383] Validate php_uname() output too

Browse source 
PHPBB-17383
This commit is contained in:
rxu 2024-08-16 00:30:40 +07:00
parent 6d0a965db2
commit cc4579ee04
No known key found for this signature in database
GPG key ID: 955F0567380E586A
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
phpBB/includes/functions_messenger.php
View file

@ -1418,12 +1418,8 @@ class smtp_class
global $user; global $user;
// Here we try to determine the *real* hostname (reverse DNS entry preferrably) // Here we try to determine the *real* hostname (reverse DNS entry preferrably)
$local_host = $user->host; if (function_exists('php_uname') && !empty($local_host = php_uname('n')))
if (function_exists('php_uname'))
{ {
$local_host = php_uname('n');
// Able to resolve name to IP // Able to resolve name to IP
if (($addr = @gethostbyname($local_host)) !== $local_host) if (($addr = @gethostbyname($local_host)) !== $local_host)
{ {
@ -1434,6 +1430,10 @@ class smtp_class
} }
} }
} }
else
{
$local_host = $user->host;
}
// If we are authenticating through pop-before-smtp, we // If we are authenticating through pop-before-smtp, we
// have to login ones before we get authenticated // have to login ones before we get authenticated