From 55ffcca5916959f0a726172efd0ef091c6b6cece Mon Sep 17 00:00:00 2001 From: Cesar G Date: Tue, 20 May 2014 18:42:03 -0700 Subject: [PATCH 01/16] [ticket/12553] Move Place inline and Delete buttons left of the file name. PHPBB3-12553 --- phpBB/styles/prosilver/theme/bidi.css | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/phpBB/styles/prosilver/theme/bidi.css b/phpBB/styles/prosilver/theme/bidi.css index 78b95d902e..183e9cf1b9 100644 --- a/phpBB/styles/prosilver/theme/bidi.css +++ b/phpBB/styles/prosilver/theme/bidi.css @@ -893,3 +893,11 @@ ul.linklist li.small-icon > a, ul.linklist li.breadcrumbs span:first-child > a { padding-right: 16px; padding-left: 0; } + +/** +* plupload.css +*/ + +.rtl .attach-controls { + float: left; +} From 3ed767351c1af2539024117efe5fcc2b8ec1e275 Mon Sep 17 00:00:00 2001 From: Cesar G Date: Tue, 20 May 2014 18:55:33 -0700 Subject: [PATCH 02/16] [ticket/12553] Align contact icons to the right. PHPBB3-12553 --- phpBB/styles/prosilver/theme/bidi.css | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/phpBB/styles/prosilver/theme/bidi.css b/phpBB/styles/prosilver/theme/bidi.css index 183e9cf1b9..f1098c4685 100644 --- a/phpBB/styles/prosilver/theme/bidi.css +++ b/phpBB/styles/prosilver/theme/bidi.css @@ -602,6 +602,19 @@ ul.linklist li.small-icon > a, ul.linklist li.breadcrumbs span:first-child > a { margin-right: 0; } +/* Poster contact icons + ----------------------------------------*/ +.rtl .contact-icons a { + border-left-width: 1px; + border-left-style: dotted; + border-right: none; + float: right; +} + +.rtl .contact-icons .last-cell { + border-left: none; +} + /** * cp.css */ From ee9fceedff42c4948b9a5ffcda8646ea3fa54db0 Mon Sep 17 00:00:00 2001 From: Cesar G Date: Thu, 29 May 2014 11:02:55 -0700 Subject: [PATCH 03/16] [ticket/12553] Fix links in the last post column that are not clickable. The relative position of the
is causing it to sit atop of the
thus preventing the user from clicking the links. The
has a relative position in LTR, which takes care of containing the read/unread icon link that has an absolute position. We no longer support IE6, so removing the tweak that sets the
position to static will make everything behave the same way in RTL as in LTR. PHPBB3-12553 --- phpBB/styles/prosilver/theme/bidi.css | 8 -------- 1 file changed, 8 deletions(-) diff --git a/phpBB/styles/prosilver/theme/bidi.css b/phpBB/styles/prosilver/theme/bidi.css index f1098c4685..ee1883ea24 100644 --- a/phpBB/styles/prosilver/theme/bidi.css +++ b/phpBB/styles/prosilver/theme/bidi.css @@ -333,10 +333,6 @@ ul.linklist li.small-icon > a, ul.linklist li.breadcrumbs span:first-child > a { margin-left: 80px; } -.rtl ul.topiclist dl { - position: static; /* fix for IE6 */ -} - .rtl ul.topiclist dd { float: right; border-right-width: 1px; @@ -389,10 +385,6 @@ ul.linklist li.small-icon > a, ul.linklist li.breadcrumbs span:first-child > a { padding-right: 45px; /* Space for folder icon */ } -.rtl dl.icon dt { /* fix for topic row icon links */ - position: relative; -} - .rtl dl a.icon-link { /* topic row icon links */ display: inline-block; left: auto; From e539fd53db4435312a7c0fee2f98be0ceff37037 Mon Sep 17 00:00:00 2001 From: Cesar G Date: Thu, 29 May 2014 11:13:24 -0700 Subject: [PATCH 04/16] [ticket/12553] Remove incorrect size for site logo. The logo is displayed standalone, so there is no need to change the padding from the left side to right. PHPBB3-12553 --- phpBB/styles/prosilver/theme/bidi.css | 4 ---- 1 file changed, 4 deletions(-) diff --git a/phpBB/styles/prosilver/theme/bidi.css b/phpBB/styles/prosilver/theme/bidi.css index ee1883ea24..cad84b765c 100644 --- a/phpBB/styles/prosilver/theme/bidi.css +++ b/phpBB/styles/prosilver/theme/bidi.css @@ -870,10 +870,6 @@ ul.linklist li.small-icon > a, ul.linklist li.breadcrumbs span:first-child > a { } /* Former imageset */ -.rtl .imageset.site_logo { - padding-right: 139px; - padding-left: 0; -} .rtl .imageset.forum_link, .rtl .imageset.forum_read, .rtl .imageset.forum_read_locked, .rtl .imageset.forum_read_subforum, .rtl .imageset.forum_unread, .rtl .imageset.forum_unread_locked, .rtl .imageset.forum_unread_subforum, .rtl .imageset.topic_moved, .rtl .imageset.topic_read, .rtl .imageset.topic_read_mine, .rtl .imageset.topic_read_hot, .rtl .imageset.topic_read_hot_mine, .rtl .imageset.topic_read_locked, .rtl .imageset.topic_read_locked_mine, .rtl .imageset.topic_unread, .rtl .imageset.topic_unread_mine, .rtl .imageset.topic_unread_hot, .rtl .imageset.topic_unread_hot_mine, .rtl .imageset.topic_unread_locked, .rtl .imageset.topic_unread_locked_mine, .rtl .imageset.sticky_read, .rtl .imageset.sticky_read_mine, .rtl .imageset.sticky_read_locked, .rtl .imageset.sticky_read_locked_mine, .rtl .imageset.sticky_unread, .rtl .imageset.sticky_unread_mine, .rtl .imageset.sticky_unread_locked, .rtl .imageset.sticky_unread_locked_mine, .rtl .imageset.announce_read, .rtl .imageset.announce_read_mine, .rtl .imageset.announce_read_locked, .rtl .imageset.announce_read_locked_mine, .rtl .imageset.announce_unread, .rtl .imageset.announce_unread_mine, .rtl .imageset.announce_unread_locked, .rtl .imageset.announce_unread_locked_mine, .rtl .imageset.global_read, .rtl .imageset.global_read_mine, .rtl .imageset.global_read_locked, .rtl .imageset.global_read_locked_mine, .rtl .imageset.global_unread, .rtl .imageset.global_unread_mine, .rtl .imageset.global_unread_locked, .rtl .imageset.global_unread_locked_mine, .rtl .imageset.pm_read, .rtl .imageset.pm_unread { padding-right: 27px; padding-left: 0; From 73c2a3f1776f9adbcae603918a411035f745a51f Mon Sep 17 00:00:00 2001 From: Cesar G Date: Thu, 29 May 2014 11:37:28 -0700 Subject: [PATCH 05/16] [ticket/12553] Align alert text to the right. PHPBB3-12553 --- phpBB/adm/style/admin.css | 4 +++- phpBB/adm/style/overall_footer.html | 18 ++++++++++-------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index f23c720add..d646867780 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -209,6 +209,9 @@ li { #page-footer { clear: both; +} + +.copyright { font-size: 0.75em; text-align: center; } @@ -1594,7 +1597,6 @@ input.button1:focus, input.button2:focus { z-index: 50; padding: 25px; padding: 0 25px 20px 25px; - text-align: left; } .phpbb_alert .alert_close { diff --git a/phpBB/adm/style/overall_footer.html b/phpBB/adm/style/overall_footer.html index 0f4589f5d4..deb38c8691 100644 --- a/phpBB/adm/style/overall_footer.html +++ b/phpBB/adm/style/overall_footer.html @@ -5,15 +5,17 @@
- - {CREDIT_LINE} -
{TRANSLATION_INFO} - +
+ + {CREDIT_LINE} +
{TRANSLATION_INFO} + - -
- {DEBUG_OUTPUT} - + +
+ {DEBUG_OUTPUT} + +
 
From c0063a9e2e12c4e4e43b11408f0e1ae1bc4d7ef8 Mon Sep 17 00:00:00 2001 From: Cesar G Date: Thu, 29 May 2014 11:48:31 -0700 Subject: [PATCH 06/16] [ticket/12553] Fix incorrect alignment in ACP responsive tables. PHPBB3-12553 --- phpBB/adm/style/admin.css | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index d646867780..0f22bc100d 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -987,6 +987,10 @@ table.fixed-width-table { margin-bottom: 1px; } + .rtl table.responsive td { + text-align: right !important; + } + table.responsive td.empty { display: none !important; } @@ -1007,6 +1011,10 @@ table.fixed-width-table { box-sizing: border-box; } + .rtl table.responsive.two-columns td { + float: right; + } + table.responsive.two-columns td:nth-child(2n+1) { clear: left; } From def39a670b65a8075ed46afa4956d1d61193a408 Mon Sep 17 00:00:00 2001 From: Cesar G Date: Thu, 29 May 2014 12:09:17 -0700 Subject: [PATCH 07/16] [ticket/12553] Fix alignment of contact icon. PHPBB3-12553 --- phpBB/styles/prosilver/theme/content.css | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/phpBB/styles/prosilver/theme/content.css b/phpBB/styles/prosilver/theme/content.css index 8c1c2c3926..dfc36fc2a4 100644 --- a/phpBB/styles/prosilver/theme/content.css +++ b/phpBB/styles/prosilver/theme/content.css @@ -751,14 +751,16 @@ dd.profile-contact { .profile-contact .dropdown-container { display: inline-block; - text-align: left; - width: 30px; } .profile-contact .icon_contact { vertical-align: middle; } +.profile-contact .dropdown { + margin-right: -14px; +} + .online { background-image: none; background-position: 100% 0; From edd9c0e06405a08efb1e2153b21f71beb1ea4294 Mon Sep 17 00:00:00 2001 From: Cesar G Date: Thu, 29 May 2014 18:07:27 -0700 Subject: [PATCH 08/16] [ticket/12553] Open the notification dropdown to the left. PHPBB3-12553 --- phpBB/assets/javascript/core.js | 58 +++++++++++++------ phpBB/styles/prosilver/template/forum_fn.js | 33 ----------- .../prosilver/template/navbar_header.html | 4 +- .../subsilver2/template/overall_header.html | 9 ++- 4 files changed, 49 insertions(+), 55 deletions(-) diff --git a/phpBB/assets/javascript/core.js b/phpBB/assets/javascript/core.js index 37728864c4..d6f241183f 100644 --- a/phpBB/assets/javascript/core.js +++ b/phpBB/assets/javascript/core.js @@ -873,19 +873,6 @@ phpbb.timezonePreselectSelect = function(forceSelector) { } }; -// Toggle notification list -$('#notification_list_button').click(function(e) { - $('#notification_list').toggle(); - e.preventDefault(); -}); -$('#phpbb').click(function(e) { - var target = $(e.target); - - if (!target.is('#notification_list, #notification_list_button') && !target.parents().is('#notification_list, #notification_list_button')) { - $('#notification_list').hide(); - } -}); - phpbb.ajaxCallbacks = {}; /** @@ -1515,11 +1502,37 @@ phpbb.getFunctionByName = function (functionName) { }; /** -* Apply code editor to all textarea elements with data-bbcode attribute +* Register page dropdowns. */ -$(document).ready(function() { - $('textarea[data-bbcode]').each(function() { - phpbb.applyCodeEditor(this); +phpbb.registerPageDropdowns = function() { + $('body').find('.dropdown-container').each(function() { + var $this = $(this), + trigger = $this.find('.dropdown-trigger:first'), + contents = $this.find('.dropdown'), + options = { + direction: 'auto', + verticalDirection: 'auto' + }, + data; + + if (!trigger.length) { + data = $this.attr('data-dropdown-trigger'); + trigger = data ? $this.children(data) : $this.children('a:first'); + } + + if (!contents.length) { + data = $this.attr('data-dropdown-contents'); + contents = data ? $this.children(data) : $this.children('div:first'); + } + + if (!trigger.length || !contents.length) return; + + if ($this.hasClass('dropdown-up')) options.verticalDirection = 'up'; + if ($this.hasClass('dropdown-down')) options.verticalDirection = 'down'; + if ($this.hasClass('dropdown-left')) options.direction = 'left'; + if ($this.hasClass('dropdown-right')) options.direction = 'right'; + + phpbb.registerDropdown(trigger, contents, options); }); // Hide active dropdowns when click event happens outside @@ -1529,6 +1542,17 @@ $(document).ready(function() { $(phpbb.dropdownHandles).each(phpbb.toggleDropdown); } }); +} + +/** +* Apply code editor to all textarea elements with data-bbcode attribute +*/ +$(document).ready(function() { + $('textarea[data-bbcode]').each(function() { + phpbb.applyCodeEditor(this); + }); + + phpbb.registerPageDropdowns(); $('#color_palette_placeholder').each(function() { phpbb.registerPalette($(this)); diff --git a/phpBB/styles/prosilver/template/forum_fn.js b/phpBB/styles/prosilver/template/forum_fn.js index fa838fde19..9d4417154f 100644 --- a/phpBB/styles/prosilver/template/forum_fn.js +++ b/phpBB/styles/prosilver/template/forum_fn.js @@ -367,39 +367,6 @@ function parse_document(container) jumpto($(this)); }); - /** - * Dropdowns - */ - container.find('.dropdown-container').each(function() { - var $this = $(this), - trigger = $this.find('.dropdown-trigger:first'), - contents = $this.find('.dropdown'), - options = { - direction: 'auto', - verticalDirection: 'auto' - }, - data; - - if (!trigger.length) { - data = $this.attr('data-dropdown-trigger'); - trigger = data ? $this.children(data) : $this.children('a:first'); - } - - if (!contents.length) { - data = $this.attr('data-dropdown-contents'); - contents = data ? $this.children(data) : $this.children('div:first'); - } - - if (!trigger.length || !contents.length) return; - - if ($this.hasClass('dropdown-up')) options.verticalDirection = 'up'; - if ($this.hasClass('dropdown-down')) options.verticalDirection = 'down'; - if ($this.hasClass('dropdown-left')) options.direction = 'left'; - if ($this.hasClass('dropdown-right')) options.direction = 'right'; - - phpbb.registerDropdown(trigger, contents, options); - }); - /** * Adjust HTML code for IE8 and older versions */ diff --git a/phpBB/styles/prosilver/template/navbar_header.html b/phpBB/styles/prosilver/template/navbar_header.html index 804fa5b2aa..1eb120ef3e 100644 --- a/phpBB/styles/prosilver/template/navbar_header.html +++ b/phpBB/styles/prosilver/template/navbar_header.html @@ -17,8 +17,8 @@
    -
  • - {L_NOTIFICATIONS} [{NOTIFICATIONS_COUNT}] +
  • + {L_NOTIFICATIONS} [{NOTIFICATIONS_COUNT}]
    • diff --git a/phpBB/styles/subsilver2/template/overall_header.html b/phpBB/styles/subsilver2/template/overall_header.html index 314e284155..d4cce2e2ae 100644 --- a/phpBB/styles/subsilver2/template/overall_header.html +++ b/phpBB/styles/subsilver2/template/overall_header.html @@ -156,10 +156,13 @@ function marklist(id, name, state)