makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-12 06:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/9657] Correctly use " vs ' and variables in queries

Browse source 
PHPBB3-9657
This commit is contained in:
Joas Schilling 2013-07-11 11:52:12 +02:00
parent bdb7ec0ceb
commit cdb13fc7be
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
phpBB/includes/content_visibility.php
View file

@ -126,11 +126,11 @@ class phpbb_content_visibility
else else
{ {
// The user is just a normal user // The user is just a normal user
return "$table_alias{$mode}_visibility = " . ITEM_APPROVED . ' return $table_alias . $mode . '_visibility = ' . ITEM_APPROVED . '
AND ' . $db->sql_in_set($table_alias . 'forum_id', $forum_ids, false, true); AND ' . $db->sql_in_set($table_alias . 'forum_id', $forum_ids, false, true);
} }
$where_sql .= "($table_alias{$mode}_visibility = " . ITEM_APPROVED . ' $where_sql .= '(' . $table_alias . $mode . '_visibility = ' . ITEM_APPROVED . '
AND ' . $db->sql_in_set($table_alias . 'forum_id', $forum_ids) . '))'; AND ' . $db->sql_in_set($table_alias . 'forum_id', $forum_ids) . '))';
return $where_sql; return $where_sql;
@ -157,12 +157,12 @@ class phpbb_content_visibility
if (sizeof($exclude_forum_ids)) if (sizeof($exclude_forum_ids))
{ {
$where_sqls[] = '(' . $db->sql_in_set($table_alias . 'forum_id', $exclude_forum_ids, true) . " $where_sqls[] = '(' . $db->sql_in_set($table_alias . 'forum_id', $exclude_forum_ids, true) . '
AND $table_alias{$mode}_visibility = " . ITEM_APPROVED . ')'; AND ' . $table_alias . $mode . '_visibility = ' . ITEM_APPROVED . ')';
} }
else else
{ {
$where_sqls[] = "$table_alias{$mode}_visibility = " . ITEM_APPROVED; $where_sqls[] = $table_alias . $mode . '_visibility = ' . ITEM_APPROVED;
} }
if (sizeof($approve_forums)) if (sizeof($approve_forums))