makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Bug #58085 - Add terminating semicolons to JavaScript code found by JSLint. Patch by nn-

Browse source 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10539 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Andreas Fischer 2010-02-25 10:51:35 +00:00
parent e57981d1f5
commit cdc96b0c7d
4 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
phpBB/adm/style/editor.js
View file

@ -152,7 +152,7 @@ function insert_text(text, spaces, popup)
var sel_start = textarea.selectionStart; var sel_start = textarea.selectionStart;
var sel_end = textarea.selectionEnd; var sel_end = textarea.selectionEnd;
mozWrap(textarea, text, '') mozWrap(textarea, text, '');
textarea.selectionStart = sel_start + text.length; textarea.selectionStart = sel_start + text.length;
textarea.selectionEnd = sel_end + text.length; textarea.selectionEnd = sel_end + text.length;
} }
@ -269,7 +269,7 @@ function mozWrap(txtarea, open, close)
} }
var s1 = (txtarea.value).substring(0,selStart); var s1 = (txtarea.value).substring(0,selStart);
var s2 = (txtarea.value).substring(selStart, selEnd) var s2 = (txtarea.value).substring(selStart, selEnd);
var s3 = (txtarea.value).substring(selEnd, selLength); var s3 = (txtarea.value).substring(selEnd, selLength);
txtarea.value = s1 + open + s2 + close + s3; txtarea.value = s1 + open + s2 + close + s3;

1
phpBB/docs/CHANGELOG.html
View file

@ -96,6 +96,7 @@
<li>[Fix] Honor minimum and maximum password length in generated passwords as much as we can. (Bug #13181)</li> <li>[Fix] Honor minimum and maximum password length in generated passwords as much as we can. (Bug #13181)</li>
<li>[Fix] No longer return the character O in generated random strings and passwords. (Bug #57345)</li> <li>[Fix] No longer return the character O in generated random strings and passwords. (Bug #57345)</li>
<li>[Fix] Allow redirect() function to redirect across directories. (Bug #56965)</li> <li>[Fix] Allow redirect() function to redirect across directories. (Bug #56965)</li>
<li>[Fix] Add terminating semicolons to JavaScript code. (Bug #58085 - Patch by nn-)</li>
<li>[Feature] Support for Microsoft's Native SQL Server Driver for PHP (Bug #57055 - Patch by Chris Pucci at Microsoft)</li> <li>[Feature] Support for Microsoft's Native SQL Server Driver for PHP (Bug #57055 - Patch by Chris Pucci at Microsoft)</li>
</ul> </ul>

10
phpBB/styles/prosilver/template/editor.js
View file

@ -157,7 +157,7 @@ function insert_text(text, spaces, popup)
var sel_start = textarea.selectionStart; var sel_start = textarea.selectionStart;
var sel_end = textarea.selectionEnd; var sel_end = textarea.selectionEnd;
mozWrap(textarea, text, '') mozWrap(textarea, text, '');
textarea.selectionStart = sel_start + text.length; textarea.selectionStart = sel_start + text.length;
textarea.selectionEnd = sel_end + text.length; textarea.selectionEnd = sel_end + text.length;
} }
@ -259,7 +259,7 @@ function addquote(post_id, username)
var lines = split_lines(theSelection); var lines = split_lines(theSelection);
for (i = 0; i < lines.length; i++) for (i = 0; i < lines.length; i++)
{ {
insert_text('> ' + lines[i] + '\n') insert_text('> ' + lines[i] + '\n');
} }
} }
} }
@ -289,7 +289,7 @@ function split_lines(text)
if (splitAt == -1) if (splitAt == -1)
{ {
splitLines[j] = line; splitLines[j] = line;
j++ j++;
} }
else else
{ {
@ -298,7 +298,7 @@ function split_lines(text)
j++; j++;
} }
} }
while(splitAt != -1) while(splitAt != -1);
} }
} }
return splitLines; return splitLines;
@ -319,7 +319,7 @@ function mozWrap(txtarea, open, close)
} }
var s1 = (txtarea.value).substring(0,selStart); var s1 = (txtarea.value).substring(0,selStart);
var s2 = (txtarea.value).substring(selStart, selEnd) var s2 = (txtarea.value).substring(selStart, selEnd);
var s3 = (txtarea.value).substring(selEnd, selLength); var s3 = (txtarea.value).substring(selEnd, selLength);
txtarea.value = s1 + open + s2 + close + s3; txtarea.value = s1 + open + s2 + close + s3;

4
phpBB/styles/subsilver2/template/editor.js
View file

@ -156,7 +156,7 @@ function insert_text(text, spaces, popup)
var sel_start = textarea.selectionStart; var sel_start = textarea.selectionStart;
var sel_end = textarea.selectionEnd; var sel_end = textarea.selectionEnd;
mozWrap(textarea, text, '') mozWrap(textarea, text, '');
textarea.selectionStart = sel_start + text.length; textarea.selectionStart = sel_start + text.length;
textarea.selectionEnd = sel_end + text.length; textarea.selectionEnd = sel_end + text.length;
} }
@ -272,7 +272,7 @@ function mozWrap(txtarea, open, close)
} }
var s1 = (txtarea.value).substring(0,selStart); var s1 = (txtarea.value).substring(0,selStart);
var s2 = (txtarea.value).substring(selStart, selEnd) var s2 = (txtarea.value).substring(selStart, selEnd);
var s3 = (txtarea.value).substring(selEnd, selLength); var s3 = (txtarea.value).substring(selEnd, selLength);
txtarea.value = s1 + open + s2 + close + s3; txtarea.value = s1 + open + s2 + close + s3;