[ticket/16748] Enable code sniffing for static placement and adjust code

PHPBB3-16748

build/code_sniffer/phpbb/Sniffs/ControlStructures/StaticKeywordSniff.php

@@ -51,7 +51,7 @@ class phpbb_Sniffs_ControlStructures_StaticKeywordSniff implements Sniff
 		if (in_array($tokens[$stackPtr + 2]['code'], $disallowed_after_tokens))
 		{
 			$error = 'Access specifier (e.g. public) should not follow static scope attribute. Encountered "' . $tokens[$stackPtr + 2]['content'] . '" after static';
-			$phpcsFile->addWarning($error, $stackPtr, 'InvalidStaticFunctionDeclaration', [], 1);
+			$phpcsFile->addError($error, $stackPtr, 'InvalidStaticFunctionDeclaration');
 		}
 	}
 }

phpBB/includes/functions_compress.php

@@ -164,7 +164,7 @@ class compress
 	*
 	* @return array Array of strings of available compression methods (.tar, .tar.gz, .zip, etc.)
 	*/
-	static public function methods()
+	public static function methods()
 	{
 		$methods = array('.tar');
 		$available_methods = array('.tar.gz' => 'zlib', '.tar.bz2' => 'bz2', '.zip' => 'zlib');

phpBB/includes/functions_jabber.php

@@ -101,7 +101,7 @@ class jabber
 	/**
 	* Able to use the SSL functionality?
 	*/
-	static public function can_use_ssl()
+	public static function can_use_ssl()
 	{
 		return @extension_loaded('openssl');
 	}
@@ -109,7 +109,7 @@ class jabber
 	/**
 	* Able to use TLS?
 	*/
-	static public function can_use_tls()
+	public static function can_use_tls()
 	{
 		if (!@extension_loaded('openssl') || !function_exists('stream_socket_enable_crypto') || !function_exists('stream_get_meta_data') || !function_exists('stream_set_blocking') || !function_exists('stream_get_wrappers'))
 		{

phpBB/includes/functions_transfer.php

@@ -237,7 +237,7 @@ class transfer
 	/**
 	* Determine methods able to be used
 	*/
-	static public function methods()
+	public static function methods()
 	{
 		$methods = array();
 		$disabled_functions = explode(',', @ini_get('disable_functions'));
@@ -289,7 +289,7 @@ class ftp extends transfer
 	/**
 	* Requests data
 	*/
-	static public function data()
+	public static function data()
 	{
 		global $user;
 
@@ -537,7 +537,7 @@ class ftp_fsock extends transfer
 	/**
 	* Requests data
 	*/
-	static public function data()
+	public static function data()
 	{
 		global $user;
 

phpBB/includes/mcp/mcp_queue.php

@@ -689,7 +689,7 @@ class mcp_queue
 	* @param $mode			string	Active module
 	* @return null
 	*/
-	static public function approve_posts($action, $post_id_list, $id, $mode)
+	public static function approve_posts($action, $post_id_list, $id, $mode)
 	{
 		global $template, $user, $request, $phpbb_container, $phpbb_dispatcher;
 		global $phpEx, $phpbb_root_path, $phpbb_log;
@@ -945,7 +945,7 @@ class mcp_queue
 	* @param $mode			string	Active module
 	* @return null
 	*/
-	static public function approve_topics($action, $topic_id_list, $id, $mode)
+	public static function approve_topics($action, $topic_id_list, $id, $mode)
 	{
 		global $db, $template, $user, $phpbb_log;
 		global $phpEx, $phpbb_root_path, $request, $phpbb_container, $phpbb_dispatcher;
@@ -1143,7 +1143,7 @@ class mcp_queue
 	* @param $mode			string	Active module
 	* @return null
 	*/
-	static public function disapprove_posts($post_id_list, $id, $mode)
+	public static function disapprove_posts($post_id_list, $id, $mode)
 	{
 		global $db, $template, $user, $phpbb_container, $phpbb_dispatcher;
 		global $phpEx, $phpbb_root_path, $request, $phpbb_log;

phpBB/phpbb/avatar/manager.php

@@ -31,7 +31,7 @@ class manager
 	* Array that contains a list of enabled drivers
 	* @var array|bool
 	*/
-	static protected $enabled_drivers = false;
+	protected static $enabled_drivers = false;
 
 	/**
 	* Array that contains all available avatar drivers which are passed via the
@@ -44,7 +44,7 @@ class manager
 	* Default avatar data row
 	* @var array
 	*/
-	static protected $default_row = array(
+	protected static $default_row = array(
 		'avatar'		=> '',
 		'avatar_type'	=> '',
 		'avatar_width'	=> 0,
@@ -196,7 +196,7 @@ class manager
 	*			stripped from the preceding "user_" or "group_"
 	*			Also the group id is prefixed with g, when the prefix group is removed.
 	*/
-	static public function clean_row($row, $prefix = '')
+	public static function clean_row($row, $prefix = '')
 	{
 		// Upon creation of a user/group $row might be empty
 		if (empty($row))
@@ -227,7 +227,7 @@ class manager
 	*
 	* @return string Cleaned driver name
 	*/
-	static public function clean_driver_name($name)
+	public static function clean_driver_name($name)
 	{
 		return str_replace(array('\\', '_'), '.', $name);
 	}
@@ -240,7 +240,7 @@ class manager
 	*
 	* @return string Prepared driver name
 	*/
-	static public function prepare_driver_name($name)
+	public static function prepare_driver_name($name)
 	{
 		return str_replace('.', '_', $name);
 	}

phpBB/phpbb/captcha/plugins/qa.php

@@ -177,7 +177,7 @@ class qa
 	/**
 	*  API function
 	*/
-	static public function get_name()
+	public static function get_name()
 	{
 		return 'CAPTCHA_QA';
 	}

phpBB/phpbb/captcha/plugins/recaptcha.php

@@ -53,7 +53,7 @@ class recaptcha extends captcha_abstract
 		return true;
 	}
 
-	static public function get_name()
+	public static function get_name()
 	{
 		return 'CAPTCHA_RECAPTCHA';
 	}

phpBB/phpbb/captcha/plugins/recaptcha_v3.php

@@ -32,7 +32,7 @@ class recaptcha_v3 extends captcha_abstract
 	const RECAPTCHA		= 'recaptcha.net';
 
 	/** @var array CAPTCHA types mapped to their action */
-	static protected $actions = [
+	protected static $actions = [
 		0				=> 'default',
 		CONFIRM_REG		=> 'register',
 		CONFIRM_LOGIN	=> 'login',
@@ -46,7 +46,7 @@ class recaptcha_v3 extends captcha_abstract
 	 * @static
 	 * @return array
 	 */
-	static public function get_actions()
+	public static function get_actions()
 	{
 		return self::$actions;
 	}

phpBB/phpbb/composer/io/html_output_formatter.php

@@ -15,7 +15,7 @@ namespace phpbb\composer\io;
 
 class html_output_formatter extends \Composer\Console\HtmlOutputFormatter
 {
-	static protected $availableForegroundColors = [
+	protected static $availableForegroundColors = [
 			30 => 'black',
 			31 => 'red',
 			32 => 'green',
@@ -26,7 +26,7 @@ class html_output_formatter extends \Composer\Console\HtmlOutputFormatter
 			37 => 'white',
 		];
 
-	static protected $availableBackgroundColors = [
+	protected static $availableBackgroundColors = [
 			40 => 'black',
 			41 => 'red',
 			42 => 'green',
@@ -37,7 +37,7 @@ class html_output_formatter extends \Composer\Console\HtmlOutputFormatter
 			47 => 'white',
 		];
 
-	static protected $availableOptions
+	protected static $availableOptions
 		= [
 			1 => 'bold',
 			4 => 'underscore',

phpBB/phpbb/config_php_file.php

@@ -121,7 +121,7 @@ class config_php_file
 	* @return string driver class
 	* @throws \RuntimeException
 	*/
-	static public function convert_30_dbms_to_31($dbms)
+	public static function convert_30_dbms_to_31($dbms)
 	{
 		// Note: this check is done first because mysqli extension
 		// supplies a mysqli class, and class_exists($dbms) would return

phpBB/phpbb/console/exception_subscriber.php

@@ -60,7 +60,7 @@ class exception_subscriber implements EventSubscriberInterface
 		}
 	}
 
-	static public function getSubscribedEvents()
+	public static function getSubscribedEvents()
 	{
 		return [
 			ConsoleEvents::ERROR => 'on_error',

phpBB/phpbb/cron/event/cron_runner_listener.php

@@ -94,7 +94,7 @@ class cron_runner_listener implements EventSubscriberInterface
 	/**
 	 * {@inheritdoc}
 	 */
-	static public function getSubscribedEvents()
+	public static function getSubscribedEvents()
 	{
 		return array(
 			KernelEvents::TERMINATE		=> 'on_kernel_terminate',

phpBB/phpbb/datetime.php

@@ -32,7 +32,7 @@ class datetime extends \DateTime
 	/**
 	* @var array Date formats are preprocessed by phpBB, to save constant recalculation they are cached.
 	*/
-	static protected $format_cache = array();
+	protected static $format_cache = array();
 
 	/**
 	* Constructs a new instance of \phpbb\datetime, expanded to include an argument to inject
@@ -143,7 +143,7 @@ class datetime extends \DateTime
 	* @param user $user User object to use for localisation
 	* @return array Processed date format
 	*/
-	static protected function format_cache($format, $user)
+	protected static function format_cache($format, $user)
 	{
 		$lang = $user->lang_name;
 

phpBB/phpbb/db/doctrine/connection_factory.php

@@ -37,7 +37,7 @@ class connection_factory
 	 * @throws runtime_exception		If the database connection could not be established.
 	 * @throws InvalidArgumentException	If the provided driver name is not a valid phpBB database driver.
 	 */
-	static public function get_connection(config_php_file $config) : Connection
+	public static function get_connection(config_php_file $config) : Connection
 	{
 		$driver = $config->get('dbms');
 		$host = $config->get('dbhost');
@@ -71,7 +71,7 @@ class connection_factory
 	 * @throws runtime_exception		If the database connection could not be established.
 	 * @throws InvalidArgumentException	If $driver is not a valid phpBB database driver.
 	 */
-	static public function get_connection_from_params(
+	public static function get_connection_from_params(
 		string $driver,
 		string $host,
 		?string $user = null,

phpBB/phpbb/db/doctrine/connection_parameter_factory.php

@@ -34,7 +34,7 @@ class connection_parameter_factory
 	 *
 	 * @throws InvalidArgumentException If a required parameter is empty or null.
 	 */
-	static public function get_configuration(
+	public static function get_configuration(
 		string $driver,
 		string $host,
 		?string $user = null,
@@ -70,7 +70,7 @@ class connection_parameter_factory
 	 *
 	 * @throws InvalidArgumentException If a required parameter is empty or null.
 	 */
-	static private function build_connection_parameters(
+	private static function build_connection_parameters(
 		array $params,
 		string $host,
 		?string $user = null,
@@ -119,7 +119,7 @@ class connection_parameter_factory
 	 *
 	 * @return array Doctrine's DBAL configuration for SQLite.
 	 */
-	static private function build_sqlite_parameters(array $params, string $path, ?string $user, ?string $password) : array
+	private static function build_sqlite_parameters(array $params, string $path, ?string $user, ?string $password) : array
 	{
 		$params['path'] = $path;
 
@@ -143,7 +143,7 @@ class connection_parameter_factory
 	 *
 	 * @return array The enriched parameter list.
 	 */
-	static private function enrich_parameters(array $params) : array
+	private static function enrich_parameters(array $params) : array
 	{
 		$enrichment_tags = [
 			'pdo_mysql' => [

phpBB/phpbb/db/doctrine/driver_convertor.php

@@ -29,7 +29,7 @@ trait driver_convertor
 	 *
 	 * @throws InvalidArgumentException If $driver_name is not a valid phpBB database driver.
 	 */
-	static public function to_doctrine_driver(string $driver_name) : string
+	public static function to_doctrine_driver(string $driver_name) : string
 	{
 		// Normalize driver name.
 		$name = str_replace('phpbb\db\driver', '', $driver_name);

phpBB/phpbb/db/migration/data/v30x/local_url_bbcode.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v30x;
 
 class local_url_bbcode extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_12_rc1');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_1.php

@@ -20,7 +20,7 @@ class release_3_0_1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_1_rc1');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_10.php

@@ -20,7 +20,7 @@ class release_3_0_10 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.10', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_10_rc3');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_10_rc1.php

@@ -20,7 +20,7 @@ class release_3_0_10_rc1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.10-RC1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_9');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_10_rc2.php

@@ -20,7 +20,7 @@ class release_3_0_10_rc2 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.10-RC2', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_10_rc1');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_11.php

@@ -20,7 +20,7 @@ class release_3_0_11 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.11', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_11_rc2');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_11_rc1.php

@@ -20,7 +20,7 @@ class release_3_0_11_rc1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.11-RC1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_10');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_11_rc2.php

@@ -20,7 +20,7 @@ class release_3_0_11_rc2 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.11-RC2', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_11_rc1');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_12.php

@@ -20,7 +20,7 @@ class release_3_0_12 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.12', '>=') && phpbb_version_compare($this->config['version'], '3.1.0-dev', '<');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_12_rc3');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_12_rc1.php

@@ -22,7 +22,7 @@ class release_3_0_12_rc1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.12-RC1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_11');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_13_pl1.php

@@ -20,7 +20,7 @@ class release_3_0_13_pl1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.13-PL1', '>=') && phpbb_version_compare($this->config['version'], '3.1.0-dev', '<');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_13');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_13_rc1.php

@@ -20,7 +20,7 @@ class release_3_0_13_rc1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.13-RC1', '>=') && phpbb_version_compare($this->config['version'], '3.1.0-dev', '<');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_12');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_14.php

@@ -20,7 +20,7 @@ class release_3_0_14 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.14', '>=') && phpbb_version_compare($this->config['version'], '3.1.0-dev', '<');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_14_rc1');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_14_rc1.php

@@ -20,7 +20,7 @@ class release_3_0_14_rc1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.14-RC1', '>=') && phpbb_version_compare($this->config['version'], '3.1.0-dev', '<');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_13');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_1_rc1.php

@@ -20,7 +20,7 @@ class release_3_0_1_rc1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.1-RC1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_0');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_2.php

@@ -20,7 +20,7 @@ class release_3_0_2 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.2', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_2_rc2');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_3.php

@@ -20,7 +20,7 @@ class release_3_0_3 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.3', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_3_rc1');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_3_rc1.php

@@ -20,7 +20,7 @@ class release_3_0_3_rc1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.3-RC1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_2');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_4_rc1.php

@@ -20,7 +20,7 @@ class release_3_0_4_rc1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.4-RC1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_3');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_5_rc1part2.php

@@ -20,7 +20,7 @@ class release_3_0_5_rc1part2 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.5-RC1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_5_rc1');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_6_rc1.php

@@ -20,7 +20,7 @@ class release_3_0_6_rc1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.6-RC1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_5');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_6_rc2.php

@@ -20,7 +20,7 @@ class release_3_0_6_rc2 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.6-RC2', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_6_rc1');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_6_rc4.php

@@ -20,7 +20,7 @@ class release_3_0_6_rc4 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.6-RC4', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_6_rc3');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_7.php

@@ -20,7 +20,7 @@ class release_3_0_7 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.7', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_7_rc2');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_7_rc1.php

@@ -20,7 +20,7 @@ class release_3_0_7_rc1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.7-RC1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_6');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_7_rc2.php

@@ -20,7 +20,7 @@ class release_3_0_7_rc2 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.7-RC2', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_7_rc1');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_8_rc1.php

@@ -20,7 +20,7 @@ class release_3_0_8_rc1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.8-RC1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_7_pl1');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_9_rc1.php

@@ -20,7 +20,7 @@ class release_3_0_9_rc1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.9-RC1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_8');
 	}

phpBB/phpbb/db/migration/data/v30x/release_3_0_9_rc3.php

@@ -20,7 +20,7 @@ class release_3_0_9_rc3 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.0.9-RC3', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_9_rc2');
 	}

phpBB/phpbb/db/migration/data/v310/acp_prune_users_module.php

@@ -39,7 +39,7 @@ class acp_prune_users_module extends \phpbb\db\migration\container_aware_migrati
 		return !$acp_cat_users_id || $acp_cat_users_id === $acp_prune_users_parent;
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\beta1');
 	}

phpBB/phpbb/db/migration/data/v310/acp_style_components_module.php

@@ -28,7 +28,7 @@ class acp_style_components_module extends \phpbb\db\migration\migration
 		return $module_id == false;
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\dev');
 	}

phpBB/phpbb/db/migration/data/v310/allow_cdn.php

@@ -20,7 +20,7 @@ class allow_cdn extends \phpbb\db\migration\migration
 		return isset($this->config['allow_cdn']);
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\jquery_update',

phpBB/phpbb/db/migration/data/v310/alpha1.php

@@ -20,7 +20,7 @@ class alpha1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.1.0-a1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v30x\local_url_bbcode',

phpBB/phpbb/db/migration/data/v310/alpha2.php

@@ -20,7 +20,7 @@ class alpha2 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.1.0-a2', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\alpha1',

phpBB/phpbb/db/migration/data/v310/alpha3.php

@@ -20,7 +20,7 @@ class alpha3 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.1.0-a3', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\alpha2',

phpBB/phpbb/db/migration/data/v310/auth_provider_oauth.php

@@ -20,7 +20,7 @@ class auth_provider_oauth extends \phpbb\db\migration\migration
 		return $this->db_tools->sql_table_exists($this->table_prefix . 'oauth_tokens');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_0');
 	}

phpBB/phpbb/db/migration/data/v310/auth_provider_oauth2.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class auth_provider_oauth2 extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\auth_provider_oauth',

phpBB/phpbb/db/migration/data/v310/avatar_types.php

@@ -24,7 +24,7 @@ class avatar_types extends \phpbb\db\migration\migration
 		AVATAR_GALLERY	=> 'avatar.driver.local',
 	);
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\dev',

phpBB/phpbb/db/migration/data/v310/avatars.php

@@ -42,7 +42,7 @@ class avatars extends \phpbb\db\migration\migration
 		return $effectively_installed !== false;
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_11');
 	}

phpBB/phpbb/db/migration/data/v310/beta1.php

@@ -20,7 +20,7 @@ class beta1 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.1.0-b1', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\alpha3',

phpBB/phpbb/db/migration/data/v310/beta2.php

@@ -20,7 +20,7 @@ class beta2 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.1.0-b2', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\beta1',

phpBB/phpbb/db/migration/data/v310/beta3.php

@@ -20,7 +20,7 @@ class beta3 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.1.0-b3', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\beta2',

phpBB/phpbb/db/migration/data/v310/beta4.php

@@ -20,7 +20,7 @@ class beta4 extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.1.0-b4', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\beta3',

phpBB/phpbb/db/migration/data/v310/board_contact_name.php

@@ -20,7 +20,7 @@ class board_contact_name extends \phpbb\db\migration\migration
 		return isset($this->config['board_contact_name']);
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\beta2');
 	}

phpBB/phpbb/db/migration/data/v310/bot_update.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class bot_update extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\rc6');
 	}

phpBB/phpbb/db/migration/data/v310/captcha_plugins.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class captcha_plugins extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\rc2',

phpBB/phpbb/db/migration/data/v310/config_db_text.php

@@ -20,7 +20,7 @@ class config_db_text extends \phpbb\db\migration\migration
 		return $this->db_tools->sql_table_exists($this->table_prefix . 'config_text');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_11');
 	}

phpBB/phpbb/db/migration/data/v310/contact_admin_form.php

@@ -20,7 +20,7 @@ class contact_admin_form extends \phpbb\db\migration\migration
 		return isset($this->config['contact_admin_form_enable']);
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\config_db_text');
 	}

phpBB/phpbb/db/migration/data/v310/dev.php

@@ -20,7 +20,7 @@ class dev extends \phpbb\db\migration\container_aware_migration
 		return version_compare($this->config['version'], '3.1.0-dev', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\extensions',

phpBB/phpbb/db/migration/data/v310/extensions.php

@@ -20,7 +20,7 @@ class extensions extends \phpbb\db\migration\migration
 		return $this->db_tools->sql_table_exists($this->table_prefix . 'ext');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_11');
 	}

phpBB/phpbb/db/migration/data/v310/extensions_version_check_force_unstable.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class extensions_version_check_force_unstable extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\dev');
 	}

phpBB/phpbb/db/migration/data/v310/forgot_password.php

@@ -20,7 +20,7 @@ class forgot_password extends \phpbb\db\migration\migration
 		return isset($this->config['allow_password_reset']);
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_11');
 	}

phpBB/phpbb/db/migration/data/v310/gold.php

@@ -20,7 +20,7 @@ class gold extends \phpbb\db\migration\migration
 		return phpbb_version_compare($this->config['version'], '3.1.0', '>=');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\rc6',

phpBB/phpbb/db/migration/data/v310/jquery_update.php

@@ -20,7 +20,7 @@ class jquery_update extends \phpbb\db\migration\migration
 		return $this->config['load_jquery_url'] !== '//ajax.googleapis.com/ajax/libs/jquery/1.6.2/jquery.min.js';
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\dev',

phpBB/phpbb/db/migration/data/v310/jquery_update2.php

@@ -20,7 +20,7 @@ class jquery_update2 extends \phpbb\db\migration\migration
 		return $this->config['load_jquery_url'] !== '//ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js';
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\jquery_update',

phpBB/phpbb/db/migration/data/v310/mod_rewrite.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class mod_rewrite extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\dev',

phpBB/phpbb/db/migration/data/v310/mysql_fulltext_drop.php

@@ -29,7 +29,7 @@ class mysql_fulltext_drop extends \phpbb\db\migration\migration
 		return empty($this->indexes);
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\dev',

phpBB/phpbb/db/migration/data/v310/namespaces.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class namespaces extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\dev',

phpBB/phpbb/db/migration/data/v310/notification_options_reconvert.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class notification_options_reconvert extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\notifications_schema_fix');
 	}

phpBB/phpbb/db/migration/data/v310/notifications.php

@@ -20,7 +20,7 @@ class notifications extends \phpbb\db\migration\migration
 		return $this->db_tools->sql_table_exists($this->table_prefix . 'notifications');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\dev');
 	}

phpBB/phpbb/db/migration/data/v310/notifications_cron.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class notifications_cron extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\notifications');
 	}

phpBB/phpbb/db/migration/data/v310/notifications_cron_p2.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class notifications_cron_p2 extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\notifications_cron');
 	}

phpBB/phpbb/db/migration/data/v310/notifications_schema_fix.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class notifications_schema_fix extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\notifications');
 	}

phpBB/phpbb/db/migration/data/v310/notifications_use_full_name.php

@@ -40,7 +40,7 @@ class notifications_use_full_name extends \phpbb\db\migration\migration
 		'jabber',
 	);
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\rc3');
 	}

phpBB/phpbb/db/migration/data/v310/passwords.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class passwords extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v30x\release_3_0_11');
 	}

phpBB/phpbb/db/migration/data/v310/passwords_convert_p1.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class passwords_convert_p1 extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\passwords_p2');
 	}

phpBB/phpbb/db/migration/data/v310/passwords_convert_p2.php

@@ -20,7 +20,7 @@ class passwords_convert_p2 extends \phpbb\db\migration\migration
 		return !$this->db_tools->sql_column_exists($this->table_prefix . 'users', 'user_pass_convert');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\passwords_convert_p1');
 	}

phpBB/phpbb/db/migration/data/v310/passwords_p2.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class passwords_p2 extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\passwords');
 	}

phpBB/phpbb/db/migration/data/v310/plupload.php

@@ -21,7 +21,7 @@ class plupload extends \phpbb\db\migration\migration
 			isset($this->config['plupload_salt']);
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array('\phpbb\db\migration\data\v310\dev');
 	}

phpBB/phpbb/db/migration/data/v310/postgres_fulltext_drop.php

@@ -29,7 +29,7 @@ class postgres_fulltext_drop extends \phpbb\db\migration\migration
 		return empty($this->indexes);
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\dev',

phpBB/phpbb/db/migration/data/v310/profilefield_aol.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class profilefield_aol extends \phpbb\db\migration\profilefield_base_migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\profilefield_yahoo_cleanup',

phpBB/phpbb/db/migration/data/v310/profilefield_aol_cleanup.php

@@ -20,7 +20,7 @@ class profilefield_aol_cleanup extends \phpbb\db\migration\migration
 		return !$this->db_tools->sql_column_exists($this->table_prefix . 'users', 'user_aim');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\profilefield_aol',

phpBB/phpbb/db/migration/data/v310/profilefield_change_load_settings.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class profilefield_change_load_settings extends \phpbb\db\migration\migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\profilefield_aol_cleanup',

phpBB/phpbb/db/migration/data/v310/profilefield_cleanup.php

@@ -21,7 +21,7 @@ class profilefield_cleanup extends \phpbb\db\migration\migration
 			!$this->db_tools->sql_column_exists($this->table_prefix . 'users', 'user_interests');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\profilefield_interests',

phpBB/phpbb/db/migration/data/v310/profilefield_contact_field.php

@@ -20,7 +20,7 @@ class profilefield_contact_field extends \phpbb\db\migration\migration
 		return $this->db_tools->sql_column_exists($this->table_prefix . 'profile_fields', 'field_is_contact');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\profilefield_on_memberlist',

phpBB/phpbb/db/migration/data/v310/profilefield_facebook.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class profilefield_facebook extends \phpbb\db\migration\profilefield_base_migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\profilefield_contact_field',

phpBB/phpbb/db/migration/data/v310/profilefield_field_validation_length.php

@@ -23,7 +23,7 @@ class profilefield_field_validation_length extends \phpbb\db\migration\migration
 		'ALPHA_SPACERS'		=> '[\w\x20_+\-\[\]]+',
 	);
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\rc3',

phpBB/phpbb/db/migration/data/v310/profilefield_googleplus.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class profilefield_googleplus extends \phpbb\db\migration\profilefield_base_migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\profilefield_contact_field',

phpBB/phpbb/db/migration/data/v310/profilefield_icq.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class profilefield_icq extends \phpbb\db\migration\profilefield_base_migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\profilefield_contact_field',

phpBB/phpbb/db/migration/data/v310/profilefield_icq_cleanup.php

@@ -20,7 +20,7 @@ class profilefield_icq_cleanup extends \phpbb\db\migration\migration
 		return !$this->db_tools->sql_column_exists($this->table_prefix . 'users', 'user_icq');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\profilefield_icq',

phpBB/phpbb/db/migration/data/v310/profilefield_interests.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class profilefield_interests extends \phpbb\db\migration\profilefield_base_migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\profilefield_types',

phpBB/phpbb/db/migration/data/v310/profilefield_location.php

@@ -15,7 +15,7 @@ namespace phpbb\db\migration\data\v310;
 
 class profilefield_location extends \phpbb\db\migration\profilefield_base_migration
 {
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\profilefield_types',

phpBB/phpbb/db/migration/data/v310/profilefield_location_cleanup.php

@@ -20,7 +20,7 @@ class profilefield_location_cleanup extends \phpbb\db\migration\migration
 		return !$this->db_tools->sql_column_exists($this->table_prefix . 'users', 'user_from');
 	}
 
-	static public function depends_on()
+	public static function depends_on()
 	{
 		return array(
 			'\phpbb\db\migration\data\v310\profilefield_location',