[ticket/10714] Use keys for the log data instead of requiring a special order

PHPBB3-10714
This commit is contained in:
Joas Schilling 2012-03-18 13:47:24 +01:00
parent 1539ad7ebe
commit cff15ec307
2 changed files with 13 additions and 9 deletions

View file

@ -3392,14 +3392,11 @@ function add_log()
case 'critical':
break;
case 'mod':
// forum_id
$additional_data[] = array_shift($args);
// topic_id
$additional_data[] = array_shift($args);
$additional_data['forum_id'] = array_shift($args);
$additional_data['topic_id'] = array_shift($args);
break;
case 'user':
// reportee_id
$additional_data[] = array_shift($args);
$additional_data['reportee_id'] = array_shift($args);
break;
default:
/**

View file

@ -115,18 +115,25 @@ class phpbb_log implements phpbb_log_interface
break;
case 'mod':
$forum_id = (int) $additional_data['forum_id'];
unset($additional_data['forum_id']);
$topic_id = (int) $additional_data['topic_id'];
unset($additional_data['topic_id']);
$sql_ary += array(
'log_type' => LOG_MOD,
'forum_id' => intval(array_shift($additional_data)),
'topic_id' => intval(array_shift($additional_data)),
'forum_id' => $forum_id,
'topic_id' => $topic_id,
'log_data' => (!sizeof($additional_data)) ? '' : serialize($additional_data),
);
break;
case 'user':
$reportee_id = (int) $additional_data['reportee_id'];
unset($additional_data['reportee_id']);
$sql_ary += array(
'log_type' => LOG_USERS,
'reportee_id' => intval(array_shift($additional_data)),
'reportee_id' => $reportee_id,
'log_data' => (!sizeof($additional_data)) ? '' : serialize($additional_data),
);
break;