From d06adb06e907e31918130a6ef010b73d454f396c Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Thu, 2 Aug 2012 21:22:52 +0200 Subject: [PATCH] [feature/php-events] Remove core.mcp_check_ids and invalid comment. We couldn't find a reason for this event, as it even doesn't have any arguments The comment is not correct anymore either. Since 3.1global announcements still have a valid forum_id PHPBB3-9550 --- phpBB/mcp.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/phpBB/mcp.php b/phpBB/mcp.php index b5cfa99d4c..730af65e3d 100644 --- a/phpBB/mcp.php +++ b/phpBB/mcp.php @@ -823,7 +823,7 @@ function mcp_sorting($mode, &$sort_days, &$sort_key, &$sort_dir, &$sort_by_sql, */ function check_ids(&$ids, $table, $sql_id, $acl_list = false, $single_forum = false) { - global $db, $auth, $phpbb_dispatcher; + global $db, $auth; if (!is_array($ids) || empty($ids)) { @@ -887,9 +887,5 @@ function check_ids(&$ids, $table, $sql_id, $acl_list = false, $single_forum = fa return false; } - // If forum id is false and ids populated we may have only global announcements selected (returning 0 because of (int) $forum_id) - - $phpbb_dispatcher->dispatch('core.mcp_check_ids'); - return ($single_forum === false) ? true : (int) $forum_id; }