makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-27 21:58:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/12575] Skip sniffer issue triggered by the solution of a php bug

Browse source 
https://bugs.php.net/bug.php?id=66834
https://bugs.php.net/bug.php?id=67067

PHPBB3-12575
This commit is contained in:
Tristan Darricau 2014-05-22 03:02:25 +02:00
parent 6e47886227
commit d4cc6990e4
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
phpBB/phpbb/di/service_collection.php
View file

@ -38,6 +38,12 @@ class service_collection extends \ArrayObject
return new service_collection_iterator($this->container, $this); return new service_collection_iterator($this->container, $this);
} }
// Because of a PHP issue we have to redefine offsetExists
// (even <ith a call to the parent):
// https://bugs.php.net/bug.php?id=66834
// https://bugs.php.net/bug.php?id=67067
// But it triggers a sniffer issue that we have to skip
// @codingStandardsIgnoreStart
/** /**
* {@inheritdoc} * {@inheritdoc}
*/ */
@ -45,6 +51,7 @@ class service_collection extends \ArrayObject
{ {
return parent::offsetExists($index); return parent::offsetExists($index);
} }
// @codingStandardsIgnoreEnd
/** /**
* {@inheritdoc} * {@inheritdoc}

7
phpBB/phpbb/di/service_collection_iterator.php
View file

@ -49,6 +49,12 @@ class service_collection_iterator extends \ArrayIterator
return $task; return $task;
} }
// Because of a PHP issue we have to redefine offsetExists
// (even <ith a call to the parent):
// https://bugs.php.net/bug.php?id=66834
// https://bugs.php.net/bug.php?id=67067
// But it triggers a sniffer issue that we have to skip
// @codingStandardsIgnoreStart
/** /**
* {@inheritdoc} * {@inheritdoc}
*/ */
@ -56,6 +62,7 @@ class service_collection_iterator extends \ArrayIterator
{ {
parent::offsetExists($index); parent::offsetExists($index);
} }
// @codingStandardsIgnoreEnd
/** /**
* {@inheritdoc} * {@inheritdoc}