From f04f07f26524b71f2859470da017224771c18700 Mon Sep 17 00:00:00 2001 From: Matt Friedman Date: Sat, 12 Apr 2025 14:00:31 -0700 Subject: [PATCH] [ticket/17494] Handle boolean attributes in checkbox assertions tests PHPBB-17494 --- tests/test_framework/phpbb_functional_test_case.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/test_framework/phpbb_functional_test_case.php b/tests/test_framework/phpbb_functional_test_case.php index 79e76fd1ae..bec0845f0a 100644 --- a/tests/test_framework/phpbb_functional_test_case.php +++ b/tests/test_framework/phpbb_functional_test_case.php @@ -1236,12 +1236,11 @@ class phpbb_functional_test_case extends phpbb_test_case * @param string $name * @param string $message * - * @return null + * @return void */ public function assert_checkbox_is_checked($crawler, $name, $message = '') { - $this->assertSame( - 'checked', + $this->assertNotNull( $this->assert_find_one_checkbox($crawler, $name)->attr('checked'), $message ?: "Failed asserting that checkbox $name is checked." ); @@ -1255,7 +1254,7 @@ class phpbb_functional_test_case extends phpbb_test_case * @param string $name * @param string $message * - * @return null + * @return void */ public function assert_checkbox_is_unchecked($crawler, $name, $message = '') {