From d9503225e47f10660e288f64832703a6e69b90fd Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sat, 17 Jul 2021 14:34:27 +0200 Subject: [PATCH] [ticket/16207] Stop setting session id when creating session PHPBB3-16207 --- phpBB/phpbb/session.php | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/phpBB/phpbb/session.php b/phpBB/phpbb/session.php index e3dcd3a37f..4c911da894 100644 --- a/phpBB/phpbb/session.php +++ b/phpBB/phpbb/session.php @@ -486,7 +486,7 @@ class session */ function session_create($user_id = false, $set_admin = false, $persist_login = false, $viewonline = true) { - global $SID, $_SID, $db, $config, $cache, $phpbb_container, $phpbb_dispatcher; + global $db, $config, $cache, $phpbb_container, $phpbb_dispatcher; $this->data = array(); @@ -697,8 +697,6 @@ class session $db->sql_query($sql); } - $SID = '?sid='; - $_SID = ''; return true; } else @@ -791,8 +789,6 @@ class session } // refresh data - $SID = '?sid=' . $this->session_id; - $_SID = $this->session_id; $this->data = array_merge($this->data, $sql_ary); if (!$bot) @@ -832,9 +828,6 @@ class session SET user_lastvisit = ' . (int) $this->data['session_time'] . ' WHERE user_id = ' . (int) $this->data['user_id']; $db->sql_query($sql); - - $SID = '?sid='; - $_SID = ''; } $session_data = $sql_ary;