makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10950] Update undelivered pm counts in batches not 1 by 1 for each user

Browse source 
PHPBB3-10950
This commit is contained in:
Joas Schilling 2012-07-16 17:22:10 +02:00
parent d883535b10
commit d9a32ce614
1 changed files with 18 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
phpBB/includes/functions_privmsgs.php
View file

@ -1175,16 +1175,29 @@ function phpbb_delete_user_pms($user_id)
while ($row = $db->sql_fetchrow($result)) while ($row = $db->sql_fetchrow($result))
{ {
$undelivered_user[$row['user_id']] = (int) $row['num_undelivered_privmsgs']; $num_pms = (int) $row['num_undelivered_privmsgs'];
$undelivered_user[$num_pms][] = (int) $row['user_id'];
if (sizeof($undelivered_user[$num_pms]) > 50)
{
// If there are too many users affected the query might get
// too long, so we update the value for the first bunch here.
$sql = 'UPDATE ' . USERS_TABLE . '
SET user_new_privmsg = user_new_privmsg - ' . $num_pms . ',
user_unread_privmsg = user_unread_privmsg - ' . $num_pms . '
WHERE ' . $db->sql_in_set('user_id', $undelivered_user[$num_pms]);
$db->sql_query($sql);
unset($undelivered_user[$num_pms]);
}
} }
$db->sql_freeresult($result); $db->sql_freeresult($result);
foreach ($undelivered_user as $undelivered_user_id => $count) foreach ($undelivered_user as $num_pms => $undelivered_user_set)
{ {
$sql = 'UPDATE ' . USERS_TABLE . ' $sql = 'UPDATE ' . USERS_TABLE . '
SET user_new_privmsg = user_new_privmsg - ' . $count . ', SET user_new_privmsg = user_new_privmsg - ' . $num_pms . ',
user_unread_privmsg = user_unread_privmsg - ' . $count . ' user_unread_privmsg = user_unread_privmsg - ' . $num_pms . '
WHERE user_id = ' . $undelivered_user_id; WHERE ' . $db->sql_in_set('user_id', $undelivered_user_set);
$db->sql_query($sql); $db->sql_query($sql);
} }