makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11202] Check response success before content assertions.

Browse source 
This does not change tests that perform requests which are either
clearly not supposed to succeed or are a gray area.

PHPBB3-11202
This commit is contained in:
Oleg Pudeyev 2012-11-15 08:20:07 -05:00
parent 4ab178f3ef
commit dc61fd1091
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/functional/browse_test.php
View file

@ -15,18 +15,21 @@ class phpbb_functional_browse_test extends phpbb_functional_test_case
public function test_index() public function test_index()
{ {
$crawler = $this->request('GET', 'index.php'); $crawler = $this->request('GET', 'index.php');
$this->assert_response_success();
$this->assertGreaterThan(0, $crawler->filter('.topiclist')->count()); $this->assertGreaterThan(0, $crawler->filter('.topiclist')->count());
} }
public function test_viewforum() public function test_viewforum()
{ {
$crawler = $this->request('GET', 'viewforum.php?f=2'); $crawler = $this->request('GET', 'viewforum.php?f=2');
$this->assert_response_success();
$this->assertGreaterThan(0, $crawler->filter('.topiclist')->count()); $this->assertGreaterThan(0, $crawler->filter('.topiclist')->count());
} }
public function test_viewtopic() public function test_viewtopic()
{ {
$crawler = $this->request('GET', 'viewtopic.php?t=1'); $crawler = $this->request('GET', 'viewtopic.php?t=1');
$this->assert_response_success();
$this->assertGreaterThan(0, $crawler->filter('.postbody')->count()); $this->assertGreaterThan(0, $crawler->filter('.postbody')->count());
} }
} }