makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-27 21:58:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Double escaping ....

Browse source 
git-svn-id: file:///svn/phpbb/trunk@3407 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Paul S. Owen 2003-01-29 23:14:34 +00:00
parent a1ddf8e73b
commit dd1187b6c6
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
phpBB/posting.php
View file

@ -335,7 +335,7 @@ if (isset($_REQUEST['post']))
{ {
$topic_sql = array( $topic_sql = array(
'forum_id' => intval($forum_id), 'forum_id' => intval($forum_id),
'topic_title' => $db->sql_escape(htmlspecialchars($subject)), 'topic_title' => htmlspecialchars($subject),
'topic_poster' => intval($user->data['user_id']), 'topic_poster' => intval($user->data['user_id']),
'topic_time' => $current_time, 'topic_time' => $current_time,
'topic_type' => (!empty($enable_icons)) ? intval($topic_type) : 0, 'topic_type' => (!empty($enable_icons)) ? intval($topic_type) : 0,
@ -345,7 +345,7 @@ if (isset($_REQUEST['post']))
if (!empty($poll_options)) if (!empty($poll_options))
{ {
$topic_sql = array_merge($topic_sql, array( $topic_sql = array_merge($topic_sql, array(
'poll_title' => $db->sql_escape($poll_title), 'poll_title' => $poll_title,
'poll_start' => (!empty($poll_start)) ? $poll_start : $current_time, 'poll_start' => (!empty($poll_start)) ? $poll_start : $current_time,
'poll_length' => $poll_length * 3600 'poll_length' => $poll_length * 3600
)); ));
@ -361,7 +361,7 @@ if (isset($_REQUEST['post']))
'topic_id' => intval($topic_id), 'topic_id' => intval($topic_id),
'forum_id' => intval($forum_id), 'forum_id' => intval($forum_id),
'poster_id' => ($mode == 'edit') ? intval($poster_id) : intval($user->data['user_id']), 'poster_id' => ($mode == 'edit') ? intval($poster_id) : intval($user->data['user_id']),
'post_username' => ($username != '') ? $db->sql_escape($username) : '', 'post_username' => ($username != '') ? $username : '',
'icon_id' => $icon_id, 'icon_id' => $icon_id,
'poster_ip' => $user->ip, 'poster_ip' => $user->ip,
'post_time' => $current_time, 'post_time' => $current_time,
@ -380,7 +380,7 @@ if (isset($_REQUEST['post']))
// post_text ... may merge into posts table // post_text ... may merge into posts table
$post_text_sql = array( $post_text_sql = array(
'post_subject' => $db->sql_escape(htmlspecialchars($subject)), 'post_subject' => htmlspecialchars($subject),
'bbcode_uid' => $bbcode_uid, 'bbcode_uid' => $bbcode_uid,
'post_id' => intval($post_id), 'post_id' => intval($post_id),
); );
@ -388,7 +388,7 @@ if (isset($_REQUEST['post']))
{ {
$post_text_sql = array_merge($post_text_sql, array( $post_text_sql = array_merge($post_text_sql, array(
'post_checksum' => $message_md5, 'post_checksum' => $message_md5,
'post_text' => $db->sql_escape($message), 'post_text' => $message,
)); ));
} }
$sql = ($mode == 'edit') ? 'UPDATE ' . POSTS_TEXT_TABLE . ' SET ' . $db->sql_build_array('UPDATE', $post_text_sql) . ' WHERE post_id = ' . intval($post_id) : 'INSERT INTO ' . POSTS_TEXT_TABLE . ' ' . $db->sql_build_array('INSERT', $post_text_sql); $sql = ($mode == 'edit') ? 'UPDATE ' . POSTS_TEXT_TABLE . ' SET ' . $db->sql_build_array('UPDATE', $post_text_sql) . ' WHERE post_id = ' . intval($post_id) : 'INSERT INTO ' . POSTS_TEXT_TABLE . ' ' . $db->sql_build_array('INSERT', $post_text_sql);
@ -455,7 +455,7 @@ if (isset($_REQUEST['post']))
'forum_last_post_id' => intval($post_id), 'forum_last_post_id' => intval($post_id),
'forum_last_post_time' => $current_time, 'forum_last_post_time' => $current_time,
'forum_last_poster_id' => intval($user->data['user_id']), 'forum_last_poster_id' => intval($user->data['user_id']),
'forum_last_poster_name'=> ($user->data['user_id'] == ANONYMOUS) ? $db->sql_escape($username) : $user->data['username'], 'forum_last_poster_name'=> ($user->data['user_id'] == ANONYMOUS) ? $username : $user->data['username'],
); );
$sql = 'UPDATE ' . FORUMS_TABLE . ' SET ' . $db->sql_build_array('UPDATE', $forum_sql) . ', forum_posts = forum_posts + 1' . $forum_topics_sql . ' WHERE forum_id IN (' . $forum_ids . ')'; $sql = 'UPDATE ' . FORUMS_TABLE . ' SET ' . $db->sql_build_array('UPDATE', $forum_sql) . ', forum_posts = forum_posts + 1' . $forum_topics_sql . ' WHERE forum_id IN (' . $forum_ids . ')';
$db->sql_query($sql); $db->sql_query($sql);