makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10841] changing affectedrows check to COUNT in sql

Browse source 
this sould reduce load and be faster. Also freeresult functions added

PHPBB3-10841
This commit is contained in:
Senky 2012-05-17 20:01:44 +02:00 • committed by Oleg Pudeyev
parent af064cdaad
commit dd6983b14b
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
phpBB/includes/ucp/ucp_prefs.php
View file

@ -134,11 +134,11 @@ class ucp_prefs
} }
$dateformat_options .= '>' . $user->lang['CUSTOM_DATEFORMAT'] . '</option>'; $dateformat_options .= '>' . $user->lang['CUSTOM_DATEFORMAT'] . '</option>';
// check for count of installed languages // check if there are any user-selectable languages
$sql = 'SELECT lang_id $sql = 'SELECT COUNT(lang_id) as languages_count
FROM ' . LANG_TABLE; FROM ' . LANG_TABLE;
$result = $db->sql_query($sql); $result = $db->sql_query($sql);
if( $db->sql_affectedrows() > 1 ) if( $db->sql_fetchfield('languages_count') > 1 )
{ {
$s_more_languages = true; $s_more_languages = true;
} }
@ -146,13 +146,14 @@ class ucp_prefs
{ {
$s_more_languages = false; $s_more_languages = false;
} }
$db->sql_freeresult($result);
// check for count of installed and active styles // check if there are any user-selectable styles
$sql = 'SELECT style_id $sql = 'SELECT COUNT(style_id) as styles_count
FROM ' . STYLES_TABLE . ' FROM ' . STYLES_TABLE . '
WHERE style_active = 1'; WHERE style_active = 1';
$result = $db->sql_query($sql); $result = $db->sql_query($sql);
if( $db->sql_affectedrows() > 1 ) if( $db->sql_fetchfield('styles_count') > 1 )
{ {
$s_more_styles = true; $s_more_styles = true;
} }
@ -160,6 +161,7 @@ class ucp_prefs
{ {
$s_more_styles = false; $s_more_styles = false;
} }
$db->sql_freeresult($result);
$template->assign_vars(array( $template->assign_vars(array(
'ERROR' => (sizeof($error)) ? implode('<br />', $error) : '', 'ERROR' => (sizeof($error)) ? implode('<br />', $error) : '',