[ticket/11469] Remove comments. Method names should be good enough now.

PHPBB3-11469
This commit is contained in:
Andreas Fischer 2013-03-28 00:03:48 +01:00
parent a04fe625a8
commit e022a7e8f6

View file

@ -29,77 +29,50 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
public function test_multi_insert_disabled_insert_and_flush() public function test_multi_insert_disabled_insert_and_flush()
{ {
$this->db->multi_insert = false; $this->db->multi_insert = false;
// This call can be buffered
$this->assertTrue($this->buffer->insert($this->get_row(1))); $this->assertTrue($this->buffer->insert($this->get_row(1)));
$this->assert_config_count(3); $this->assert_config_count(3);
// Manually flush
$this->assertFalse($this->buffer->flush()); $this->assertFalse($this->buffer->flush());
$this->assert_config_count(3); $this->assert_config_count(3);
} }
public function test_multi_insert_enabled_insert_and_flush() public function test_multi_insert_enabled_insert_and_flush()
{ {
$this->check_multi_insert_support(); $this->check_multi_insert_support();
// This call can be buffered
$this->assertFalse($this->buffer->insert($this->get_row(1))); $this->assertFalse($this->buffer->insert($this->get_row(1)));
$this->assert_config_count(2); $this->assert_config_count(2);
// Manually flush
$this->assertTrue($this->buffer->flush()); $this->assertTrue($this->buffer->flush());
$this->assert_config_count(3); $this->assert_config_count(3);
} }
public function test_multi_insert_disabled_insert_with_flush() public function test_multi_insert_disabled_insert_with_flush()
{ {
$this->db->multi_insert = false; $this->db->multi_insert = false;
$this->assertTrue($this->buffer->insert($this->get_row(1))); $this->assertTrue($this->buffer->insert($this->get_row(1)));
// This call flushes the values
$this->assertTrue($this->buffer->insert($this->get_row(2))); $this->assertTrue($this->buffer->insert($this->get_row(2)));
$this->assert_config_count(4); $this->assert_config_count(4);
} }
public function test_multi_insert_enabled_insert_with_flush() public function test_multi_insert_enabled_insert_with_flush()
{ {
$this->check_multi_insert_support(); $this->check_multi_insert_support();
$this->assertFalse($this->buffer->insert($this->get_row(1))); $this->assertFalse($this->buffer->insert($this->get_row(1)));
// This call flushes the values
$this->assertTrue($this->buffer->insert($this->get_row(2))); $this->assertTrue($this->buffer->insert($this->get_row(2)));
$this->assert_config_count(4); $this->assert_config_count(4);
} }
public function test_multi_insert_disabled_insert_all_and_flush() public function test_multi_insert_disabled_insert_all_and_flush()
{ {
$this->db->multi_insert = false; $this->db->multi_insert = false;
$this->assertTrue($this->buffer->insert_all($this->get_rows(3))); $this->assertTrue($this->buffer->insert_all($this->get_rows(3)));
$this->assert_config_count(5); $this->assert_config_count(5);
} }
public function test_multi_insert_enabled_insert_all_and_flush() public function test_multi_insert_enabled_insert_all_and_flush()
{ {
$this->check_multi_insert_support(); $this->check_multi_insert_support();
$this->assertTrue($this->buffer->insert_all($this->get_rows(3))); $this->assertTrue($this->buffer->insert_all($this->get_rows(3)));
$this->assert_config_count(4); $this->assert_config_count(4);
// Manually flush
$this->assertTrue($this->buffer->flush()); $this->assertTrue($this->buffer->flush());
$this->assert_config_count(5); $this->assert_config_count(5);
} }