[ticket/14492] Don't explicitly pass data providers by refs

PHPBB3-14492
This commit is contained in:
Marc Alexander 2016-08-31 21:33:56 +02:00
parent b9c284d85b
commit e02aca8399
No known key found for this signature in database
GPG key ID: 50E0D2423696F995

View file

@ -46,9 +46,9 @@ class phpbb_questionnaire_data_collector
$this->providers = array(); $this->providers = array();
} }
function add_data_provider(&$provider) function add_data_provider($provider)
{ {
$this->providers[] = &$provider; $this->providers[] = $provider;
} }
/** /**
@ -80,7 +80,7 @@ class phpbb_questionnaire_data_collector
{ {
foreach (array_keys($this->providers) as $key) foreach (array_keys($this->providers) as $key)
{ {
$provider = &$this->providers[$key]; $provider = $this->providers[$key];
$this->data[$provider->get_identifier()] = $provider->get_data(); $this->data[$provider->get_identifier()] = $provider->get_data();
} }
$this->data['install_id'] = $this->install_id; $this->data['install_id'] = $this->install_id;