From e0b4f3ff37dfbea6ffb559f46575de7cc86d26be Mon Sep 17 00:00:00 2001 From: 3D-I Date: Tue, 23 Mar 2021 02:01:45 +0100 Subject: [PATCH] [ticket/16735] Fix access array offset on value of type bool on login PHPBB3-16735 --- phpBB/phpbb/auth/provider/db.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/phpBB/phpbb/auth/provider/db.php b/phpBB/phpbb/auth/provider/db.php index a50e1343f6..adb6554e72 100644 --- a/phpBB/phpbb/auth/provider/db.php +++ b/phpBB/phpbb/auth/provider/db.php @@ -153,8 +153,10 @@ class db extends base } $login_error_attempts = 'LOGIN_ERROR_ATTEMPTS'; - $show_captcha = ($this->config['max_login_attempts'] && $row['user_login_attempts'] >= $this->config['max_login_attempts']) || - ($this->config['ip_login_limit_max'] && $attempts >= $this->config['ip_login_limit_max']); + + $show_captcha = ($row) ? ($this->config['max_login_attempts'] && $row['user_login_attempts'] >= $this->config['max_login_attempts']) || + ($this->config['ip_login_limit_max'] && $attempts >= $this->config['ip_login_limit_max']) : false; + if ($show_captcha) { $captcha = $this->captcha_factory->get_instance($this->config['captcha_plugin']);