diff --git a/phpBB/admin/admin_forums.php b/phpBB/admin/admin_forums.php
index 76efa5c65c..a501ae60da 100644
--- a/phpBB/admin/admin_forums.php
+++ b/phpBB/admin/admin_forums.php
@@ -511,7 +511,7 @@ switch ($mode)
}
?>
- |
+ |
@@ -578,7 +578,7 @@ switch ($mode)
}
?>
- |
+ |
@@ -743,7 +743,7 @@ while ($row = $db->sql_fetchrow($result))
?>
- |
+ |
diff --git a/phpBB/admin/admin_smilies.php b/phpBB/admin/admin_smilies.php
index a76899e965..549bac5831 100644
--- a/phpBB/admin/admin_smilies.php
+++ b/phpBB/admin/admin_smilies.php
@@ -94,6 +94,7 @@ if (isset($HTTP_POST_VARS['import_pak']))
{
if (!empty($HTTP_POST_VARS['smilies_pak']))
{
+ $smile_order = 0;
//
// The user has already selected a smilies_pak file.. Import it.
//
@@ -108,6 +109,7 @@ if (isset($HTTP_POST_VARS['import_pak']))
$smilies = array();
while ($row = $db->sql_fetchrow($result))
{
+ ++$smile_order;
$smilies[$row['code']] = 1;
}
}
@@ -159,11 +161,14 @@ if (isset($HTTP_POST_VARS['import_pak']))
}
else
{
+ ++$smile_order;
+
$sql = array(
'code' => $code,
'smile_url' => $smile_url,
'smile_height' => $smile_height,
'smile_width' => $smile_width,
+ 'smile_order' => $smile_order,
'emoticon' => $emotion
);
$db->sql_query_array('INSERT INTO ' . SMILIES_TABLE, $sql);
@@ -274,10 +279,12 @@ function update_smile(newimage)
}
function update_smile_dimensions()
{
- document.forms[0].smile_height.value = document.smile_image.height;
- document.forms[0].smile_width.value = document.smile_image.width;
+ if (document.smile_image.height)
+ {
+ document.forms[0].smile_height.value = document.smile_image.height;
+ document.forms[0].smile_width.value = document.smile_image.width;
+ }
}
-
//-->
@@ -291,7 +298,7 @@ function update_smile_dimensions()
|
- |
+ |
|
@@ -324,11 +331,34 @@ switch ($mode)
case 'edit':
$smile_id = intval($HTTP_GET_VARS['smile_id']);
+/*
$sql = 'SELECT *
FROM ' . SMILIES_TABLE . "
WHERE smilies_id = $smile_id";
$result = $db->sql_query($sql);
$smile_data = $db->sql_fetchrow($result);
+*/
+ $order_list = '';
+ $result = $db->sql_query('SELECT * FROM ' . SMILIES_TABLE . ' ORDER BY smile_order DESC');
+ while ($row = $db->sql_fetchrow($result))
+ {
+ if ($row['smilies_id'] == $smile_id)
+ {
+ $after = TRUE;
+ $smile_data = $row;
+ }
+ else
+ {
+ $selected = '';
+ if (!empty($after))
+ {
+ $selected = ' selected="selected"';
+ $after = FALSE;
+ }
+ $order_list = '' . $order_list;
+ }
+ }
+ $order_list = '' . $order_list;
$filename_list = '';
foreach ($smilies_images as $smile_url)
@@ -336,7 +366,7 @@ switch ($mode)
if ($smile_url == $smile_data['smile_url'])
{
$smile_selected = ' selected="selected"';
- $smile_edit_img = $smile_url;;
+ $smile_edit_img = $smile_url;
}
else
{
@@ -369,7 +399,7 @@ function update_smile_dimensions()
diff --git a/phpBB/admin/subSilver.css b/phpBB/admin/subSilver.css
index 58978f37fe..4b50962c2a 100644
--- a/phpBB/admin/subSilver.css
+++ b/phpBB/admin/subSilver.css
@@ -140,11 +140,6 @@ td.cat {
background-color: #D1D7DC;
}
-td.catBottom {
- background-image: url(../templates/subSilver/images/cellpic1.gif);
- background-color:#D1D7DC; border: #FFFFFF; height: 28px;
-}
-
.row1 {
background-color: #EFEFEF;
}
diff --git a/phpBB/db/mysql.php b/phpBB/db/mysql.php
index 1fafc51152..6a25ea9397 100644
--- a/phpBB/db/mysql.php
+++ b/phpBB/db/mysql.php
@@ -190,7 +190,7 @@ class sql_db
}
else
{
- $values[] = $var;
+ $values[] = (is_bool($var)) ? intval($var) : $var;
}
}
@@ -211,7 +211,7 @@ class sql_db
}
else
{
- $values[] = "$key = $var";
+ $values[] = (is_bool($var)) ? "$key = " . intval($var) : "$key = $var";
}
}
diff --git a/phpBB/install/schemas/mysql_schema.sql b/phpBB/install/schemas/mysql_schema.sql
index b1228dff87..c250a650a4 100644
--- a/phpBB/install/schemas/mysql_schema.sql
+++ b/phpBB/install/schemas/mysql_schema.sql
@@ -431,7 +431,9 @@ CREATE TABLE phpbb_smilies (
smile_url char(50),
smile_width tinyint(4) UNSIGNED NOT NULL,
smile_height tinyint(4) UNSIGNED NOT NULL,
+ smile_order tinyint(4) UNSIGNED NOT NULL,
emoticon char(50),
+ smile_on_posting tinyint(1) UNSIGNED DEFAULT '1' NOT NULL,
PRIMARY KEY (smilies_id)
);
diff --git a/phpBB/language/lang_english/lang_admin.php b/phpBB/language/lang_english/lang_admin.php
index f3250be0da..19094cf5b9 100644
--- a/phpBB/language/lang_english/lang_admin.php
+++ b/phpBB/language/lang_english/lang_admin.php
@@ -576,43 +576,52 @@ $lang['Click_return_forumadmin'] = 'Click %sHere%s to return to Forum Administra
//
// Smiley Management
//
-$lang['Emoticons_explain'] = 'From this page you can add, remove and edit the emoticons or smilies users can use in their posts and private messages.';
+$lang['Emoticons_explain'] = 'From this page you can add, remove and edit the emoticons or emoticons users can use in their posts and private messages.';
-$lang['Import_smilies'] = 'Import smilies pak';
-$lang['Import_smilies_explain'] = 'Unzip the smilies package to your smilies directory then select the correct information in this form to import it.';
+$lang['Import_smilies'] = 'Import emoticons pak';
+$lang['Import_smilies_explain'] = 'Unzip the emoticons package to your emoticons directory then select the correct information in this form to import it.';
-$lang['Smilies_import'] = 'Smilies pack import';
-$lang['No_smilies_pak'] = 'No smilies pack found';
+$lang['Smilies_import'] = 'Emoticons pack import';
+$lang['No_smilies_pak'] = 'No emoticons pack found';
$lang['Select_package'] = 'Select a package file';
-$lang['Delete_existing_smilies'] = 'Delete existing smilies before import';
+$lang['Delete_existing_smilies'] = 'Delete existing emoticons before import';
$lang['Smilies_conflicts'] = 'What should be done in case of conflicts?';
-$lang['Keep_existing_smilies'] = 'Keep existing smilies';
-$lang['Replace_existing_smilies'] = 'Replace existing smilies';
-$lang['Smilies_import_success'] = 'The smilies pack was imported successfully';
+$lang['Keep_existing_smilies'] = 'Keep existing emoticons';
+$lang['Replace_existing_smilies'] = 'Replace existing emoticons';
+$lang['Smilies_import_success'] = 'The emoticons pack was imported successfully';
-$lang['Export_smilies'] = 'Create smilies pak';
-$lang['Export_smilies_explain'] = 'To create a package of your currently installed smilies, %sclick here%s to download the smilies.pak file. Name this file appropriately, making sure to keep the .pak file extension then create a zip file containing all of your smilies images plus this .pak configuration file.';
+$lang['Export_smilies'] = 'Create emoticons pak';
+$lang['Export_smilies_explain'] = 'To create a package of your currently installed emoticons, %sclick here%s to download the emoticons.pak file. Name this file appropriately, making sure to keep the .pak file extension then create a zip file containing all of your emoticons images plus this .pak configuration file.';
-$lang['Add_smile'] = 'Add a new smile';
-$lang['Edit_smile'] = 'Edit smile';
+$lang['Add_smile'] = 'Add a new emoticon';
+$lang['Edit_smile'] = 'Edit emoticon';
-$lang['Smile_config'] = 'Smile configuration';
-$lang['Smile_code'] = 'Smile code';
-$lang['Smile_url'] = 'Smile image file';
-$lang['Smile_height'] = 'Smile height';
-$lang['Smile_width'] = 'Smile width';
-$lang['Smile_emotion'] = 'Smile emotion';
-$lang['Smile_add'] = 'Add a new smile';
-$lang['Smile_edit'] = 'Edit smile';
+$lang['Smilies_not_displayed'] = 'The following emoticons are not displayed on posting page';
+$lang['Reorder'] = 'Reorder';
+$lang['Up'] = 'Up';
+$lang['Down'] = 'Down';
+$lang['First'] = 'First';
+$lang['After_smile'] = 'After %s';
+$lang['Display_on_posting'] = 'Display on posting';
+
+$lang['Smile_config'] = 'Emoticon configuration';
+$lang['Smile_code'] = 'Emoticon code';
+$lang['Smile_url'] = 'Emoticon image file';
+$lang['Smile_height'] = 'Emoticon height';
+$lang['Smile_width'] = 'Emoticon width';
+$lang['Smile_order'] = 'Emoticon order';
+$lang['Smile_emotion'] = 'Emotion';
+$lang['Smile_add'] = 'Add a new emoticon';
+$lang['Smile_edit'] = 'Edit emoticon';
$lang['Smile'] = 'Smile';
$lang['Emotion'] = 'Emotion';
-$lang['Smile_deleted'] = 'This smile has been successfully removed';
-$lang['Smile_edited'] = 'This smile has been successfully updated';
-$lang['Smile_added'] = 'This smile has been successfully added';
-$lang['Smilies_imported'] = 'The smilies pack has been successfully imported';
+$lang['Smile_deleted'] = 'This emoticon has been successfully removed';
+$lang['Smile_edited'] = 'This emoticon has been successfully updated';
+$lang['Smile_added'] = 'This emoticon has been successfully added';
+$lang['Smilies_imported'] = 'The emoticons pack has been successfully imported';
-$lang['Click_return_smileadmin'] = 'Click %sHere%s to return to Smilies Administration';
+$lang['Click_return_smileadmin'] = 'Click %sHere%s to return to Emoticons Administration';
//