makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[feature/auth-refactor] Check that providers implement auth interface

Browse source 
PHPBB3-9734
This commit is contained in:
Joseph Warner 2013-07-11 14:54:00 -04:00
parent e674838d69
commit e2435f25d9
2 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
phpBB/includes/acp/acp_board.php
View file

@ -563,6 +563,12 @@ class acp_board
if (array_key_exists('auth.provider.' . $method, $auth_providers)) if (array_key_exists('auth.provider.' . $method, $auth_providers))
{ {
$provider = $auth_providers['auth.provider.' . $method]; $provider = $auth_providers['auth.provider.' . $method];
if (!($provider instanceof phpbb_auth_provider_interface))
{
throw new \RuntimeException($provider . ' must implement phpbb_auth_provider_interface');
}
if ($error = $provider->init()) if ($error = $provider->init())
{ {
foreach ($old_auth_config as $config_name => $config_value) foreach ($old_auth_config as $config_name => $config_value)

6
phpBB/includes/session.php
View file

@ -404,6 +404,12 @@ class phpbb_session
$method = basename(trim($config['auth_method'])); $method = basename(trim($config['auth_method']));
$provider = $phpbb_container->get('auth.provider.' . $method); $provider = $phpbb_container->get('auth.provider.' . $method);
if (!($provider instanceof phpbb_auth_provider_interface))
{
throw new \RuntimeException($provider . ' must implement phpbb_auth_provider_interface');
}
$ret = $provider->validate_session($this->data); $ret = $provider->validate_session($this->data);
if ($ret !== null && !$ret) if ($ret !== null && !$ret)
{ {